From patchwork Fri Mar 16 16:16:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10289397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 99A79601A0 for ; Fri, 16 Mar 2018 16:57:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8956728B7E for ; Fri, 16 Mar 2018 16:57:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7DEDE28BF0; Fri, 16 Mar 2018 16:57:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1C96E28B7E for ; Fri, 16 Mar 2018 16:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hmkvR4Wky4Shjwjyfive5vqHq82siSwPCN5/BpHSNnY=; b=s2kUixeWMPVlFM ddZm8VQEPsFu+Vr0ANoYjU4ibg5PNJApBzRWGeAWHj5mtDobIvs8wMbvrKH172TlWGmRSj474Eo4w jGcVae5f9JXf6g1Kr/1JeA4VonjYRXuauEz7o6Uo3E9QExH1QNB8IhTpRBlDXTRkmIaN5Z3klSXoU YBEUNmCTgY+vJW7HXZC9pJ12Ski1W99SZU+3GfSVWRE9s80GhjeuPoECE8IxGgzPY4lqEfNDbwB0r S9dfb291IuMtDWZ5H5xhpepV4avcF5Ak6AwgDK3NgWimj75k5mDK7SZk5qfsQKTWGE9G4EtPIrj7/ VjTKHNPIBgFtGLBd1KYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewsfs-0007kv-57; Fri, 16 Mar 2018 16:57:48 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ews2c-000769-Sl for linux-arm-kernel@lists.infradead.org; Fri, 16 Mar 2018 16:17:42 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CEC1C60592; Fri, 16 Mar 2018 16:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217025; bh=k286ILLDOEaleKNkYdeXfmnzFmqrz4oZGuI5cDKa90c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z5dx5Ft677Q1l+5gPpgcXMvs4v3Q/GoS2VgX1XYh4CCC9o0OE6NOy8uhxiUN9RA25 Bc69NEnPmSPQAw7A7zbWpv1itGZ0fyGx2I79d51iCmm8R7ApQdxuBeOFeVMGS74uK8 kcRGNUfSPiLc5zE+Y8ptfPhNiY5M8kwGssahUZhY= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1ADCD60D81; Fri, 16 Mar 2018 16:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217025; bh=k286ILLDOEaleKNkYdeXfmnzFmqrz4oZGuI5cDKa90c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z5dx5Ft677Q1l+5gPpgcXMvs4v3Q/GoS2VgX1XYh4CCC9o0OE6NOy8uhxiUN9RA25 Bc69NEnPmSPQAw7A7zbWpv1itGZ0fyGx2I79d51iCmm8R7ApQdxuBeOFeVMGS74uK8 kcRGNUfSPiLc5zE+Y8ptfPhNiY5M8kwGssahUZhY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1ADCD60D81 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v3 11/18] qlcnic: Eliminate duplicate barriers on weakly-ordered archs Date: Fri, 16 Mar 2018 12:16:24 -0400 Message-Id: <1521216991-28706-12-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> References: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180316_091716_262260_A041FB00 X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dept-GELinuxNICDev@cavium.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , Harish Patil , linux-arm-kernel@lists.infradead.org, Manish Chopra Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya Acked-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 46b0372..97c146e7 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter) wmb(); /* clear the interrupt trigger control register */ - writel(0, adapter->isr_int_vec); + writel_relaxed(0, adapter->isr_int_vec); intr_val = readl(adapter->isr_int_vec); do { intr_val = readl(adapter->tgt_status_reg);