From patchwork Fri Mar 16 16:16:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10290483 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DAE94601A0 for ; Fri, 16 Mar 2018 23:09:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0E77290E4 for ; Fri, 16 Mar 2018 23:09:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C4294290F1; Fri, 16 Mar 2018 23:09:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 30E65290E4 for ; Fri, 16 Mar 2018 23:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oi45ZUbNGwrUmQ+dDwssfV2K9lhjbDygSZ6lDj0drLg=; b=tvQ+ypf517HYQb t+wtbHfG2KAzbHPknpNNwQFjWoyqvRl9gJUBH81sTEHvQuonb9KZtHZgRP+todF9nhhyDe3ya5Uhr yxiQTFXBj3U/Nj+mg9Vsf6ny5zNRdgGArePYIVgJRigxqaV14RHL0uyYNM4iy46uAyow80/hr7b1P lJt30kTjpQ8LVM2S6KuBlYr8DLT/2DKQvAdL7boT5FNLxYW3iA1YFmQ+XKHfu6rCdnrSHVkvgtafQ 29FcMAVm4cBwzwfaWTs9+tMwqwujuaF7lOg3rjQ6YadWcf7JBlETnWPKH1P0Ti0t5OuvK/JBeBe6l SJPQGf5hZyPbXAtDKHhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewyT6-0001K9-Rv; Fri, 16 Mar 2018 23:09:00 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ews2h-0006F1-Hf for linux-arm-kernel@bombadil.infradead.org; Fri, 16 Mar 2018 16:17:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9rxlEHDnvYNhlACrKz8qLnJ0pKmrlGcW46wseniol2Q=; b=qvQO+zdfxSa5N+BSae/mQt/LG2 nr7A4ALBt5kV9W3Z2VAVQXKaskn0icwtaEax0FYWBGMH29cVsp2lEbqYnL88vaGnIxdGSqtZs26Wk GCQ2c/VmDgm/XZkxqr8+fRS7N0WQ7d74VqIMHejGkaOaHiFmvrOZctcLnSKZVn2nHn/PIXHx72yI8 HEr5CbxbcddTiHBMjLYMsPhGPbTaCLIEXKbNsHf426B/xVFx7vmBMZ7VDQlrFR1/KzM27JcN7INm+ IrP6gQvNt8cetPQU6gGYOoElG8A9bbbZPPLfpmlOpxYRNQYwbQQuDquPb4KevQ4KdMW6AwftjEk2D lsOqXY4A==; Received: from smtp.codeaurora.org ([198.145.29.96]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ews2d-0005RB-Ad for linux-arm-kernel@lists.infradead.org; Fri, 16 Mar 2018 16:17:16 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A5E5D60C64; Fri, 16 Mar 2018 16:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217027; bh=bSZiBLsGo4YssammwckQK4p545WfkiIE5nE0lM1uLxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TmiwwVL7I4C85/mv6YH4MTivzicfyDBMZfQQPLMz7/GmQ98z/sftaTNMbR+/g/aU6 mEwY+VftRciV0Xl4zI5gjbpFf4RWXUecB+Z47yHywjtHi4bdbrtesPxktwfOqqTh8C ZBl84gYU3PE5IsIgytsh5BIi57W8HShT+Kg2noVI= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0B9DA60D81; Fri, 16 Mar 2018 16:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217027; bh=bSZiBLsGo4YssammwckQK4p545WfkiIE5nE0lM1uLxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TmiwwVL7I4C85/mv6YH4MTivzicfyDBMZfQQPLMz7/GmQ98z/sftaTNMbR+/g/aU6 mEwY+VftRciV0Xl4zI5gjbpFf4RWXUecB+Z47yHywjtHi4bdbrtesPxktwfOqqTh8C ZBl84gYU3PE5IsIgytsh5BIi57W8HShT+Kg2noVI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0B9DA60D81 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v3 12/18] bnx2x: Eliminate duplicate barriers on weakly-ordered archs Date: Fri, 16 Mar 2018 12:16:25 -0400 Message-Id: <1521216991-28706-13-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> References: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180316_161715_492959_748F38F6 X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , Ariel Elior , everest-linux-l2@cavium.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c index 76a4668..3b2f1bd 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c @@ -170,7 +170,7 @@ static int bnx2x_send_msg2pf(struct bnx2x *bp, u8 *done, dma_addr_t msg_mapping) wmb(); /* Trigger the PF FW */ - writeb(1, &zone_data->trigger.vf_pf_channel.addr_valid); + writeb_relaxed(1, &zone_data->trigger.vf_pf_channel.addr_valid); /* Wait for PF to complete */ while ((tout >= 0) && (!*done)) {