From patchwork Fri Mar 16 16:16:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10290497 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 01D39601A0 for ; Fri, 16 Mar 2018 23:19:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EDE6B28FE1 for ; Fri, 16 Mar 2018 23:19:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E08BE290F2; Fri, 16 Mar 2018 23:19:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 66B3B28FE1 for ; Fri, 16 Mar 2018 23:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t57YL7SctNnT2bS0xqt/t/5AWdFirZVqd7hZJo79OfI=; b=bukKTa1j72/Krm lK45Iat4Wrm6yyVi9vkSV4N0Yr9PVXHcs2k0oiKPz3RgRigso8o15pgWa88rz2gngQum1jGxndZP1 HADsUyzXnGeFaD+zrTMq2wqJNcmRzEs9xdPaB4BfuHpoDSGidL07Jf7ar2N45IG8bIE7lnlId+7Qv hCAmcPTrlX0/M9sIg1LF3wSs+ySHjPQjXqNUmZ37bYKtytLRue1TpEgdcSCL+NXO5ELI3liMvF5Lq yBNsTvPRJrg+AJIXGH3JtGvh1OpcfnMHsyLy9IKlnP83Tdj6/X/2nZIPJzt5vckBEIGentmgpSjEq WaxD1QLZdvpURZjks56A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewydP-0000Os-8K; Fri, 16 Mar 2018 23:19:39 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewtdR-0000JU-UW for linux-arm-kernel@bombadil.infradead.org; Fri, 16 Mar 2018 17:59:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=at26QXuaWXMktGhLdfo6fURddp2/TQksYVM0G6SKdb0=; b=Smj/KhuW37NY2/Yb36bj4rC/Rk 7TlBqXEga05LNcoSOx+/VLnL31c37jsA658BJ4p1kJF5uxa8flq+6EZG1j4oZc8GG1qRTR9J6UiUP obKVcQ5d0whTJA3pZcug+hU0L3QDAYobx3JzcfjUZ0QdBPHG/D4q4EOQLK5egpBtXhwfZO6YaHu8+ C4A1MGaka4Y5i9zWjL6dKBkWkekfwAoz8OtF1VwPeZjW6/LUZhehAMGfHg30sEmes8we6Kn53RGJC Y31Koc/D4Q33OQ/7VWe/yJ6vlL7h9b1Cu9UGLFG7iQEaa6GfYRjF3N4i+xeWQhdwoyUABImhX0Qg0 xbSfu3tA==; Received: from smtp.codeaurora.org ([198.145.29.96]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ews2J-0004Rh-Vv for linux-arm-kernel@lists.infradead.org; Fri, 16 Mar 2018 16:16:56 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3407B60452; Fri, 16 Mar 2018 16:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217009; bh=Lk9hG/kYvdQ84qeMZ1/80li1BTtq8d3ikXu+OwE5EEM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jzVxBM3GwK1ldOAwFYLvHm9V3JOMpBseXAadDaDshCka749nfW4zC6Jn298hsfjuE qZoCONvk8Nu31gxBZXKPwMd5wo9HSsEXTdmc7cWQ0Z5hlVKripr3HCon5/trtcQNXH Jpefcv4gLMtvOK1Py+G/DPcTJo4dEFsI+SpxV2N0= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D8FE260F5F; Fri, 16 Mar 2018 16:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217008; bh=Lk9hG/kYvdQ84qeMZ1/80li1BTtq8d3ikXu+OwE5EEM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hoezqAnRUfCU+qxL1CNII51efovZTvrFrU4XUhffeZqbKvRT1DIzsq/3qHuzr2mqt lMHkHWRR4p4prxNzVUt6WSMQBnd6OmtxM+L726vTzwX3ua5/Blj7Z/j6rNbGJoFy3j u8HhNbS71wzbMM/hM7VbCpHWB7M8YABqPGnaT3r8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D8FE260F5F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v3 03/18] igbvf: eliminate duplicate barriers on weakly-ordered archs Date: Fri, 16 Mar 2018 12:16:16 -0400 Message-Id: <1521216991-28706-4-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> References: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180316_121656_108457_9B4AE603 X-CRM114-Status: GOOD ( 13.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c index 4214c15..edb1c34 100644 --- a/drivers/net/ethernet/intel/igbvf/netdev.c +++ b/drivers/net/ethernet/intel/igbvf/netdev.c @@ -251,7 +251,7 @@ static void igbvf_alloc_rx_buffers(struct igbvf_ring *rx_ring, * such as IA-64). */ wmb(); - writel(i, adapter->hw.hw_addr + rx_ring->tail); + writel_relaxed(i, adapter->hw.hw_addr + rx_ring->tail); } } @@ -2297,7 +2297,7 @@ static inline void igbvf_tx_queue_adv(struct igbvf_adapter *adapter, tx_ring->buffer_info[first].next_to_watch = tx_desc; tx_ring->next_to_use = i; - writel(i, adapter->hw.hw_addr + tx_ring->tail); + writel_relaxed(i, adapter->hw.hw_addr + tx_ring->tail); /* we need this if more than one processor can write to our tail * at a time, it synchronizes IO on IA64/Altix systems */