From patchwork Fri Mar 16 16:16:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10289393 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F2F8F602C2 for ; Fri, 16 Mar 2018 16:57:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2B3B2873F for ; Fri, 16 Mar 2018 16:57:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D74B6287EA; Fri, 16 Mar 2018 16:57:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6EE472873F for ; Fri, 16 Mar 2018 16:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SXQcxXpPbEiSWdtE7nq4/0fPmjWHbHaT5XQn6eykwFM=; b=qZO0Xxg+DMTXTa h0Xcsk+boQKzC2w7UunWsNBe/6nfp5NP3m4aiJiQiqhYap0ojQhE39uM8eHqKJ4HXl38aubjiv6rI vmXpXOhY4Mn81jdjkNJ/7IrYexCTwr6Sd7+z3VwyQKpm5uLM+JbV7GC53E30grqIRgyUiXg7YJkfM /ESPBg2y0YJC+vjzg0JOiMBgm60EQ79fPkKcjDeIOdqBKrfmU9h3rvaSf6OwWt/3hpxPGTXq/URWJ gjEGXAqI6UdTlgQLmgDdTP0jA8jbGx9Dx4rjp6fQUbNzLE+zT9Zx5/14yr3SFDfUry03jq6X4xcqQ S5t1dxzqWEchaW8IWm2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewsfI-0007AC-V6; Fri, 16 Mar 2018 16:57:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ews2g-0006g0-Uy for linux-arm-kernel@bombadil.infradead.org; Fri, 16 Mar 2018 16:17:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IP4tDQcZ9RsS3UFqEeY/m4MCkn2HjG36NXLA1KIvTP4=; b=q9f8l7zSeLyoyKr+BpFKSxNib+ wviGqwTSuTJl5pmc4zrlPwJo0VDnieBRjMT6NbILpuxoHzjktIteP3tV8Z4oTJ1UCSd1EyDuLE438 rwICh5CAYaAHVwXMThFFG6uPmuYfxnAQTN8Vm7t7Jh6DWwqr20tzAAtWlb5nNxTIBr+wZWrI6QsJt DBWKQqPxnsFJrCCY29iW3eMwdZPKc1dz5+bpvv6pD2jdDE24z3HXMCtGupa23wDm17dJaoBeanjpJ 7+N/2Fji58KMIiGgw20AumBhJat0FrUc7nGe8RCebKsfCqdZ/Jc6oJylALzX1GBVrhlH7VtmAzNtD omR+yHhg==; Received: from smtp.codeaurora.org ([198.145.29.96]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ews2d-0005PL-Ac for linux-arm-kernel@lists.infradead.org; Fri, 16 Mar 2018 16:17:17 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6D39D60F8D; Fri, 16 Mar 2018 16:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217021; bh=W9/yviHskqvwFPloVpoKaCcmJwlqdPqG2IWrksKoXY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eNcGtAWWetgUcdm6nYeQ8/uGK8ak3qWgPq3tWk5p6zagUMIWYy5S78Yk5WgtBgw9K 1EIQ1aeb8Zx3t01hRxhfOl7u6t//i6hHLvpuX0WBe5RQk9xxlOAGfZThFRB43ik9Cy a3YyRwpC6fJSvNh2533XUU8hHyb/nOYr38dz58/k= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8B4C460390; Fri, 16 Mar 2018 16:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217020; bh=W9/yviHskqvwFPloVpoKaCcmJwlqdPqG2IWrksKoXY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XpLbgktcx7q0nf24IFOwQFpwfmHt089eALpvpOCp50TvDOeOQRJHCSBOfAKk2lz6I iUyi96Q/YzlziahdQWIjTmHH5rk+aLCq4o98hypvtcZ8TR/VpCMSYD948fpCjfPVvl mj91nAkYOgTE+jrrSZQVqgJuX/Q32dC+pxck/EYI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8B4C460390 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v3 08/18] scsi: hpsa: Eliminate duplicate barriers on weakly-ordered archs Date: Fri, 16 Mar 2018 12:16:21 -0400 Message-Id: <1521216991-28706-9-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> References: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180316_161715_494746_3F0FB718 X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Don Brace , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, esc.storagedev@microsemi.com, linux-kernel@vger.kernel.org, Sinan Kaya , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/scsi/hpsa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index 018f980..c7d7e6a 100644 --- a/drivers/scsi/hpsa.h +++ b/drivers/scsi/hpsa.h @@ -599,7 +599,7 @@ static unsigned long SA5_ioaccel_mode1_completed(struct ctlr_info *h, u8 q) * but with current driver design this is easiest. */ wmb(); - writel((q << 24) | rq->current_entry, h->vaddr + + writel_relaxed((q << 24) | rq->current_entry, h->vaddr + IOACCEL_MODE1_CONSUMER_INDEX); atomic_dec(&h->commands_outstanding); }