From patchwork Tue Mar 20 02:42:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10295989 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9DE77605F3 for ; Tue, 20 Mar 2018 02:44:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8EB6D2922E for ; Tue, 20 Mar 2018 02:44:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 82CA329233; Tue, 20 Mar 2018 02:44:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1C3D22922E for ; Tue, 20 Mar 2018 02:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EtZ8Xar/NNlmG9+GWfR2XWBMaV0J5+xvK4i+/1I2Rek=; b=Dezf+pDZZz/DEj VhwOV0yFxsMal7b/yr9iTeeKY7dGDmbla1ctXr1r09qHRKTEgbTxTV0zhfUrlNC3t6a1sfqUdb8Tp lKUNXy+rCCFbP0NkSz6lZmtnwoacXC189eLhu0YRNRJR+EIHPSjBdPblLQ4T0xmHCb4RZ2gnUTpkK rKv+GE8PNsFnW4IAwmmcn3hBnr3DXAXcYMgIZ2ELQfX9QbYjSA0D8J1ly0+B8Jl7kPHx4QDzjMB4N NQ6CtYwP2G4u6rLqhvdsRtrZlu5eQ9VbrDIXni/LlwQe1Txwck55FATUMi7Lsntx+n0FRkjxyf/JU WIup0qSeDckQuyZifhFg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7GE-00019H-Cx; Tue, 20 Mar 2018 02:44:26 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7Es-000079-5Z for linux-arm-kernel@lists.infradead.org; Tue, 20 Mar 2018 02:43:06 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6E5A260F94; Tue, 20 Mar 2018 02:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521513777; bh=UFFOJEvdJGTDlskSZ9RxFXJXMm/Hcw+E4NHzfNse+5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NvQLtQrdPKQORSuGL4vC9BebKg6S5CXhJwo1eknMtE7b168qYd9S6W0Y4SfZ6At/O YZSI+8q72TRKKl6HRjPAPyEEcVTE0DprwaUzqLQHSG4DdCQXGKv0ycZg9Ug5TAUww/ OTUQk9HVYtmZ1NnCmxTQgPXwGblkD8tCMunwvh90= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A46DC60F72; Tue, 20 Mar 2018 02:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521513775; bh=UFFOJEvdJGTDlskSZ9RxFXJXMm/Hcw+E4NHzfNse+5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ESnUnQHEm3t5OAY0SvwvNZ6npOyWCAe68EbrNm7o+EJ/Fvrk2UowQfUZ/TduTb8Lg qNFEcTzVTZCySoGcBc+QpGBRI8Gfg5G50R9K++Vec2RiXkghZgclYyDSmFvrhstq4Z txAap+KsNx7Kr3u8nTPL8TT+0rnmMdM0TKZNP8x0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A46DC60F72 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v4 10/17] qlcnic: Eliminate duplicate barriers on weakly-ordered archs Date: Mon, 19 Mar 2018 22:42:25 -0400 Message-Id: <1521513753-7325-11-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521513753-7325-1-git-send-email-okaya@codeaurora.org> References: <1521513753-7325-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180319_194302_703743_C40092FC X-CRM114-Status: GOOD ( 12.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dept-GELinuxNICDev@cavium.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , Harish Patil , linux-arm-kernel@lists.infradead.org, Manish Chopra Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya Acked-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 46b0372..97c146e7 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter) wmb(); /* clear the interrupt trigger control register */ - writel(0, adapter->isr_int_vec); + writel_relaxed(0, adapter->isr_int_vec); intr_val = readl(adapter->isr_int_vec); do { intr_val = readl(adapter->tgt_status_reg);