From patchwork Tue Mar 20 02:42:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10295971 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3DF88600F6 for ; Tue, 20 Mar 2018 02:43:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C8B42922E for ; Tue, 20 Mar 2018 02:43:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 20E612923F; Tue, 20 Mar 2018 02:43:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 862B72922E for ; Tue, 20 Mar 2018 02:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dfDWd3U9oUhSEyTl7EmnTz5Xzq0Rsvwrz7+MCY64ZIc=; b=Zx3phyfpskJGPl eObmkip5fpNOhoxEAyAoedfX3PokxxUGiZOZyIeCrQAjKc4sWP8MveiBVJdFbaYnzjClhxMbzlCXD UdGlZ7erI1LXAgbjmP3lOWhXNYUPWDUb0aHv2dvRmBL3fMxwQAggwWBrkvyxUOG2reDMCy6EeJlry jQISZG8NWbOehge7dwlEaEXw+BmcnHV628jLp0YN1CH0qwjjEINvTISso4jpyNgw43nKe0kKOWE/m Iz5o6DmyOVZzc7dtzXm6+GlPFYTwPmDNVIvostCK4e4Z0W2VcTFyKPp6ABybg1v/Qq2ouFGInlrHU lhOAJMCtqxh93RmvWJCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7FB-0000QG-Cs; Tue, 20 Mar 2018 02:43:21 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7Ef-0008TG-Nf for linux-arm-kernel@lists.infradead.org; Tue, 20 Mar 2018 02:42:51 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5958060F6E; Tue, 20 Mar 2018 02:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521513761; bh=2H9QFEk86A9ARflRws4pF/kG3G744iXzzqx4++hiQfI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VflA4bOmuiMNILnaV7pdCaA1LbDqcsVQTOLU14zi+w3EAHmItTxzybQZm76Y+x2gZ 5rvnE5FbPsyPtIQJk4FJ4SuX1OU+SiECs1vcLqS6c4vzC+f3u8DAKftUPKCrbAQxIN dZbE3Mfvd0dfqj55aFHBqW3hJZNV5YztBb5atUqE= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id EDC7960C5F; Tue, 20 Mar 2018 02:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521513760; bh=2H9QFEk86A9ARflRws4pF/kG3G744iXzzqx4++hiQfI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wlcc7woozsZwRtnHqQeXnS06ymootxj8/bL8BSeiKu8A8LsMTirz0KItTj3lirGfy BVmwCpAeSTO50OQkEnkxb8RzelR1rJv1N87tUJOkLJDS16O9RsGNCgLRal/MBUJo3f OKtmgC07tBZm1wN2rZvNmJ5pRW5vMT5dYyuIrzWc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EDC7960C5F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v4 02/17] ixgbe: eliminate duplicate barriers on weakly-ordered archs Date: Mon, 19 Mar 2018 22:42:17 -0400 Message-Id: <1521513753-7325-3-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521513753-7325-1-git-send-email-okaya@codeaurora.org> References: <1521513753-7325-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180319_194249_953647_FA600B6D X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya Reviewed-by: Alexander Duyck --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 0da5aa2..58ed70f 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -1692,7 +1692,7 @@ void ixgbe_alloc_rx_buffers(struct ixgbe_ring *rx_ring, u16 cleaned_count) * such as IA-64). */ wmb(); - writel(i, rx_ring->tail); + writel_relaxed(i, rx_ring->tail); } } @@ -2453,7 +2453,7 @@ static int ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector, * know there are new descriptors to fetch. */ wmb(); - writel(ring->next_to_use, ring->tail); + writel_relaxed(ring->next_to_use, ring->tail); xdp_do_flush_map(); } @@ -8078,7 +8078,7 @@ static int ixgbe_tx_map(struct ixgbe_ring *tx_ring, ixgbe_maybe_stop_tx(tx_ring, DESC_NEEDED); if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) { - writel(i, tx_ring->tail); + writel_relaxed(i, tx_ring->tail); /* we need this if more than one processor can write to our tail * at a time, it synchronizes IO on IA64/Altix systems @@ -10014,7 +10014,7 @@ static void ixgbe_xdp_flush(struct net_device *dev) * are new descriptors to fetch. */ wmb(); - writel(ring->next_to_use, ring->tail); + writel_relaxed(ring->next_to_use, ring->tail); return; }