From patchwork Tue Mar 20 02:42:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10296027 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E8039602C2 for ; Tue, 20 Mar 2018 02:47:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D57F129237 for ; Tue, 20 Mar 2018 02:47:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA53F29241; Tue, 20 Mar 2018 02:47:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4A2EF29237 for ; Tue, 20 Mar 2018 02:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0UK+rSJkW9KJh+76ucLM6yk8Iad+EoPzZpx4OPmGZ3g=; b=MZjBvn05ndDz3B wvj9EAA0arveAAQavowP9DwDT4RWAfw6vVGZWl+XMcGpoloTUqiacWbOj2UpNBr0tyJJ0qg9WUtMz gMMN709U5AayM18dwyUOAUjTyO6DACG0zNDh1iB9ZGyNuGYhzPo8tK+wY6ay5TEfQzfDect9gU+oA ll6H90xDo1jLbloLLu4h8EwIdVx7Hmvmq2vMjyfN/+lAw8YzTisF3KvemTVvkNqtnHwDOKaK05hq/ M4B0nmhMzuanpXluIWKU6o9g0hybFCd1OiWlKKjTY92YWoXYeNCwdlz+vOkPGU+n6QKIWNi2mC2dX AKGlxrChLjXl1uBYLrXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7In-0003cp-4c; Tue, 20 Mar 2018 02:47:05 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7Es-0008Ve-5W for linux-arm-kernel@lists.infradead.org; Tue, 20 Mar 2018 02:43:13 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 979C660F6D; Tue, 20 Mar 2018 02:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521513767; bh=CtgZnF+hKcsS6wiogdlq2V9WwzHipk7ZA8n6embbddU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DWc773SRhoYvzSbiy85OmV08OoEjBrfLCDKea/Wx+IFAakNOtCuPORGhPk9SpsLSm VLdCRiEafLtKNlvbQt1AmSIRLzpLVBvjir8dyoNIcTaBKf9syJQ117PlZB8Io1zh17 q8ia18QhzJw8lA7/aSMnpc2P66ggpVCWb7IR84tk= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id CD36A60F6B; Tue, 20 Mar 2018 02:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521513766; bh=CtgZnF+hKcsS6wiogdlq2V9WwzHipk7ZA8n6embbddU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H8OP+HxbeaqY3JoPHk4iaCmEjb6tCJMcg7E+KjkkeYeCnvf5iqghfY8nMBNnUu5yF ruhu88ATDaGRcnkovSIVUmZ9iurSPzH7yzS9ZTzqwCnOSrUXI2MCs5gzWm+aLixr9b xtEsvriMvJUZX94mCG4/fVaxhbFFr2L+OIDmNLV4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CD36A60F6B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v4 06/17] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Date: Mon, 19 Mar 2018 22:42:21 -0400 Message-Id: <1521513753-7325-7-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521513753-7325-1-git-send-email-okaya@codeaurora.org> References: <1521513753-7325-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180319_194302_921764_90ED7744 X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya Reviewed-by: Alexander Duyck --- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c index 6bf778a..774b2a6 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c @@ -659,7 +659,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring, * such as IA-64). */ wmb(); - writel(i, rx_ring->tail); + writel_relaxed(i, rx_ring->tail); } } @@ -3644,7 +3644,7 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring, tx_ring->next_to_use = i; /* notify HW of packet */ - writel(i, tx_ring->tail); + writel_relaxed(i, tx_ring->tail); return; dma_error: