From patchwork Tue Mar 20 02:47:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10296153 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AC76660385 for ; Tue, 20 Mar 2018 03:03:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 99ADE291AD for ; Tue, 20 Mar 2018 03:03:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B01C291AF; Tue, 20 Mar 2018 03:03:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0F64C291AD for ; Tue, 20 Mar 2018 03:03:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YKg/nHvaSmpXJovYpVOKo4CnjIoJ8ooZHRH1lGDUOzo=; b=Lx9/Nipgh3tjyW z74qtf9MMAXf3ERHEnNv6/Vulkf5sazXaL9SC7K4Gk+/bCJdMI23WHka4nCyXgbdLTtRiDVCC+EJw Os2L4APKz9a3z2WWdp6AtS+3V8ksEkvHX0XxDtJPxy9A8G8fg0JsNvrOLMc9j/EI4ufaH3RPeJ+6n n7J9lejb8djmC3HXbPwJqxhR6LLQtHoOMm3c3Aq3pqAr9dzEfY2BLp/Ooh1j4LG3dEORlcaIlE4n6 TBTgVZ8RlN7NL8cbHjf3ndo632iDEVmr/Tm1D8zOtGnuDNA+eWgKZjGz43UJnrRGVCTUuE8twHyB1 rUK+Nio2Ne+XA5tdXmeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7Y6-0006ac-QL; Tue, 20 Mar 2018 03:02:54 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7VU-0003OI-Ui for linux-arm-kernel@bombadil.infradead.org; Tue, 20 Mar 2018 03:00:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GWT/SA8gk0HcJsMvayk8oCeiPxHcpEMr+tVHkO3WVFs=; b=a8NUNTAfclTFGHGFQNUGW4CgUP yWPFRH0pMdXRaJham9ARQmmzyaP87iZPp0tF7tYPliQldKC3Tc851Ui3Mdx1Es79GnHr3S9gxRGdv LSLAcAd1aOSnfQyP88bH4aeeHpgnQ31yZ7zi5SpWI4J5kMXsgR0SDAfFMHHpNSeN1QdGsnUe1mcyZ 8SZWm70tehD9YF6RoVckOk/jXRjUoQDaMEaYvzZLGSLEwLxap3e7UQGVuoIuw3kFBW2gHMciUGtLk 7ugGN82Kk7MptQmtYBaTzZBkf3N+fOzYxMYd3Fro92gBu4tvs4OSTlXyUxdhIKD4LoGgR5IQXe00l gJxBir/Q==; Received: from smtp.codeaurora.org ([198.145.29.96]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7Jo-0000hJ-8B for linux-arm-kernel@lists.infradead.org; Tue, 20 Mar 2018 02:48:09 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D839E60F8D; Tue, 20 Mar 2018 02:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521514077; bh=u4onTMB/28dcawklWyavj35azfqXL6UF/ueOPVhCk7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JVaj/rECdol6aSzTQr9KB26QiqvREO0ZsYoZ7KbGPcLQwvi/iw+GyfO+U9dn0taGZ DB3L0fnNmzL8jmgc9g8AkRkL+cJ6QAm7nvvxHIiBp2vdokiifqWHbuNMNEngUDEoZg rtvLjp/RbiH09h9GTQBXjdqTbSqExR36EERUCASo= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0D57D6081C; Tue, 20 Mar 2018 02:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521514075; bh=u4onTMB/28dcawklWyavj35azfqXL6UF/ueOPVhCk7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hg9J9vYZN5VzKkl5r8dvYR8X0YrQqdpkZFws9ofeRQu8gW7twpOlLWwd9fZTI3pzh Sa5WLE5Mxf209zgeAZ7VTyFIYh2+jAudfRgJO/QpP+X/O0yYUePxhtdW14NFR682pX oLVHfO6YnPlDkz63THMeEXQ9yB6t9Nx9jpzLIhNk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0D57D6081C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-rdma@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v4 1/6] RDMA/bnxt_re: Eliminate duplicate barriers on weakly-ordered archs Date: Mon, 19 Mar 2018 22:47:43 -0400 Message-Id: <1521514068-8856-2-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521514068-8856-1-git-send-email-okaya@codeaurora.org> References: <1521514068-8856-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180320_024808_437442_D1215B4E X-CRM114-Status: GOOD ( 11.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Selvin Xavier , Sriharsha Basavapatna , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Somnath Kotur , Sinan Kaya , Jason Gunthorpe , Doug Ledford , Devesh Sharma , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c index 8329ec6..4a6b981 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c @@ -181,10 +181,10 @@ static int __send_message(struct bnxt_qplib_rcfw *rcfw, struct cmdq_base *req, /* ring CMDQ DB */ wmb(); - writel(cmdq_prod, rcfw->cmdq_bar_reg_iomem + - rcfw->cmdq_bar_reg_prod_off); - writel(RCFW_CMDQ_TRIG_VAL, rcfw->cmdq_bar_reg_iomem + - rcfw->cmdq_bar_reg_trig_off); + writel_relaxed(cmdq_prod, rcfw->cmdq_bar_reg_iomem + + rcfw->cmdq_bar_reg_prod_off); + writel_relaxed(RCFW_CMDQ_TRIG_VAL, rcfw->cmdq_bar_reg_iomem + + rcfw->cmdq_bar_reg_trig_off); done: spin_unlock_irqrestore(&cmdq->lock, flags); /* Return the CREQ response pointer */