From patchwork Tue Mar 20 02:47:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10296139 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 04918602C2 for ; Tue, 20 Mar 2018 02:54:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6BEF219AC for ; Tue, 20 Mar 2018 02:54:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D838826CF9; Tue, 20 Mar 2018 02:54:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1FABD219AC for ; Tue, 20 Mar 2018 02:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bNWgPzU1Ob24WnQgdlb6AdAGK+rHCKKhzhpjcU9fzT4=; b=n21ahEwx4b+YzS VOjPVWwdveB55/Eld2Z6MCZwgSIhtf77ZXQv7/fsEOafH5Oj30T8XonXaVsaS9j/d9gWLNR2VkDU2 511Y5krPVUSEVNs6k1V/jmFZqGKolF4vhjRFsjdCXzASAA3FiNuu+I4Vh8gui4qgcnduD6Q/WAVT9 goOM4HRQfnhtYGmK3agrP2aeZO03fZPnVxUnkbFZdrp1JiqppMbb54/35N+d5pEqBnmmam4kehieo kBam0pLrxkOVV/oYaiiN/hkWHf/oUFaU7Mg4FRbFfGGBXqbm8ZnXMof5rGCVWXWlf4brAnmOv+fDu vU8uP8b5YOcpqO2XFDuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7QG-0000Bt-1e; Tue, 20 Mar 2018 02:54:48 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ey7K0-0004aW-Bi for linux-arm-kernel@lists.infradead.org; Tue, 20 Mar 2018 02:49:59 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 10C0060FEB; Tue, 20 Mar 2018 02:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521514085; bh=TNyfmiY8kgT7C4dGpBk3Td2ZzWVSbNByoAO7CB9TA7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IeyFoYrDzMP/JjQ/uVnmA4Dtip9xqvzUbH1unCJEwHQb+pb5/6zwY5YYeOoTbJB8h ic5ZlfC15jga03OUFw/APlhCeC6AWcaRGG/sGLkMTRCr4H/wW13snDCVhv+A8S0txt zS9HSC/FRWo/tLO7PIA/8EP6Pll6eumHHC8l0Cec= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DFBB4610D9; Tue, 20 Mar 2018 02:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521514082; bh=TNyfmiY8kgT7C4dGpBk3Td2ZzWVSbNByoAO7CB9TA7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dB/d1WDmQbyJyIg5vZafV55imKTVwdZrlEfWk/b7q79q3FTOP4W1UcwmkGsPAPmMB 4wGySWlwfW8ZLc+26mJRu6Z3DK/idVBgGEzlenw7yG7nwY6P17QVcSctNCmk9ESNDw uWfuf0WHi/+jLoaIuLq/RUz8vVP27lyU3MxgKPF0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DFBB4610D9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-rdma@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v4 5/6] IB/nes: Eliminate duplicate barriers on weakly-ordered archs Date: Mon, 19 Mar 2018 22:47:47 -0400 Message-Id: <1521514068-8856-6-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521514068-8856-1-git-send-email-okaya@codeaurora.org> References: <1521514068-8856-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180319_194821_468903_CCE9299C X-CRM114-Status: GOOD ( 14.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Faisal Latif , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , Jason Gunthorpe , Doug Ledford , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes barrier() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Create a new wrapper function with relaxed write operator. Use the new wrapper when a write is following a barrier(). Signed-off-by: Sinan Kaya --- drivers/infiniband/hw/nes/nes.h | 5 +++++ drivers/infiniband/hw/nes/nes_hw.c | 21 ++++++++++++++------- drivers/infiniband/hw/nes/nes_mgt.c | 15 ++++++++++----- drivers/infiniband/hw/nes/nes_nic.c | 2 +- drivers/infiniband/hw/nes/nes_utils.c | 3 ++- drivers/infiniband/hw/nes/nes_verbs.c | 5 +++-- 6 files changed, 35 insertions(+), 16 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes.h b/drivers/infiniband/hw/nes/nes.h index 00c27291..85e007d 100644 --- a/drivers/infiniband/hw/nes/nes.h +++ b/drivers/infiniband/hw/nes/nes.h @@ -387,6 +387,11 @@ static inline void nes_write_indexed(struct nes_device *nesdev, u32 reg_index, u spin_unlock_irqrestore(&nesdev->indexed_regs_lock, flags); } +static inline void nes_write32_relaxed(void __iomem *addr, u32 val) +{ + writel_relaxed(val, addr); +} + static inline void nes_write32(void __iomem *addr, u32 val) { writel(val, addr); diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c index 18a7de1..568e17d 100644 --- a/drivers/infiniband/hw/nes/nes_hw.c +++ b/drivers/infiniband/hw/nes/nes_hw.c @@ -1257,7 +1257,8 @@ int nes_destroy_cqp(struct nes_device *nesdev) barrier(); /* Ring doorbell (5 WQEs) */ - nes_write32(nesdev->regs+NES_WQE_ALLOC, 0x05800000 | nesdev->cqp.qp_id); + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, + 0x05800000 | nesdev->cqp.qp_id); spin_unlock_irqrestore(&nesdev->cqp.lock, flags); @@ -1594,7 +1595,8 @@ static void nes_replenish_nic_rq(struct nes_vnic *nesvnic) atomic_dec(&nesvnic->rx_skbs_needed); barrier(); if (++rx_wqes_posted == 255) { - nes_write32(nesdev->regs+NES_WQE_ALLOC, (rx_wqes_posted << 24) | nesnic->qp_id); + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, + (rx_wqes_posted << 24) | nesnic->qp_id); rx_wqes_posted = 0; } } else { @@ -1612,7 +1614,8 @@ static void nes_replenish_nic_rq(struct nes_vnic *nesvnic) } while (atomic_read(&nesvnic->rx_skbs_needed)); barrier(); if (rx_wqes_posted) - nes_write32(nesdev->regs+NES_WQE_ALLOC, (rx_wqes_posted << 24) | nesnic->qp_id); + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, + (rx_wqes_posted << 24) | nesnic->qp_id); nesnic->replenishing_rq = 0; } @@ -1795,7 +1798,8 @@ int nes_init_nic_qp(struct nes_device *nesdev, struct net_device *netdev) barrier(); /* Ring doorbell (2 WQEs) */ - nes_write32(nesdev->regs+NES_WQE_ALLOC, 0x02800000 | nesdev->cqp.qp_id); + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, + 0x02800000 | nesdev->cqp.qp_id); spin_unlock_irqrestore(&nesdev->cqp.lock, flags); nes_debug(NES_DBG_INIT, "Waiting for create NIC QP%u to complete.\n", @@ -1844,7 +1848,8 @@ int nes_init_nic_qp(struct nes_device *nesdev, struct net_device *netdev) do { counter = min(wqe_count, ((u32)255)); wqe_count -= counter; - nes_write32(nesdev->regs+NES_WQE_ALLOC, (counter << 24) | nesvnic->nic.qp_id); + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, + (counter << 24) | nesvnic->nic.qp_id); } while (wqe_count); timer_setup(&nesvnic->rq_wqes_timer, nes_rq_wqes_timeout, 0); nes_debug(NES_DBG_INIT, "NAPI support Enabled\n"); @@ -1988,7 +1993,8 @@ void nes_destroy_nic_qp(struct nes_vnic *nesvnic) barrier(); /* Ring doorbell (2 WQEs) */ - nes_write32(nesdev->regs+NES_WQE_ALLOC, 0x02800000 | nesdev->cqp.qp_id); + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, + 0x02800000 | nesdev->cqp.qp_id); spin_unlock_irqrestore(&nesdev->cqp.lock, flags); nes_debug(NES_DBG_SHUTDOWN, "Waiting for CQP, cqp_head=%u, cqp.sq_head=%u," @@ -3064,7 +3070,8 @@ static void nes_cqp_ce_handler(struct nes_device *nesdev, struct nes_hw_cq *cq) cqp_request, le32_to_cpu(cqp_wqe->wqe_words[NES_CQP_WQE_OPCODE_IDX])&0x3f, head); /* Ring doorbell (1 WQEs) */ barrier(); - nes_write32(nesdev->regs+NES_WQE_ALLOC, 0x01800000 | nesdev->cqp.qp_id); + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, + 0x01800000 | nesdev->cqp.qp_id); } spin_unlock_irqrestore(&nesdev->cqp.lock, flags); diff --git a/drivers/infiniband/hw/nes/nes_mgt.c b/drivers/infiniband/hw/nes/nes_mgt.c index 21e0ebd..5c5073c 100644 --- a/drivers/infiniband/hw/nes/nes_mgt.c +++ b/drivers/infiniband/hw/nes/nes_mgt.c @@ -96,7 +96,8 @@ static void nes_replenish_mgt_rq(struct nes_vnic_mgt *mgtvnic) atomic_dec(&mgtvnic->rx_skbs_needed); barrier(); if (++rx_wqes_posted == 255) { - nes_write32(nesdev->regs + NES_WQE_ALLOC, (rx_wqes_posted << 24) | nesmgt->qp_id); + nes_write32_relaxed(nesdev->regs + NES_WQE_ALLOC, + (rx_wqes_posted << 24) | nesmgt->qp_id); rx_wqes_posted = 0; } } else { @@ -115,7 +116,8 @@ static void nes_replenish_mgt_rq(struct nes_vnic_mgt *mgtvnic) } while (atomic_read(&mgtvnic->rx_skbs_needed)); barrier(); if (rx_wqes_posted) - nes_write32(nesdev->regs + NES_WQE_ALLOC, (rx_wqes_posted << 24) | nesmgt->qp_id); + nes_write32_relaxed(nesdev->regs + NES_WQE_ALLOC, + (rx_wqes_posted << 24) | nesmgt->qp_id); nesmgt->replenishing_rq = 0; } @@ -995,7 +997,8 @@ int nes_init_mgt_qp(struct nes_device *nesdev, struct net_device *netdev, struct barrier(); /* Ring doorbell (2 WQEs) */ - nes_write32(nesdev->regs + NES_WQE_ALLOC, 0x02800000 | nesdev->cqp.qp_id); + nes_write32_relaxed(nesdev->regs + NES_WQE_ALLOC, + 0x02800000 | nesdev->cqp.qp_id); spin_unlock_irqrestore(&nesdev->cqp.lock, flags); nes_debug(NES_DBG_INIT, "Waiting for create MGT QP%u to complete.\n", @@ -1050,7 +1053,8 @@ int nes_init_mgt_qp(struct nes_device *nesdev, struct net_device *netdev, struct do { counter = min(wqe_count, ((u32)255)); wqe_count -= counter; - nes_write32(nesdev->regs + NES_WQE_ALLOC, (counter << 24) | mgtvnic->mgt.qp_id); + nes_write32_relaxed(nesdev->regs + NES_WQE_ALLOC, + (counter << 24) | mgtvnic->mgt.qp_id); } while (wqe_count); nes_write32(nesdev->regs + NES_CQE_ALLOC, NES_CQE_ALLOC_NOTIFY_NEXT | @@ -1124,7 +1128,8 @@ void nes_destroy_mgt(struct nes_vnic *nesvnic) barrier(); /* Ring doorbell (2 WQEs) */ - nes_write32(nesdev->regs + NES_WQE_ALLOC, 0x02800000 | nesdev->cqp.qp_id); + nes_write32_relaxed(nesdev->regs + NES_WQE_ALLOC, + 0x02800000 | nesdev->cqp.qp_id); spin_unlock_irqrestore(&nesdev->cqp.lock, flags); nes_debug(NES_DBG_SHUTDOWN, "Waiting for CQP, cqp_head=%u, cqp.sq_head=%u," diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c index 0a75164..0653da0 100644 --- a/drivers/infiniband/hw/nes/nes_nic.c +++ b/drivers/infiniband/hw/nes/nes_nic.c @@ -683,7 +683,7 @@ static int nes_netdev_start_xmit(struct sk_buff *skb, struct net_device *netdev) barrier(); if (wqe_count) - nes_write32(nesdev->regs+NES_WQE_ALLOC, + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, (wqe_count << 24) | (1 << 23) | nesvnic->nic.qp_id); netif_trans_update(netdev); diff --git a/drivers/infiniband/hw/nes/nes_utils.c b/drivers/infiniband/hw/nes/nes_utils.c index 21b4a83..79a3d98 100644 --- a/drivers/infiniband/hw/nes/nes_utils.c +++ b/drivers/infiniband/hw/nes/nes_utils.c @@ -661,7 +661,8 @@ void nes_post_cqp_request(struct nes_device *nesdev, barrier(); /* Ring doorbell (1 WQEs) */ - nes_write32(nesdev->regs+NES_WQE_ALLOC, 0x01800000 | nesdev->cqp.qp_id); + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, + 0x01800000 | nesdev->cqp.qp_id); barrier(); } else { diff --git a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c index 162475a..87f8635 100644 --- a/drivers/infiniband/hw/nes/nes_verbs.c +++ b/drivers/infiniband/hw/nes/nes_verbs.c @@ -3310,7 +3310,7 @@ static int nes_post_send(struct ib_qp *ibqp, struct ib_send_wr *ib_wr, while (wqe_count) { counter = min(wqe_count, ((u32)255)); wqe_count -= counter; - nes_write32(nesdev->regs + NES_WQE_ALLOC, + nes_write32_relaxed(nesdev->regs + NES_WQE_ALLOC, (counter << 24) | 0x00800000 | nesqp->hwqp.qp_id); } @@ -3404,7 +3404,8 @@ static int nes_post_recv(struct ib_qp *ibqp, struct ib_recv_wr *ib_wr, while (wqe_count) { counter = min(wqe_count, ((u32)255)); wqe_count -= counter; - nes_write32(nesdev->regs+NES_WQE_ALLOC, (counter<<24) | nesqp->hwqp.qp_id); + nes_write32_relaxed(nesdev->regs+NES_WQE_ALLOC, + (counter<<24) | nesqp->hwqp.qp_id); } spin_unlock_irqrestore(&nesqp->lock, flags);