From patchwork Tue Mar 20 11:45:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chintan Pandya X-Patchwork-Id: 10296931 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B6C2D602B3 for ; Tue, 20 Mar 2018 11:47:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A430B283AD for ; Tue, 20 Mar 2018 11:47:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 98B1129530; Tue, 20 Mar 2018 11:47:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2F8CA283AD for ; Tue, 20 Mar 2018 11:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=H94GKK6kfGRIcCUlpLU5vJgpQJTofjFb5q3wMNWf0R8=; b=G2jICP/e7xLb5tE3f1jEL4WHcg eIY6oamzY9Pq17woKUK8eWRV/uFMc1xhg8lKPb8AejN7lQVc78MqCR7GFFjnztN0+Sff7q4VWtOuO MgTDZ7YAcijXrgD3pI5ni6MB4PXZaYNgHkoK/gUhY4wfLK2vjC1gy17jo7NjxyA9qAK4hrWgpv7sv ijLXlsNNQ1qXUDeR6wms/+JKYCN4e9IP5rIR1B7FSOlF2pzr9MkByf+/vz69T6eeEo8lf1Q6TOrwq GLqkGslCBFbvKUBl0lufU5drJFxg62hV2cc9HP87sUTf2EdbOtFEAFXOfspGICQ5s2XEwGMwoqoxj YwTIWanA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyFjG-0000RS-F8; Tue, 20 Mar 2018 11:46:58 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyFie-0008Rw-27 for linux-arm-kernel@lists.infradead.org; Tue, 20 Mar 2018 11:46:26 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A3B2460F5F; Tue, 20 Mar 2018 11:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521546369; bh=jTsWA6ypQtCH+tCjf/DX4Td4ZFyQH+39cR4my9QAvtQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c8XztDlwFbpShn6FSaeXM25IS8QIauQPARX0hL4su1Fw3aWx0dojGDIeI4cFo+Ja2 EEV5fAlhs8eOM2Rm2Gosedm1LC61ZoRm6JJQcAshgSxS1kdPTtO4yEA1/2gm24RMDR z4tA2KWpuO4myfLuVg8oJhSmsfyaM/XNfFnflF3E= Received: from cpandya-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: cpandya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DE2BB60F5C; Tue, 20 Mar 2018 11:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521546368; bh=jTsWA6ypQtCH+tCjf/DX4Td4ZFyQH+39cR4my9QAvtQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=myGrS5RfMMgKUNt/r2RrT4rlLDhfNsEFsxaQUMtzzY2yav0rHLNmSm6ab/e5TP/BD iVVaw/miq7O1JxKspshKRKDDIazoEbPWFt1qe0O124Rossh8zM1lUpSDl+zlXG0zW9 w2t+thL2+wT5INiz1Wprq4DfFFbyMZtEVZR51a6s= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DE2BB60F5C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cpandya@codeaurora.org From: Chintan Pandya To: catalin.marinas@arm.com, will.deacon@arm.com, mark.rutland@arm.com Subject: [PATCH v4 2/3] arm64: Implement page table free interfaces Date: Tue, 20 Mar 2018 17:15:13 +0530 Message-Id: <1521546314-31753-3-git-send-email-cpandya@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1521546314-31753-1-git-send-email-cpandya@codeaurora.org> References: <1521546314-31753-1-git-send-email-cpandya@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180320_044621_041901_389FE8CE X-CRM114-Status: GOOD ( 13.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, toshi.kani@hpe.com, arnd@arndb.de, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kristina.martsenko@arm.com, takahiro.akashi@linaro.org, james.morse@arm.com, Chintan Pandya , tglx@linutronix.de, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Implement pud_free_pmd_page() and pmd_free_pte_page(). Implementation requires, 1) Freeing of the un-used next level page tables 2) Clearing off the current pud/pmd entry 3) Invalidate TLB which could have previously valid but not stale entry Signed-off-by: Chintan Pandya --- arch/arm64/mm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index da98828..7be3106 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -45,6 +45,7 @@ #include #include #include +#include #define NO_BLOCK_MAPPINGS BIT(0) #define NO_CONT_MAPPINGS BIT(1) @@ -973,12 +974,47 @@ int pmd_clear_huge(pmd_t *pmdp) return 1; } +static int __pmd_free_pte_page(pmd_t *pmd, unsigned long addr, bool tlb_inv) +{ + pmd_t *table; + + if (pmd_val(*pmd)) { + table = __va(pmd_val(*pmd)); + pmd_clear(pmd); + /* + * FIXME: __flush_tlb_pgtable(&init_mm, addr) is + * ideal candidate here, which exactly + * flushes intermediate pgtables. But, + * this is broken (evident from tests). + * So, use safe TLB op unless that is fixed. + */ + if (tlb_inv) + flush_tlb_kernel_range(addr, addr + PMD_SIZE); + + free_page((unsigned long) table); + } + return 1; +} + int pud_free_pmd_page(pud_t *pud, unsigned long addr) { - return pud_none(*pud); + pmd_t *table; + int i; + + if (pud_val(*pud)) { + table = __va(pud_val(*pud)); + for (i = 0; i < PTRS_PER_PMD; i++) + __pmd_free_pte_page(&table[i], addr + (i * PMD_SIZE), + false); + + pud_clear(pud); + flush_tlb_kernel_range(addr, addr + PUD_SIZE); + free_page((unsigned long) table); + } + return 1; } int pmd_free_pte_page(pmd_t *pmd, unsigned long addr) { - return pmd_none(*pmd); + return __pmd_free_pte_page(pmd, addr, true); }