From patchwork Tue Mar 20 16:56:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 10297505 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8257560385 for ; Tue, 20 Mar 2018 16:57:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E24228B38 for ; Tue, 20 Mar 2018 16:57:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 327B928BF6; Tue, 20 Mar 2018 16:57:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A563F28B38 for ; Tue, 20 Mar 2018 16:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Subject:Message-ID:References: In-Reply-To:From:To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C9tDLfGNMJvaES0YEXkfCvN2vKHamZusxg+ekOdDJFY=; b=iNKsE/a8Z7Dd1F UhQPBvgRZpXpO+mmkL1r4nX7QwM8IPMHVF3CjHj6gjqXEd2+2cfml56JsRn6eDyXHw13P77wwBXAC CsDI/Ygfy0q2ogp/jfqUtJKuGZO/N7mLkKmpqRcRFO6r6Bz5uYBGHgSLfBcv6fRGuVXuFlb9zNG/h lit0F4IyQ1Lx0ui6gkWFhsLAuZo7K96+/Sb1fi3v8xn1edFFuKH+6tE5rhL+4G21j8HWWA/H56lga uF5WjwLAq2V1DwWxHnR03UDGVJuoAv5JjJF3MpsqzHzbEuiJhrw+Nzxj5nb1/PKsl71PWPzehiiGY dp/5stCsR6qxAcPzVyBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyKZR-0001Ew-Af; Tue, 20 Mar 2018 16:57:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyKZN-00019A-TM for linux-arm-kernel@lists.infradead.org; Tue, 20 Mar 2018 16:57:07 +0000 Received: from localhost (unknown [104.132.1.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59C9921770; Tue, 20 Mar 2018 16:56:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59C9921770 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sboyd@kernel.org MIME-Version: 1.0 To: David Lechner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org From: Stephen Boyd In-Reply-To: <1521168778-27236-3-git-send-email-david@lechnology.com> References: <1521168778-27236-1-git-send-email-david@lechnology.com> <1521168778-27236-3-git-send-email-david@lechnology.com> Message-ID: <152156501473.183971.10164660837276962553@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v8 02/42] clk: davinci: New driver for davinci PLL clocks Date: Tue, 20 Mar 2018 09:56:54 -0700 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180320_095705_989566_4DDA7AF4 X-CRM114-Status: UNSURE ( 8.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Lechner , Kevin Hilman , Stephen Boyd , Michael Turquette , Sekhar Nori , linux-kernel@vger.kernel.org, Bartosz Golaszewski , Rob Herring , Adam Ford Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Quoting David Lechner (2018-03-15 19:52:18) > + > +static int davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry) > +{ > + struct davinci_pll_clk *pll = to_davinci_pll_clk(hw); > + struct debugfs_regset32 *regset; > + struct dentry *d; > + > + regset = kzalloc(sizeof(regset), GFP_KERNEL); Should be sizeof(*regset)? I squashed this in: diff --git a/drivers/clk/davinci/pll.c b/drivers/clk/davinci/pll.c index 588a48927436..89d30bf95102 100644 --- a/drivers/clk/davinci/pll.c +++ b/drivers/clk/davinci/pll.c @@ -882,7 +882,7 @@ static int davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry) struct debugfs_regset32 *regset; struct dentry *d; - regset = kzalloc(sizeof(regset), GFP_KERNEL); + regset = kzalloc(sizeof(*regset), GFP_KERNEL); if (!regset) return -ENOMEM;