From patchwork Wed Mar 21 18:56:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10300075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5F80B60386 for ; Wed, 21 Mar 2018 19:01:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4BA342990A for ; Wed, 21 Mar 2018 19:01:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 460C729906; Wed, 21 Mar 2018 19:01:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C2C1029906 for ; Wed, 21 Mar 2018 19:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HjAWbr0kVrfM4mWHEbD8YV2YJSl0bJ7xJX+xz6BR3zE=; b=rslt7SyQICd4Ki pbWCksPe4GTxI6DSVebZGyOfAzTyuIb709UX1ZiyM1S54fDm4E3iPT0ch7m3O5hn3iVDBxKs/dvTI kOEubg4zda2UzI99m2Em3rMSU/tay9oRX9O9HGQWowwR2d1MNlxILhXntHOs7W37XWs9LeG/f9PlG OCxIK/Rsgaf0yD/FGO9wZuLdRxaRX08ok/qJ3O7p8odcXBQ47aQObqvgYn4/d+149C1xI84/koBc8 vRDP+dSvoQcJRkLnQiIVqPnKcaDy9gKc45GBusRLfEtgfTlW/vk3D99EMPRjDVb1I3O22Mn9cvMVM IEpn5wtf0C1pofXLGpXg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyiym-0005G2-3w; Wed, 21 Mar 2018 19:00:56 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyiug-0002Sw-Le for linux-arm-kernel@lists.infradead.org; Wed, 21 Mar 2018 18:56:49 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 00A5560FA8; Wed, 21 Mar 2018 18:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521658590; bh=/dk6LFTwdGuq2DfBfF7yg7MAPz5m1QtQ1ahc8Y6Agf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jY/u/jjy6UuptU61au6epATd45GvFA4hVQZSbKj+6wy4/LE98MX+Q8heMQzTG6Gfz Og7iRqMcgSr4YSuDrw5wriZVOB3mpHY6KrbrpHEkAGQPu3mqR3kKUr6433rfH/MwMN F2COxraC9kXgeT49v7SXJx21roilext54rI8YZNc= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1E81360C55; Wed, 21 Mar 2018 18:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521658587; bh=/dk6LFTwdGuq2DfBfF7yg7MAPz5m1QtQ1ahc8Y6Agf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bxuDbobNqpgPAtje1kKJQz6dBdsouUQhSnV1mrjd5/koSKPfjRaZzPB132yVVtRQN 5OQIJdsTsFOW02eJ2KTEYubz1xyGmtlsuRX7Ox7OnxZkw9G91gDCln9ZYKO1kO4fKC IerNJs0dTLA8//hzvrNYN6LkNOiUT0mLFRMEQFoc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1E81360C55 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: jeffrey.t.kirsher@intel.com Subject: [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb() Date: Wed, 21 Mar 2018 14:56:09 -0400 Message-Id: <1521658572-26354-6-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521658572-26354-1-git-send-email-okaya@codeaurora.org> References: <1521658572-26354-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180321_115643_424828_6B702C90 X-CRM114-Status: GOOD ( 11.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sulrich@codeaurora.org, netdev@vger.kernel.org, timur@codeaurora.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Remove ixgbevf_write_tail() in favor of moving writel() close to wmb(). Signed-off-by: Sinan Kaya Reviewed-by: Alexander Duyck --- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 ----- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h index f695242..11e893e 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h @@ -244,11 +244,6 @@ static inline u16 ixgbevf_desc_unused(struct ixgbevf_ring *ring) return ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1; } -static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 value) -{ - writel(value, ring->tail); -} - #define IXGBEVF_RX_DESC(R, i) \ (&(((union ixgbe_adv_rx_desc *)((R)->desc))[i])) #define IXGBEVF_TX_DESC(R, i) \ diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c index 9b3d43d..6bf778a 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c @@ -659,7 +659,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring, * such as IA-64). */ wmb(); - ixgbevf_write_tail(rx_ring, i); + writel(i, rx_ring->tail); } } @@ -3644,7 +3644,7 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring, tx_ring->next_to_use = i; /* notify HW of packet */ - ixgbevf_write_tail(tx_ring, i); + writel(i, tx_ring->tail); return; dma_error: