From patchwork Wed Mar 21 18:56:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10300071 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 45ECE600F6 for ; Wed, 21 Mar 2018 19:00:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 329EF298A5 for ; Wed, 21 Mar 2018 19:00:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 25C2F298B1; Wed, 21 Mar 2018 19:00:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AC63F298A5 for ; Wed, 21 Mar 2018 18:59:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0UK+rSJkW9KJh+76ucLM6yk8Iad+EoPzZpx4OPmGZ3g=; b=GtUX0c/xSuIF4Z nvLrWOUA5oCbfXB/IpabIwSRoBB5i4t3hyr/GpL+Bs/iObRqcDZgW0tw9PuRDAx1CWe6nuk3KQCEj GClGgVBRtkDCfmVagYr/N4xFBZMRndYwuhK4thZeuvQJry4JUcvX3B28mzKdGeo84CrQOumKJyCY1 XnAChlmewaRhlPOZAz14ZSPn5sY/HokeeVFLxTxK9VXzhVy5s5l8EdzmIA6+KLgrOrXhqcA07ARmI WfwiMO1EUFJGt3lr73clJ6lkH7Hmpe4rE9ZaTP7mZXxlK1Y1VkBvo8Fu3CnGt33K3ne26tQH0Agkh 7FbXlDORof5JR78W683g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyixn-000491-54; Wed, 21 Mar 2018 18:59:55 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyiug-0002Sx-Lg for linux-arm-kernel@lists.infradead.org; Wed, 21 Mar 2018 18:56:49 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C565660FED; Wed, 21 Mar 2018 18:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521658590; bh=CtgZnF+hKcsS6wiogdlq2V9WwzHipk7ZA8n6embbddU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AuwLlLGbvSQn98JUQsNRV3yShCfmHuyZ5RSRtstM+LhuvUKJWsfIzi4ZEGxBQSaFf iPoymJpkl3hlnL13sF+EKLVIsk8hMgAMY/MHMmpzOC9ms1ALrBMGpWWJ+lmEU+ZUhv jsXGBhI6OKbnHfEk1PTBxim/OIc3xgRzFDAVil9Y= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B8A9860FA8; Wed, 21 Mar 2018 18:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521658588; bh=CtgZnF+hKcsS6wiogdlq2V9WwzHipk7ZA8n6embbddU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zx4vQpEuPgnA3/PjhGQ0VWqwR1nRRXfmB2j8zMkrnpDXvZwfuE5QoG2Mlt7aSKGqS gA2wCB2n7JcGzKkZTcYgKA9vQGCOzWg300wvZfEUX45WAK7KGWikc8U2Tjx5FFF3zE Hn002gnRQsbVco7Xy1ksEXiXTmXPyjYL70PEHdKE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B8A9860FA8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: jeffrey.t.kirsher@intel.com Subject: [PATCH REPOST v4 6/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Date: Wed, 21 Mar 2018 14:56:10 -0400 Message-Id: <1521658572-26354-7-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521658572-26354-1-git-send-email-okaya@codeaurora.org> References: <1521658572-26354-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180321_115643_430143_0FD88080 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sulrich@codeaurora.org, netdev@vger.kernel.org, timur@codeaurora.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya Reviewed-by: Alexander Duyck --- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c index 6bf778a..774b2a6 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c @@ -659,7 +659,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring, * such as IA-64). */ wmb(); - writel(i, rx_ring->tail); + writel_relaxed(i, rx_ring->tail); } } @@ -3644,7 +3644,7 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring, tx_ring->next_to_use = i; /* notify HW of packet */ - writel(i, tx_ring->tail); + writel_relaxed(i, tx_ring->tail); return; dma_error: