From patchwork Thu Mar 22 17:09:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10301969 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C9D8F60216 for ; Thu, 22 Mar 2018 17:13:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB5A9286FE for ; Thu, 22 Mar 2018 17:13:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B00E328756; Thu, 22 Mar 2018 17:13:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DF10A28866 for ; Thu, 22 Mar 2018 17:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m82k+W9ULsKQeYE9zBitovnTU1ORl91rTpgGeLcQwbo=; b=eJcGrdYTyk/YP+ 58YjFf+cQ5KpPI2xNJ2E27mFWwE2mHQuHKjJSjeNSOBootmGE8mx2IFBbuRPnz6QoisGKatvzwULO /koQPTmqWVMmKfTNY+jpEqih35jF+4YYyxkkZSNQxlKY+JM/uCW+0gouCKfFUUFSH52D+kQYnrDnI QVC9pOgO959WHqhCz+MFgaagQRGHfJcJbAFzd1fNuMm6sLgSEglYvbq9j2biw7y485Ffy+60yZMRW 0rt42mf9La4GFsoIIQPLyihvD+MJCZve+8C0CwFqhg6IB3ue8/rP25t16aahcOFiqnUhKG3TqZ0ao FZTgeBB4yL6aVwRHuVRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ez3m5-00010Y-0e; Thu, 22 Mar 2018 17:13:13 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ez3jH-0007DA-Cm for linux-arm-kernel@lists.infradead.org; Thu, 22 Mar 2018 17:10:24 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8DC2E60F6D; Thu, 22 Mar 2018 17:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521738610; bh=oObpkAZ73dpLqz8AM6IpVa3khw+wzqn9pSSwznSxXmY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a//neG1S+bK2IxL9mbH6ODysrG3MjnsZKLxUyUooxWIFLTVT9HAwMWBoqsEshW/Sb 8E1G++RyyiDJrQvavjb2TCrIDRD72Z6yH01qpN/Kgvvkn4kRSEiFNolbx7tad+/DUI ccPyEl+uzi854bunOQiBzgtQhp8zJRRXI7j5rkws= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 14EE3603AF; Thu, 22 Mar 2018 17:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521738609; bh=oObpkAZ73dpLqz8AM6IpVa3khw+wzqn9pSSwznSxXmY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d3eDEecvWDn1G99B9UOxDpGNnJSM56CqC39iUq78+DJb5nyzadFkTDdEiBQcIrGFU NZAfcg9pwP3SlsZfMCH5uFLjPL6P14HhlIlpIKaRzuFeDcO5dStNu+o4GMDz8ubBIX fDcKUpA2opUrjzHl/S9MOwUEoPVvabrJtyx5AyCk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 14EE3603AF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v5 1/5] net: qla3xxx: Eliminate duplicate barriers on weakly-ordered archs Date: Thu, 22 Mar 2018 13:09:58 -0400 Message-Id: <1521738603-23596-2-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521738603-23596-1-git-send-email-okaya@codeaurora.org> References: <1521738603-23596-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180322_101019_601920_73429F98 X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sinan Kaya , linux-arm-msm@vger.kernel.org, Dept-GELinuxNICDev@cavium.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/net/ethernet/qlogic/qla3xxx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c index 9e5264d..0e71b74 100644 --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -1858,8 +1858,8 @@ static void ql_update_small_bufq_prod_index(struct ql3_adapter *qdev) qdev->small_buf_release_cnt -= 8; } wmb(); - writel(qdev->small_buf_q_producer_index, - &port_regs->CommonRegs.rxSmallQProducerIndex); + writel_relaxed(qdev->small_buf_q_producer_index, + &port_regs->CommonRegs.rxSmallQProducerIndex); } }