From patchwork Fri Mar 23 18:52:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10305357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E2E24605F7 for ; Fri, 23 Mar 2018 18:53:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D28DC28B4F for ; Fri, 23 Mar 2018 18:53:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C72EE2910F; Fri, 23 Mar 2018 18:53:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 57AC12910E for ; Fri, 23 Mar 2018 18:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d9scmugAzzIF3sA/2BOkh3319sA2UpG2hElExdKCHSw=; b=q97WrqfO17K8Ik yWiHyrPkeDCSa7UlLf6NUMoiKjuAes1lvVE22PSsW8OUGF4Krmi4y5PxWbFrr5P5pa5PTlTTRDuoE tqcvbV3OdABjkmZfrHoXgsx+Fduj4074xm5ZNeoFrYv32Eu3uhxYuFkyBBLZ0MRPaIAVaRsfn3huh Zr/+5px3UMpUKRHjU6U/p5VpsbAHxbvDoWWgs/KFQ8mlWDmnLFKUccTViQUpo08M990F2ky9oUhzU m6brUnn+tN5xuYE/Sxi4pggSHX2aQmZcPhRoHwYUqwf0wMacVPVlo//xFG4sIpkbd5behBHGTjfYU AhwUS4TxcZ/l/NXSZRBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezRoW-0005nF-7n; Fri, 23 Mar 2018 18:53:20 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezRoR-0005kL-1e for linux-arm-kernel@lists.infradead.org; Fri, 23 Mar 2018 18:53:16 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DE6BC60F5C; Fri, 23 Mar 2018 18:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521831187; bh=kzU370DBYXzzwy/yY6S9SSuttXZgy6s8zEIJUcvya2c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YrRrBiRVkKg7jXsMf/7yT6dlOmXxe4N9U4MXRX8l+JaB8qp3bYZ4RZWD7RGOESR4t Df6fl3/tpBqnQcHFXWthaLEB6meFi4PF3s8X3jewG5OQq1E+sX2zu0WMNEy8vZaS7x By3aVdLEAdJLa6Un4g4waqHCorHfzBTRRlDh6vZM= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A5A5760C66; Fri, 23 Mar 2018 18:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521831187; bh=kzU370DBYXzzwy/yY6S9SSuttXZgy6s8zEIJUcvya2c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YrRrBiRVkKg7jXsMf/7yT6dlOmXxe4N9U4MXRX8l+JaB8qp3bYZ4RZWD7RGOESR4t Df6fl3/tpBqnQcHFXWthaLEB6meFi4PF3s8X3jewG5OQq1E+sX2zu0WMNEy8vZaS7x By3aVdLEAdJLa6Un4g4waqHCorHfzBTRRlDh6vZM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A5A5760C66 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: jeffrey.t.kirsher@intel.com Subject: [PATCH v7 2/7] ixgbe: eliminate duplicate barriers on weakly-ordered archs Date: Fri, 23 Mar 2018 14:52:55 -0400 Message-Id: <1521831180-25014-3-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521831180-25014-1-git-send-email-okaya@codeaurora.org> References: <1521831180-25014-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180323_115315_206907_F33CAEA3 X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sulrich@codeaurora.org, netdev@vger.kernel.org, timur@codeaurora.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index e3b32ea..fb80edb 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -1701,7 +1701,7 @@ void ixgbe_alloc_rx_buffers(struct ixgbe_ring *rx_ring, u16 cleaned_count) * such as IA-64). */ wmb(); - writel(i, rx_ring->tail); + writel_relaxed(i, rx_ring->tail); } } @@ -2470,7 +2470,7 @@ static int ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector, * know there are new descriptors to fetch. */ wmb(); - writel(ring->next_to_use, ring->tail); + writel_relaxed(ring->next_to_use, ring->tail); xdp_do_flush_map(); } @@ -8101,7 +8101,7 @@ static int ixgbe_tx_map(struct ixgbe_ring *tx_ring, ixgbe_maybe_stop_tx(tx_ring, DESC_NEEDED); if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) { - writel(i, tx_ring->tail); + writel_relaxed(i, tx_ring->tail); /* we need this if more than one processor can write to our tail * at a time, it synchronizes IO on IA64/Altix systems @@ -10038,7 +10038,7 @@ static void ixgbe_xdp_flush(struct net_device *dev) * are new descriptors to fetch. */ wmb(); - writel(ring->next_to_use, ring->tail); + writel_relaxed(ring->next_to_use, ring->tail); return; }