From patchwork Fri Mar 23 18:52:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10305397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 29279600F6 for ; Fri, 23 Mar 2018 18:56:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19BC929113 for ; Fri, 23 Mar 2018 18:56:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0E50829115; Fri, 23 Mar 2018 18:56:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AB9D729113 for ; Fri, 23 Mar 2018 18:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4jrAO2EKzPo+ujHfhFBLpakeuBzUWK6aFB9weIbapn8=; b=E0mI0FVqex8OqR g4qTWZutI1NVsn6HZ8znPYe0pXbjgpmD5XRSN750S3anrJ2MCRXqWGKcBr1jgDk7OhBf0Jp/PQXIT 70ji7LGp0TQuHw39ciP7Dp4W8iuTYO+u8F5BZxSDau3EWvqsRX0l+N9FX4InR4FgCIbP5upjZyvtM QE7O//I5hmxiI+awquvySRS23+ehL8dpgbSK9/N5slHMdxYQNj6uGRS3zHABMrQ3sfMABxhp22OHf h/wZ2y4v/LNgoBxiX4OdKVB0qMVJfX1Ff9WdhKqq/1Biw4t3YdegtE1uq3Om9WfRaTIb7AGh6DPnd sGsF1nCXkeuwnIsK5v0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezRrT-0008Bc-8M; Fri, 23 Mar 2018 18:56:23 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezRoR-0005kg-1o for linux-arm-kernel@lists.infradead.org; Fri, 23 Mar 2018 18:53:18 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 09C7D60F78; Fri, 23 Mar 2018 18:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521831191; bh=3zYbM586Ke6rAuU5ECwTz1tgwB5amohMFPbJB1XaoIo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ezSwHjpkXmAtEUuLblCunT48EJsvzuKHW/UYXDJZJbP/UO9mzQ0iIxsedVltl808p PSdyr+S2bGlEGi8c7PpA4TgJfBs+YSxqfzOSOpKLoEYdMeKcjA67UL7cDO6jQGpWHL CNja+syfegqhk+rx93fwx/g6oAHA//agN7X8BmTo= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 73A4860F78; Fri, 23 Mar 2018 18:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521831190; bh=3zYbM586Ke6rAuU5ECwTz1tgwB5amohMFPbJB1XaoIo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ss69pD7nVw2ZvDXSB3t3ylELL3BOoOmS/OqfhYQMJ4xmOqe1Y/Wv7qin3zNrBAMR5 mrsbtV/8jj79t/cffK/kYLH2m5HRGoarF/LldHmQ780UKcIZHastUqLzopCLaTrL+4 IEyqnueDJ4NSbmMdTLnKzl080UOTBDhUxfmI/zhA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 73A4860F78 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: jeffrey.t.kirsher@intel.com Subject: [PATCH v7 4/7] igb: eliminate duplicate barriers on weakly-ordered archs Date: Fri, 23 Mar 2018 14:52:57 -0400 Message-Id: <1521831180-25014-5-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521831180-25014-1-git-send-email-okaya@codeaurora.org> References: <1521831180-25014-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180323_115315_290764_9941C0DC X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sulrich@codeaurora.org, netdev@vger.kernel.org, timur@codeaurora.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 3d4ff3c..c501378 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -5674,7 +5674,7 @@ static int igb_tx_map(struct igb_ring *tx_ring, igb_maybe_stop_tx(tx_ring, DESC_NEEDED); if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) { - writel(i, tx_ring->tail); + writel_relaxed(i, tx_ring->tail); /* we need this if more than one processor can write to our tail * at a time, it synchronizes IO on IA64/Altix systems @@ -8079,7 +8079,7 @@ void igb_alloc_rx_buffers(struct igb_ring *rx_ring, u16 cleaned_count) * such as IA-64). */ wmb(); - writel(i, rx_ring->tail); + writel_relaxed(i, rx_ring->tail); } }