From patchwork Fri Mar 23 22:23:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10305675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F0DC860349 for ; Fri, 23 Mar 2018 22:23:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D115E29178 for ; Fri, 23 Mar 2018 22:23:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C5799291C9; Fri, 23 Mar 2018 22:23:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 443B729178 for ; Fri, 23 Mar 2018 22:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EtZ8Xar/NNlmG9+GWfR2XWBMaV0J5+xvK4i+/1I2Rek=; b=KYl2RO5bnUekXg OY/suGJyS9fa0Ate+38riev0Czd9WWl/A/2rVObu40YJswjVqg7NSWVNFZEYWYaA8r48Y3X+rrbPF eFGm3HgjLCFNL9nc5CXwIe2upQypJ55OxW+a/4VCFo2xPQeQAzlfpQZuo/3QobR84YzQwc+KRGhUM 76u31EKlzf2YCufz90X344c36ANI17kK/b7v1xzW2RwlLBZ09xZBIobR+e1rfzcTkTfaFCY65/zf4 ZXFCKXte+JQG4Xe+pWSIHLql0ypfeNVxo78COkOqj5Fxpa7pA9ym0jXs3TDDweggHjjvqevbUB2QF 0MpKRyIAyAvrMeos4DOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezV5u-0005Ob-OT; Fri, 23 Mar 2018 22:23:30 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezV5r-0005Mc-4Q for linux-arm-kernel@lists.infradead.org; Fri, 23 Mar 2018 22:23:28 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B5F8960F6E; Fri, 23 Mar 2018 22:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521843799; bh=UFFOJEvdJGTDlskSZ9RxFXJXMm/Hcw+E4NHzfNse+5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OCVpY0naVEP9PWZUgrF90cgtlZgZlw1aee180d/q5hlFJqZua2oHvooCq7DMkbvSv pM9cDUIrLwwL+0sGP8ur5joU+aTc/UpJjP9uqKnoZ6n8WEOPSu8J3/sKvTYj6SPe89 kn9Sv4zeu8xEtBeg/e1dRaMJVQEow8C0xWgrL8tg= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 15BA960312; Fri, 23 Mar 2018 22:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521843799; bh=UFFOJEvdJGTDlskSZ9RxFXJXMm/Hcw+E4NHzfNse+5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OCVpY0naVEP9PWZUgrF90cgtlZgZlw1aee180d/q5hlFJqZua2oHvooCq7DMkbvSv pM9cDUIrLwwL+0sGP8ur5joU+aTc/UpJjP9uqKnoZ6n8WEOPSu8J3/sKvTYj6SPe89 kn9Sv4zeu8xEtBeg/e1dRaMJVQEow8C0xWgrL8tg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 15BA960312 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v6 2/6] qlcnic: Eliminate duplicate barriers on weakly-ordered archs Date: Fri, 23 Mar 2018 18:23:07 -0400 Message-Id: <1521843791-21201-3-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521843791-21201-1-git-send-email-okaya@codeaurora.org> References: <1521843791-21201-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180323_152327_281082_A82B33B0 X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dept-GELinuxNICDev@cavium.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , Harish Patil , linux-arm-kernel@lists.infradead.org, Manish Chopra Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya Acked-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 46b0372..97c146e7 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter) wmb(); /* clear the interrupt trigger control register */ - writel(0, adapter->isr_int_vec); + writel_relaxed(0, adapter->isr_int_vec); intr_val = readl(adapter->isr_int_vec); do { intr_val = readl(adapter->tgt_status_reg);