From patchwork Sun Mar 25 14:39:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10307003 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 70E8860212 for ; Sun, 25 Mar 2018 23:20:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 63CF428DA9 for ; Sun, 25 Mar 2018 23:20:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5440829142; Sun, 25 Mar 2018 23:20:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E5BFA28DA9 for ; Sun, 25 Mar 2018 23:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z+4JDy4ejkpWJ3vy8Rq5uAFEshdxGGI4KsVPzY9U2Y8=; b=Fo9pE+dbiqhP/b +FBUTC+PdpZs7cXHE/0AonIQi8B9RMejc4OVX8x+j2c6ZjVxv56Q8eXYe4wS1DWDLFPGN9AOOTA1/ Cvj96A+OGOChT2lkTHY8FzgjDHfXP3qNKnkccn7rGzBjgF7ZnghYQG/VetZzwDW19HiisK0vC5LxT b5PBtSUO7cRxnJ3di25pYk+jKbjMdb2BOgwDO8qNAsy21IW95qwchJ6al+T01Picto83eVCYhFslj 2Ivei/NnbwdHjS7cjSdeXSuVY6W6oX4JmbXDnkq/0Wag/IWLWnIiSSHQVZxjK/aidzDH+4JzAqiJu gieY4H9S2OM5E2DxXfLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f0Evb-0007fq-6h; Sun, 25 Mar 2018 23:19:55 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f0EmZ-0006ba-9D for linux-arm-kernel@bombadil.infradead.org; Sun, 25 Mar 2018 23:10:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=n4qKvZ22dToghse+bgJC3bYVWnCHIanjGuDGBxpJugw=; b=jBO75pVBsP33FYIa/GQdVnBKMd A1Nz8mtp07YBmULJ0j2UuahwVq7JZ8R8rwtNV9dWUeJw5JWxsgm17GOHV6ZsxotFSkvk+PgQg/6G4 oEja9GoyPwyjNnMwg5cakupdla7UBPB7ft+zW3YkzZBN/AyNIlrQQ8rVWYoqGHv11sOrsNsx8yWbp YKxj5T0GNvidzfhVIs+dgp7fnw3CfHq4xgT2SZQ7TpUuxwbfKfwLi8pQi91XGvHRCbGSXPP+D7tYC 6+6nVXcT0JKgVA3hov08THZ19ZvJBnd3Y7dbabdhJaAvfYp55vNnLCoivh9oKcIdJbeIA9lY6cVuN 1+O1+LLA==; Received: from smtp.codeaurora.org ([198.145.29.96]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f06oi-00037u-De for linux-arm-kernel@lists.infradead.org; Sun, 25 Mar 2018 14:40:17 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AD528607EB; Sun, 25 Mar 2018 14:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521988767; bh=v+h4GXmyu/tKzKBRDO+IdYEuRqQDlxUYkWkFq23fhC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YEtlvRd4i3lVTUpyYWzHFimagiK4yZyUxFMnfpR/+f+t9ZfiS00D7CYwJ05KTRD5K Rph9IsrWTqZcAvBRGzM9aPU60h7GwrNFkOY4j/oOYxpSjeoLz25l4ErtFqTR8symE4 AdRX9lamzBjgDCHhqauxtbjgYD8qTJ+j1oVHJyhI= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9942660390; Sun, 25 Mar 2018 14:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521988767; bh=v+h4GXmyu/tKzKBRDO+IdYEuRqQDlxUYkWkFq23fhC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YEtlvRd4i3lVTUpyYWzHFimagiK4yZyUxFMnfpR/+f+t9ZfiS00D7CYwJ05KTRD5K Rph9IsrWTqZcAvBRGzM9aPU60h7GwrNFkOY4j/oOYxpSjeoLz25l4ErtFqTR8symE4 AdRX9lamzBjgDCHhqauxtbjgYD8qTJ+j1oVHJyhI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9942660390 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v7 1/7] net: qla3xxx: Eliminate duplicate barriers on weakly-ordered archs Date: Sun, 25 Mar 2018 10:39:15 -0400 Message-Id: <1521988761-30344-2-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521988761-30344-1-git-send-email-okaya@codeaurora.org> References: <1521988761-30344-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180325_104016_526063_B330638F X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sinan Kaya , linux-arm-msm@vger.kernel.org, Dept-GELinuxNICDev@cavium.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing code to wmb() writel_relaxed() mmiowb() for multi-arch support. Signed-off-by: Sinan Kaya --- drivers/net/ethernet/qlogic/qla3xxx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c index 9e5264d..b48f761 100644 --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -1858,8 +1858,9 @@ static void ql_update_small_bufq_prod_index(struct ql3_adapter *qdev) qdev->small_buf_release_cnt -= 8; } wmb(); - writel(qdev->small_buf_q_producer_index, - &port_regs->CommonRegs.rxSmallQProducerIndex); + writel_relaxed(qdev->small_buf_q_producer_index, + &port_regs->CommonRegs.rxSmallQProducerIndex); + mmiowb(); } }