From patchwork Sun Mar 25 14:39:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10306883 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0253B600CC for ; Sun, 25 Mar 2018 22:22:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBCD72923A for ; Sun, 25 Mar 2018 22:22:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D060D2934E; Sun, 25 Mar 2018 22:22:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2CEC82923A for ; Sun, 25 Mar 2018 22:22:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EtZ8Xar/NNlmG9+GWfR2XWBMaV0J5+xvK4i+/1I2Rek=; b=iUA4TtizdEq9cn eldCL2rgipM7yHL+b0V3Gk8FQtTLUNk8X0WxzmUR/JlDrs3f72Rb2WO2VeGfyzIoe2jAP1frxYrGh 19SjwRG0zeoOcw9bz3UjO7vAi1wktPQ/xxId7VWeGzVRLUKdsYMgTM7L0V7Fc+k5HPefi8fG7Eyhc 4tSF6N/fHyqpiqU7CFo+M8C2c3NFOAdcwnh7NOouU47CjKLm2BLqBxPBpQ94SDSj/VVXbhFfL2kHZ OUVwpgwd9JqcPqiFhuiv8xG0ztTuOWW8wOAq9tg5JagyBnI9yDmI1Rmxn9y2YdmddeNaKfY8I+lzA 5NQdS1TbNSaMH/KhRQKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f0E1v-00065L-KD; Sun, 25 Mar 2018 22:22:23 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f0DqI-0000cX-6g for linux-arm-kernel@bombadil.infradead.org; Sun, 25 Mar 2018 22:10:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bXyrNFaRakh4IFZEHcElhd3H6m5vIvdYOzcdw6BLPGw=; b=Sgyrqe+zNF5ivAKhNoCjR+/FfN t913bQXPeZHIxYgVFIC49PBh3XiN9VmYgQWEq3kcvQNMRI056cTaXjQpWxv5mZ1ENhlgAYKwVM9+4 9dYl34tOoWtdOWaBbDiId1ZzajRDmQnuEbvUX2ci/CEz4gdQ8cNCZ7tGhqPHyRnCH795Qe2cxN+av na8OhdP2QQg75/9D4ySCmF3Klu8eDuPuWepJiV8HDQ7yNb6TOm0UYVh1m0eZT0s316soyy4oUEwQN bEuvlQEAArUXoB1LDRFNLD1Pwgn88uMFUeNJstSbPSs4BbyBF58BOO7oQINJbpioI47M/+b2wW9NO t8yusOEw==; Received: from smtp.codeaurora.org ([198.145.29.96]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f06oa-0000iI-Hg for linux-arm-kernel@lists.infradead.org; Sun, 25 Mar 2018 14:40:10 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 40EB06085F; Sun, 25 Mar 2018 14:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521988769; bh=UFFOJEvdJGTDlskSZ9RxFXJXMm/Hcw+E4NHzfNse+5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SWlzbhVZl55T/1rzNjJT0qFA8f5FAhUPJPt8bTxX/YYQA8VWSUsFzgE36ec6DQlI9 cz/tupq8FYwITeSzwbrwCVXKsJwAXJM1SQzykeWR7w5tqBgFATc4Sg6dgWzi98sBwu /x1dm6+INKkaCYK2DCSTNY8Vn983jkgKpGUUDBow= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E98C16030F; Sun, 25 Mar 2018 14:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521988768; bh=UFFOJEvdJGTDlskSZ9RxFXJXMm/Hcw+E4NHzfNse+5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W8lumr2by+FziaFb/xuqW+c4d+6POi0UFBHsGSVknhAdRCDTmU/p6eJxad9vjKUUh R5JZdEWGCy7Bn2Mh1WFssliqLVpz+R8lYcSp6SXhKCJAjIGrD3PJtI0wQDl0dg+Bwv XrF3kND5GuTBk+o1PyuGNO5dqSbVFS/XSfIBIKP8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E98C16030F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v7 2/7] qlcnic: Eliminate duplicate barriers on weakly-ordered archs Date: Sun, 25 Mar 2018 10:39:16 -0400 Message-Id: <1521988761-30344-3-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521988761-30344-1-git-send-email-okaya@codeaurora.org> References: <1521988761-30344-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180325_154008_723192_63E787EA X-CRM114-Status: GOOD ( 12.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dept-GELinuxNICDev@cavium.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , Harish Patil , linux-arm-kernel@lists.infradead.org, Manish Chopra Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya Acked-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 46b0372..97c146e7 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter) wmb(); /* clear the interrupt trigger control register */ - writel(0, adapter->isr_int_vec); + writel_relaxed(0, adapter->isr_int_vec); intr_val = readl(adapter->isr_int_vec); do { intr_val = readl(adapter->tgt_status_reg);