From patchwork Mon Apr 2 19:06:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10320237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 799C960116 for ; Mon, 2 Apr 2018 19:08:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 694E32239C for ; Mon, 2 Apr 2018 19:08:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5E35828753; Mon, 2 Apr 2018 19:08:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8AEC82239C for ; Mon, 2 Apr 2018 19:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MRdBxgZCgtVNJQdnBoJH3PSLqYPhcZfreV25t4o9IKY=; b=NQBAB6291VVBIm Aka4AMcfwHgqwBlQei+qy1ljIDJDreiPuTOjChGH6wyD2vwGA+6av+4tbDwnE9aFwxgdvSW78m3Ep Jor1fG2eN+pdawfh+hezCRaSn6RBma2wg8I94KmWwjhuSKvBPdb44EA/NjO5TDCVT3Q38KR20wTb8 4LC+jfPOhGF3BTDaNqqeBRcCAd6Q7NIijqMexxS305ZB9LObN24Kd5sFnUMSElbNVR8LDn6adtNcA nPFyg/kWX84pL9ItVvVu1C6yIo3xaHISgYa5jeljPqNTk8HHKFDy8NtyFE2I4qkonn3nkvLGBGlJc elZmhcZTsd2JYwJnztZg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f34oE-0003Sj-K1; Mon, 02 Apr 2018 19:08:02 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f34n1-0002jM-0r for linux-arm-kernel@lists.infradead.org; Mon, 02 Apr 2018 19:06:50 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3FDD560F6E; Mon, 2 Apr 2018 19:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522696001; bh=Cy8/4TyQ1VUmAg+Q6qTAguoMnhcWm7Jc0TpasDD11WA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VAHQiJFNvpEQelqNcljyhg0H7mArZZhGio0ThMymgoJYpc0RlSrjRdbyVuIRpCimy Lw1FXEgyYHkVfssLq9M1cXfIMcd2MvVDdpkgM8uKtlyGbwoiFMFskQeLSVVzHAQ+/J 4OLUCFISbXgC/+WOldX9OW+x0QX5P11fLGO6rZ8c= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E4F0F60F6C; Mon, 2 Apr 2018 19:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522696000; bh=Cy8/4TyQ1VUmAg+Q6qTAguoMnhcWm7Jc0TpasDD11WA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MKUXYhjqGuJj7FvnBH0nyaj6wbdeLIDNuhkT4yaZTuNDWw6z1G/hboUa598f9dXUX 372Few8VK1SYu9VNN/5Iy7eYl1pqpwksYxuoenU2Kbub/4WU8AitH2tbLIWq2bgaGr +v6Zf4UdgOeIdQ8/L8P82hUuq3MZNM5wtYjIqpvc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E4F0F60F6C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: jeffrey.t.kirsher@intel.com Subject: [PATCH v8 3/7] igbvf: eliminate duplicate barriers on weakly-ordered archs Date: Mon, 2 Apr 2018 15:06:26 -0400 Message-Id: <1522695990-31082-4-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522695990-31082-1-git-send-email-okaya@codeaurora.org> References: <1522695990-31082-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180402_120647_152400_10D5C705 X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sulrich@codeaurora.org, netdev@vger.kernel.org, timur@codeaurora.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP memory-barriers.txt has been updated as follows: "When using writel(), a prior wmb() is not needed to guarantee that the cache coherent memory writes have completed before writing to the MMIO region." Remove old IA-64 comments in the code along with unneeded wmb() in front of writel(). There are places in the code where wmb() has been used as a double barrier for CPU and IO in place of smp_wmb() and wmb() as an optimization. For such places, keep the wmb() but replace the following writel() with writel_relaxed() to have a sequence as wmb() writel_relaxed() mmio_wb() Signed-off-by: Sinan Kaya --- drivers/net/ethernet/intel/igbvf/netdev.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c index e2b7502..d9f186a 100644 --- a/drivers/net/ethernet/intel/igbvf/netdev.c +++ b/drivers/net/ethernet/intel/igbvf/netdev.c @@ -246,12 +246,6 @@ static void igbvf_alloc_rx_buffers(struct igbvf_ring *rx_ring, else i--; - /* Force memory writes to complete before letting h/w - * know there are new descriptors to fetch. (Only - * applicable for weak-ordered memory model archs, - * such as IA-64). - */ - wmb(); writel(i, adapter->hw.hw_addr + rx_ring->tail); } } @@ -2289,16 +2283,16 @@ static inline void igbvf_tx_queue_adv(struct igbvf_adapter *adapter, } tx_desc->read.cmd_type_len |= cpu_to_le32(adapter->txd_cmd); - /* Force memory writes to complete before letting h/w - * know there are new descriptors to fetch. (Only - * applicable for weak-ordered memory model archs, - * such as IA-64). + + /* We use this memory barrier to make certain all of the + * status bits have been updated before next_to_watch is + * written. */ wmb(); tx_ring->buffer_info[first].next_to_watch = tx_desc; tx_ring->next_to_use = i; - writel(i, adapter->hw.hw_addr + tx_ring->tail); + writel_relaxed(i, adapter->hw.hw_addr + tx_ring->tail); /* we need this if more than one processor can write to our tail * at a time, it synchronizes IO on IA64/Altix systems */