From patchwork Tue May 8 14:16:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Zabel X-Patchwork-Id: 10386239 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 377B560353 for ; Tue, 8 May 2018 14:17:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25B542855C for ; Tue, 8 May 2018 14:17:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1A0E527852; Tue, 8 May 2018 14:17:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A0E0A27852 for ; Tue, 8 May 2018 14:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3p9DKu/Pi1vT86crz05ynUMNC0KEplSyu5RydqIQ/To=; b=UTeqRwKtmeGSkn YgphbAY6DmE0/iK2c98TDoryaLxcTf/OwBmJGuWuXoeeuu+Wx82RcR31gAgBwTMY1baccL/sjnzAc Eua8a02Amib55yR8iBjls4N/WE5rJKFi5zF5UNPTi92li+DgrxEt0BZUC18g2QE3U9D+bNIoPWA8u KR8anTlaf2tUS8PbzAjwlNEvxycuHuaUlmif6LB3k7njXeGelGQIMi3tPcmvC166CVn4BFXeZPzHP YQEHQvBx/vXdnSp1cejta3ApkXH2w6tnW08l0Riu/kCcMu8JbqBljrFCLye96Z+WYFiuKzRq5g+1l +ZRFT66DAcwkoF7pxBtA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fG3QM-0001K5-1b; Tue, 08 May 2018 14:17:02 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fG3QG-0001Ga-0M for linux-arm-kernel@lists.infradead.org; Tue, 08 May 2018 14:17:00 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1fG3Pz-0003EK-O9; Tue, 08 May 2018 16:16:39 +0200 Message-ID: <1525788997.18091.5.camel@pengutronix.de> Subject: Re: [PATCH] arm: dts: imx53: Fix LDB OF graph warning From: Philipp Zabel To: Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Tue, 08 May 2018 16:16:37 +0200 In-Reply-To: <20180508135930.5768-3-robh@kernel.org> References: <20180508135930.5768-1-robh@kernel.org> <20180508135930.5768-3-robh@kernel.org> X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180508_071656_226741_46849287 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Sascha Hauer , Shawn Guo , Pengutronix Kernel Team Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 2018-05-08 at 08:59 -0500, Rob Herring wrote: > Single child nodes in OF graph don't need an address and now dtc will > warn about this: > > Warning (graph_child_address): /soc/aips@50000000/ldb@53fa8008/lvds-channel@0: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary > > Since the LDB should always have an output port, fix the warning by > adding the output port, 2, to the DT. > > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Signed-off-by: Rob Herring > --- > arch/arm/boot/dts/imx53.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi > index 7d647d043f52..1cf2fc9d0a58 100644 > --- a/arch/arm/boot/dts/imx53.dtsi > +++ b/arch/arm/boot/dts/imx53.dtsi > @@ -488,6 +488,10 @@ > remote-endpoint = <&ipu_di0_lvds0>; > }; > }; > + > + port@2 { > + reg = <2>; > + }; Now that the reg property of port@2 is added in the .dtsi, it could be removed from the one .dts files that use it: ----------8<---------- ---------->8---------- > }; > > lvds-channel@1 { > @@ -503,6 +507,10 @@ > remote-endpoint = <&ipu_di1_lvds1>; > }; > }; > + > + port@2 { > + reg = <2>; > + }; > }; > }; > Reviewed-by: Philipp Zabel regards Philipp --- a/arch/arm/boot/dts/imx53-ppd.dts +++ b/arch/arm/boot/dts/imx53-ppd.dts @@ -559,8 +559,6 @@ status = "okay"; port@2 { - reg = <2>; - lvds0_out: endpoint { remote-endpoint = <&panel_in_lvds0>; };