From patchwork Mon May 28 21:21:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10434025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 55F5D60249 for ; Mon, 28 May 2018 21:22:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4615B2851B for ; Mon, 28 May 2018 21:22:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A4BA2852B; Mon, 28 May 2018 21:22:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AD2C42851B for ; Mon, 28 May 2018 21:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nb4iLOFUt9L0JZwb1FPPQvfxbGz9GYtnwiweq56VLMs=; b=kPtHEHKzAOwA1s dtkBTXi5+x0HkZG2RsT8dPwuk6W9Ont0/+eVL6e29/NWuxIDUayKofN6F35WbfRqlnp8kovTuaOiK +oQtQyO/G92KNvASIaqd/7aIXse3240bspQXuj1nLXTSPijKD22RqKuzblIXZlpWP7R46yn5ugjtv CpQisELEblxnjROHWFxGWQDmlilOACK6gpfnMYjA+eCG7s9oaF9dLaLFc73TirfMAc35eXByVsxaJ /mbzOGo4liDXpmcOdbOraIGHmqQWkGdcaYFe/DUF6rXezc8mvrABD9lUtXfmFUWsSX5wd8KaXBkpO zVPXJ+lEWgVOfXpQSbXg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNPaM-0003G8-4S; Mon, 28 May 2018 21:21:46 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNPa5-0003Cx-Px for linux-arm-kernel@lists.infradead.org; Mon, 28 May 2018 21:21:31 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7410F606CF; Mon, 28 May 2018 21:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527542480; bh=AHMrd6ZywvJGIrz1vwluQH/8SHmyN4Ki+UbaYl9UiG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bX3DaKKswbn92IqzNQts/4y7aETI7/IcStJBbA6sX05JdGsIP2fdN7CZQyjfbBa6X L2vtv3XKt4DOU4VAu0bPCsGyYiLhiXjkqc9N6klkWE4iklsSTNCeY5yy8HHQNEvY0L LTaihOjWDoXSwtZjv2G7gs77K3ygwV0L/CBnPZu8= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 70FC16044B; Mon, 28 May 2018 21:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527542479; bh=AHMrd6ZywvJGIrz1vwluQH/8SHmyN4Ki+UbaYl9UiG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lk8JalKB0Gmy+sUC5v+gu7CKavAK0s2ruU2C83Nvtlm6PAb+shg+fzN0VXE+x3D0U xMKMisd9Y+GSoWG64ap5xh7uiXeCrFceJEzPZQEezQ7e9vl8J1aDa4/U0RsMyQ5S86 s3kp42kxY1l1zk1UogEVCpeM9zBf85XKKk+slWU8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 70FC16044B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-pci@vger.kernel.org, ryan@finnie.org, timur@codeaurora.org Subject: [PATCH V3 2/2] scsi: hpsa: drop shutdown callback Date: Mon, 28 May 2018 17:21:11 -0400 Message-Id: <1527542471-10316-2-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1527542471-10316-1-git-send-email-okaya@codeaurora.org> References: <1527542471-10316-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180528_142129_883436_E85A05A0 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Don Brace , "James E.J. Bottomley" , "open list:HEWLETT-PACKARD SMART ARRAY RAID DRIVER hpsa" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, "open list:HEWLETT-PACKARD SMART ARRAY RAID DRIVER hpsa" , open list , stable@vger.kernel.org, Sinan Kaya , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP 'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown")' has been added to kernel to shutdown pending PCIe port service interrupts during reboot so that a newly started kexec kernel wouldn't observe pending interrupts. pcie_port_device_remove() is disabling the root port and switches by calling pci_disable_device() after all PCIe service drivers are shutdown. This has been found to cause crashes on HP DL360 Gen9 machines during reboot due to hpsa driver not clearing the bus master bit during the shutdown procedure by calling pci_disable_device(). Drop the shutdown API and do an orderly clean up by using the remove. Signed-off-by: Sinan Kaya Link: https://bugzilla.kernel.org/show_bug.cgi?id=199779 Fixes: cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown") Cc: stable@vger.kernel.org Reported-by: Ryan Finnie Tested-by: Ryan Finnie --- drivers/scsi/hpsa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 3a9eca1..3dbef28 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -8970,7 +8970,6 @@ static struct pci_driver hpsa_pci_driver = { .probe = hpsa_init_one, .remove = hpsa_remove_one, .id_table = hpsa_pci_device_id, /* id_table */ - .shutdown = hpsa_shutdown, .suspend = hpsa_suspend, .resume = hpsa_resume, };