| Message ID | 1529754.UBcqZ7GKj7@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Aug 22, 2016 at 11:39:30PM +0300, Sergei Shtylyov wrote: > Add support for the general purpose LEDs on the Blanche board. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > This patch is against the 'renesas-devel-20160822-v4.8-rc3' of Simon Horman's > 'renesas.git' repo plus the SDHI0/DU patches posted earlier. > > arch/arm/boot/dts/r8a7792-blanche.dts | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts > +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts > @@ -159,6 +159,27 @@ > }; > }; > > + leds { > + compatible = "gpio-leds"; > + > + led17 { > + gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>; > + label = "LED17"; I am unclear of the motivation for using the label property when its value is so similar to the name of the node. The reason I noticed this is that it appears to differ from led nodes for other Renesas ARM SoCs. I'm not opposed to using the label property if there is some value to it. But I would prefer to use it consistently. And I'd prefer not to add it to all the other SoCs unless there is a reason to. > + }; > + led18 { > + gpios = <&gpio10 11 GPIO_ACTIVE_HIGH>; > + label = "LED18"; > + }; > + led19 { > + gpios = <&gpio10 12 GPIO_ACTIVE_HIGH>; > + label = "LED19"; > + }; > + led20 { > + gpios = <&gpio10 23 GPIO_ACTIVE_HIGH>; > + label = "LED20"; > + }; > + }; > + > vcc_sdhi0: regulator-vcc-sdhi0 { > compatible = "regulator-fixed"; > >
On 08/23/2016 10:39 AM, Simon Horman wrote: >> Add support for the general purpose LEDs on the Blanche board. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> --- >> This patch is against the 'renesas-devel-20160822-v4.8-rc3' of Simon Horman's >> 'renesas.git' repo plus the SDHI0/DU patches posted earlier. >> >> arch/arm/boot/dts/r8a7792-blanche.dts | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts >> =================================================================== >> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts >> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts >> @@ -159,6 +159,27 @@ >> }; >> }; >> >> + leds { >> + compatible = "gpio-leds"; >> + >> + led17 { >> + gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>; >> + label = "LED17"; > > I am unclear of the motivation for using the label property when > its value is so similar to the name of the node. > > The reason I noticed this is that it appears to differ from led nodes > for other Renesas ARM SoCs. I was looking at the Koelsch's DT as an example (and Gose's DT also had labels). > I'm not opposed to using the label property > if there is some value to it. But I would prefer to use it consistently. > And I'd prefer not to add it to all the other SoCs unless there is a reason > to. Looks like the driver can infer the LED names from the device node names. I'll recast. [...] MBR, Sergei
Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts @@ -159,6 +159,27 @@ }; }; + leds { + compatible = "gpio-leds"; + + led17 { + gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>; + label = "LED17"; + }; + led18 { + gpios = <&gpio10 11 GPIO_ACTIVE_HIGH>; + label = "LED18"; + }; + led19 { + gpios = <&gpio10 12 GPIO_ACTIVE_HIGH>; + label = "LED19"; + }; + led20 { + gpios = <&gpio10 23 GPIO_ACTIVE_HIGH>; + label = "LED20"; + }; + }; + vcc_sdhi0: regulator-vcc-sdhi0 { compatible = "regulator-fixed";
Add support for the general purpose LEDs on the Blanche board. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against the 'renesas-devel-20160822-v4.8-rc3' of Simon Horman's 'renesas.git' repo plus the SDHI0/DU patches posted earlier. arch/arm/boot/dts/r8a7792-blanche.dts | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)