From patchwork Thu Jun 28 18:28:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10494815 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D155F60325 for ; Thu, 28 Jun 2018 19:05:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4B801FF3E for ; Thu, 28 Jun 2018 19:05:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C86932A414; Thu, 28 Jun 2018 19:05:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 631A11FF3E for ; Thu, 28 Jun 2018 19:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8EoJ11nh8yg3xBPC1yWyMoX2OKkxjms07oZlcWz36SE=; b=bt5JsqFloI9z1q 8nJ5Kp3T2+6aQzvD9etGcmHpUyfK2gYfd9RJaWFnqFIsjLZiKAheF/m6TpGw+NjR2aIf9GTjVPm5M 37jhd9W0mVXzep1QJ/O8m0TypsWuxW3FfrAszYXhNzqA2EuvCC483ldEmDGVFxhFSiyrAPXcDk5rE /SkuDJ0MhyCDtaFbzzegFkCDlbNg0s+SCYyzp/klf2RkVFe2bRsb9HF5lluzz6pzPmM9r0QERBEAf 8noV8uJrRgAX43led5lsbdiKLXKBmlRLSyMGMRD11/92K7mKg9Vuy+qyEWn8uvX8TV1U6ZkRCUXN1 usWKsK0mUUaMFOKB1xRA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fYcEh-0000K9-9C; Thu, 28 Jun 2018 19:05:43 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fYcER-000091-3W for linux-arm-kernel@bombadil.infradead.org; Thu, 28 Jun 2018 19:05:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=i8nSoUci+yea0BQlrVVJv6tfiN0EgQz7LBP/jN5oNO8=; b=SloHx2HaCa+unjWcfeTbqrfRJJ RJvLp9F/t5MEKBC7mc9zo0SdgclcnQ157qsHg+38lo50ctbtUkU1K+1MYzLGNrk8NLYZpZ8+2A1js qNbFfnHmk7ahTZGooaXusw5O4RntRSSrQls2/SrPXpBfEbSFr7PgdLTkNNofV+NmJL57lQMg9TSwe ah+mWmUBzQqvi/pxnRVfsvo6DyQt9AJqqoNZqdX9AoZc0d/z2KnmrRA5j2KkPWX4GTGyflkAklUYk t/ETqZR7WF9z409VpgRe58FaD+v9nZUfqH0y64m4XKI350BRH9uO6ckgZuNO5C/HwPbF05cGqEfma +ai4/XyA==; Received: from smtp.codeaurora.org ([198.145.29.96]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fYbgi-0000Js-Hj for linux-arm-kernel@lists.infradead.org; Thu, 28 Jun 2018 18:30:38 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EFAD360C48; Thu, 28 Jun 2018 18:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1530210624; bh=1ncvEMT8nAQIrRu/ErUgXVLRkf0/5/bV9aLIAVQipS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PjVTmnDZCzZFceJr8OXLbtvnPuSAinhUU1LvAIECZMwEo7uyfycRsMlxHo3J1/Iti Dnht/s1DABDUeZjEX5sxG+R1wP2ef5mCopzoO2e3xT4GkV02z+bNVyamImvRfgt9jl sgmTspKK7qqOGEcKDauS/4csj3RUsbfyF+C35H44= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F19B560BE3; Thu, 28 Jun 2018 18:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1530210590; bh=1ncvEMT8nAQIrRu/ErUgXVLRkf0/5/bV9aLIAVQipS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hl752CShFO008PLUQA3Euk6R2jB+HXdiLmlvjmHwqXAMz9Ihii0eDsisONR6VKwEW UKkNaqni146wBYH+zG/c9yIr2tZfunVxmnr9/lgCEL1uWZOInon5QFBu+Etq8kfuzy dNsM/VniZMKDwi7R8KDZLUVqlleG65xeoB+mi4II= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F19B560BE3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-pci@vger.kernel.org Subject: [PATCH V3 5/6] PCI: Rename pci_try_reset_bus() to pci_reset_bus() Date: Thu, 28 Jun 2018 14:28:25 -0400 Message-Id: <1530210507-9287-5-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530210507-9287-1-git-send-email-okaya@codeaurora.org> References: <1530210507-9287-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180628_143036_780480_CA63528F X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Marciniszyn , "open list:VFIO DRIVER" , Alexey Kardashevskiy , linux-arm-msm@vger.kernel.org, Dennis Dalessandro , Alex Williamson , Peter Xu , open list , Sinan Kaya , Jason Gunthorpe , Doug Ledford , Zhenyu Wang , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, "open list:HFI1 DRIVER" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Now that the old implementation of pci_reset_bus() is gone, replace pci_try_reset_bus() with pci_reset_bus(). Compared to the old implementation, new code will fail immmediately with -EAGAIN if object lock cannot be obtained. Signed-off-by: Sinan Kaya --- drivers/infiniband/hw/hfi1/pcie.c | 2 +- drivers/pci/pci.c | 18 +++++++++--------- drivers/vfio/pci/vfio_pci.c | 4 ++-- include/linux/pci.h | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c index 4570c4d..a6d695a 100644 --- a/drivers/infiniband/hw/hfi1/pcie.c +++ b/drivers/infiniband/hw/hfi1/pcie.c @@ -905,7 +905,7 @@ static int trigger_sbr(struct hfi1_devdata *dd) * delay after a reset is required. Per spec requirements, * the link is either working or not after that point. */ - return pci_try_reset_bus(dev->bus); + return pci_reset_bus(dev->bus); } /* diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 6cec722..28a071d 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4784,7 +4784,7 @@ int pci_probe_reset_slot(struct pci_slot *slot) EXPORT_SYMBOL_GPL(pci_probe_reset_slot); /** - * __pci_try_reset_slot - Try to reset a PCI slot + * __pci_reset_slot - Try to reset a PCI slot * @slot: PCI slot to reset *` * A PCI bus may host multiple slots, each slot may support a reset mechanism @@ -4798,7 +4798,7 @@ EXPORT_SYMBOL_GPL(pci_probe_reset_slot); * * Same as above except return -EAGAIN if the slot cannot be locked */ -static int __pci_try_reset_slot(struct pci_slot *slot) +static int __pci_reset_slot(struct pci_slot *slot) { int rc; @@ -4854,12 +4854,12 @@ int pci_probe_reset_bus(struct pci_bus *bus) EXPORT_SYMBOL_GPL(pci_probe_reset_bus); /** - * __pci_try_reset_bus - Try to reset a PCI bus + * __pci_reset_bus - Try to reset a PCI bus * @bus: top level PCI bus to reset * * Same as above except return -EAGAIN if the bus cannot be locked */ -static int __pci_try_reset_bus(struct pci_bus *bus) +static int __pci_reset_bus(struct pci_bus *bus) { int rc; @@ -4882,22 +4882,22 @@ static int __pci_try_reset_bus(struct pci_bus *bus) } /** - * pci_try_reset_bus - Try to reset a PCI bus + * pci_reset_bus - Try to reset a PCI bus * @pdev: top level PCI device to reset via slot/bus * * Same as above except return -EAGAIN if the bus cannot be locked */ -int pci_try_reset_bus(struct pci_dev *pdev) +int pci_reset_bus(struct pci_dev *pdev) { bool slot = false; if (!pci_probe_reset_slot(pdev->slot)) slot = true; - return slot ? __pci_try_reset_slot(pdev->slot) : - __pci_try_reset_bus(pdev->bus); + return slot ? __pci_reset_slot(pdev->slot) : + __pci_reset_bus(pdev->bus); } -EXPORT_SYMBOL_GPL(pci_try_reset_bus); +EXPORT_SYMBOL_GPL(pci_reset_bus); /** * pcix_get_max_mmrbc - get PCI-X maximum designed memory read byte count diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 71018ec..345c0dc 100644 --- a/drivers/vfio/pci/vfio_pci.c +++ b/drivers/vfio/pci/vfio_pci.c @@ -1010,7 +1010,7 @@ static long vfio_pci_ioctl(void *device_data, &info, slot); if (!ret) /* User has access, do the reset */ - ret = pci_try_reset_bus(vdev->pdev); + ret = pci_reset_bus(vdev->pdev); hot_reset_release: for (i--; i >= 0; i--) @@ -1372,7 +1372,7 @@ static void vfio_pci_try_bus_reset(struct vfio_pci_device *vdev) } if (needs_reset) - ret = pci_try_reset_bus(vdev->pdev); + ret = pci_reset_bus(vdev->pdev); put_devs: for (i = 0; i < devs.cur_index; i++) { diff --git a/include/linux/pci.h b/include/linux/pci.h index ad0c89a..79a2c27 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1096,7 +1096,7 @@ int pci_reset_function_locked(struct pci_dev *dev); int pci_try_reset_function(struct pci_dev *dev); int pci_probe_reset_slot(struct pci_slot *slot); int pci_probe_reset_bus(struct pci_bus *bus); -int pci_try_reset_bus(struct pci_dev *dev); +int pci_reset_bus(struct pci_dev *dev); void pci_reset_secondary_bus(struct pci_dev *dev); void pcibios_reset_secondary_bus(struct pci_dev *dev); void pci_update_resource(struct pci_dev *dev, int resno);