From patchwork Wed Jul 4 09:38:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 10506431 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 42685603D7 for ; Wed, 4 Jul 2018 09:54:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E4A428DD1 for ; Wed, 4 Jul 2018 09:54:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F2E228DD7; Wed, 4 Jul 2018 09:54:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AB1F428DD1 for ; Wed, 4 Jul 2018 09:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0W8TIUMx7cAE98PCfx355xXuBzEp8wCwKEb+E6KmK6M=; b=CDT+9+ErS5bF9t Vw87QQTrlK3QMzwRnDxjEfCE3AY9oUDmzYcP2Myx3Fj1d2TUoHo5n1/7tHfPwezSZWr73+3K6TAwl eFJOSx/N5AiJGnmceDrCsNsq25opIoxHixHs++Fx1nukarIq5ngmwxLVaz+Ew9uYAikIlpGwkQroT IBJNj0tZkRLylPKSMvM4GMwuLYtP9ARvDt3Ls0NmjKxVKuV8lAxBJxHzOsnH3pmNmH4hduf0oFfLq w6ZClbrslsgpRrS62ubdhtyAxFRAZm23YS2HIROT7GAlqUn+4aSNzkG68zBl6HDGapOLUKDPS0vKE N2Rcl0yY9fPUPX6O3gjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1faeUc-0003y6-39; Wed, 04 Jul 2018 09:54:34 +0000 Received: from mail-he1eur01hn0331.outbound.protection.outlook.com ([2a01:111:f400:fe1e::331] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1faeFa-0000bN-1L for linux-arm-kernel@lists.infradead.org; Wed, 04 Jul 2018 09:39:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lnV1hwoN+NNUe/AH7SDQSeihsFxSvUTLNxTYcd9jUNk=; b=SkAUlw71IjqNgdXvkg6FhwGhwwCzTGQesSncRXRfrOyMtlX4d9q4FvDq4ruRZqfeV3z1Fm2CtGpvKxcfkBTcXcQNNHQ+uMIai7t6Wp6EAFli4FkAfOds9ylvtK9zblb30chXwzxVMa4ui1qbqlz8SCBbksDD64NPkvvSLimHcrg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christoffer.Dall@arm.com; Received: from localhost (217.140.96.140) by HE1PR0801MB2042.eurprd08.prod.outlook.com (2603:10a6:3:50::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.25; Wed, 4 Jul 2018 09:38:47 +0000 From: Christoffer Dall To: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 5/6] KVM: arm/arm64: vgic: Signal IRQs using their configured group Date: Wed, 4 Jul 2018 11:38:19 +0200 Message-Id: <1530697100-22419-6-git-send-email-christoffer.dall@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530697100-22419-1-git-send-email-christoffer.dall@arm.com> References: <1530697100-22419-1-git-send-email-christoffer.dall@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: HE1PR05CA0324.eurprd05.prod.outlook.com (2603:10a6:7:92::19) To HE1PR0801MB2042.eurprd08.prod.outlook.com (2603:10a6:3:50::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: afbdde19-3de3-400a-d3b5-08d5e191f122 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:HE1PR0801MB2042; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB2042; 3:jDpw5MofP+NfglMEglc4gU2K3xDyM12MWXrQXKAfiIwcsIKIfjjmtZ/8P9XTghcLZleVYePqGGX67jIUWcF7AjIX0Er9GWz1V0CG1piNLNSuiSwfm5+i50iemSzubEQxVPiemMpOCLf6w9KfSiwTURS4N0NLFtkk32aYKbMG1oDxtcH4GP969Q1mGzTY8W5/6tmj/Fp/zBq79X6evOMUGcGFetgPNlN67BhhSefn+rsT4J2jUTCSo4yLETpURifO; 25:yRlpNYJMYIxhDJj7B2ROHkc/38tFrd+1juxjx3OQTUALNOkPKJSF7V61N/cBr/wAzmbcswpQOsxWCgBMZ6fnesbQx/FuBMSalAEbuRBj4V686zrC20HrzO1azOkpK+bydY30HrLZ1JOBSd6DMEi8+H1qamgXK4tgq7sDlfvE4HYyy8ro+gcatg6e3KcC3q0VII4umsl4fgqWYN7oA5Y7vI2ouI9+tqE6LUvlsXQja6NJo2PTenZc6G613tEMCSU88bP/vo3Z8V1KoXlUNV7MwLHTOs4AJzOzcs6lzRX+cP8cyqxvfn/gio/ELdSmdG/fYVg8fgWBg5YgOxJ42aCJ4g==; 31:BJZmMwUwthkTfcDdEjU8mNvCl8T4YK9HEHOL6Q1qxeLX9iQreF8LHuMteNODN64SHdrDijpgkjfXarHpiWCJXPUnFSh2SQ16x80Xz7vZ1wgAO/dHeiNE9qeYM4/NbkJAWhV9OOg/SpaC12bUkzp/wEPHU5srjlAx4Fkl+iZ4wLeXw/9STxwveSRANnw0cuafhk81lHN4maogzLj33ECpK0F/mh2mjWvX9oc/MUXgc7c= X-MS-TrafficTypeDiagnostic: HE1PR0801MB2042: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB2042; 20:RKBhSgDdEurn55FXh/WcIrkpqoybGa4WAByD9HicygLRJQ4g7MuFz3o2zZxIbebDBILJTk68wb9y4o76ZD42chnn2gOHXdUfvV4u19FGcxiMWeqJlaK50+a0bysdK5TgUMvRDGivf40LE+zKgOAWLncR8j1E+9ZzZFhWkPdMY4jEo1CbOGlERKA7+gQ/5wfb4o6QABBfvHR0w3xtPHjRTtstJjpthZPbB3qRvZ8dta7lg/F1Yk6YqqAGrYUs1epbgnZmNz2IA71qxri+kuXf4ykC/LDJcI5VC0KxzLTgh5CIZavtBa4H4CDnrQ0qVpQMcJig8W33dLb6t8Y/Eqyu/vIs89kVO0NrNX2tX+2DdXePzvkjqVfiQT/3AdO59+4drCSdvun/oVZ+ZfS8WAQ8yhqm3CKWX/vnmlt7GF5pQLc7E+1NFzvSaLMDvNa6zr/EBMU7DOGe8OTGeP4reuNkxiZwjv80GJfPf3fsqZ4RLktMRIknr22fQCaxyRlRNd98; 4:PjwaQnHwQkchNs8g4sre6ANbt3JzldBwiGfMbhaXopwpiPMHwyz8n9N2FG4WLVRBZGVt53MSf03FZSuclzoxWBD9VrMiYG0/GP85lv9Mnwuu3JRa2ji3q7JE8q3DWWIg6nXGORI8c+p1/JzvSGhdOYprLwP7+CcUAaGaFrAuxSsOmLn9EsTkXxToEkL+X5oLJnplLsFJVQ4ThWTyuFZNXxB7vBHE0mz+Q+ratOziXogdT89/tu7GfJNT2tECw70eO9nlZcgFgLxtjpLcMc0X+DUZ079fnijESp1LUxei9SvhRKXH3g4hB9p+alcw0lT2ekdCUcLK+Irs5x+mQ2+MS2B0mOCGkrt6FhS3d676lwc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(223705240517415); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0801MB2042; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB2042; X-Forefront-PRVS: 0723A02764 X-Forefront-Antispam-Report: SFV:SPM; SFS:(10009020)(6069001)(396003)(136003)(366004)(346002)(39860400002)(376002)(40434004)(189003)(199004)(52116002)(26005)(66066001)(16526019)(4326008)(25786009)(186003)(2616005)(14444005)(105586002)(956004)(2171002)(36756003)(6496006)(478600001)(81166006)(8676002)(81156014)(11346002)(2906002)(5024004)(72206003)(44832011)(106356001)(8936002)(48376002)(476003)(47776003)(3846002)(54906003)(386003)(86362001)(76176011)(316002)(486006)(50226002)(53936002)(97736004)(6116002)(50466002)(305945005)(6666003)(446003)(51416003)(8746002)(6486002)(7736002)(68736007)(5660300001)(76506005)(23200700001); DIR:OUT; SFP:1501; SCL:5; SRVR:HE1PR0801MB2042; H:localhost; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0801MB2042; 23:I5aHDvx4XaWnp8mnqKCfuIok0OUmIxK6i9ZmCKP?= =?us-ascii?Q?1KUw00Sf1VxeF+rSmTcLBKwZs+kDVXN3/C8FAmWfGYd8OU38AX0Uakn4tLxU?= =?us-ascii?Q?XYPZu1/oAlP4pPt6eawfk0Uj5I2iNoWgtTTB35nJFJFOY78UdW4rD5wJKdEZ?= =?us-ascii?Q?QDZTdAvF5jBC2y94VN5QVeCI8YPb55rsafxVaJdkCPwWoj6Z8A5Ay4DQ1yPU?= =?us-ascii?Q?REv9JE259QTMUfL68YSfgtbHCsA8GgIZOWUttmTBNj4h2aGi03aLEwTPClBi?= =?us-ascii?Q?yuVddYNG7KnW4FJanWT5QGoPwJUatHd55sLfPNXAMZGUXwedtiutkQa5hkRO?= =?us-ascii?Q?FScgfbUsGwGwTmjNCVryJ6DPUMdkqGGFMeaWB4EnJPiGQsfz1Vm4eABRyvSi?= =?us-ascii?Q?YKlh6qqV9LsMmvxYeMLbD+sdYRJSAczzNe4e5E3LLuHAgcI846RAhgC9etbz?= =?us-ascii?Q?moJsZviK3IdcCZzX4vVgEWU65FoQm0eR9sMywlvW+o8B5McmzEWsUEFXDHqT?= =?us-ascii?Q?5K69ii7jI/o2lGZwrFkB0SrhvdeOMxAQBUgMnOKKWTK02qX5jfCLhdjcZE7o?= =?us-ascii?Q?NWibPfS294mjDqhRwI9vTW5NGBy3fg0EljrIf/mtqiHNKk5wqGPTv8jAqHI8?= =?us-ascii?Q?NTRxczYuC0JfjtzfmTMZF9aOLzAbgeW0VoI3I/+uxyk3oiecMPNqT9Cyu7FC?= =?us-ascii?Q?WMZ41eCfk/2dTYDyq8YBe4u2BFDyoBlQImcQSJpbAcj/POZjSqh5yAwvPvt2?= =?us-ascii?Q?AQYtvqtI5ArM5+cN4V0+FnVPSNzHwYK1cXPe1sdyT2UlJvWe9vtQFEwzUPd8?= =?us-ascii?Q?KvdmPFDPTwjALHaumAJELOxc4uVR+LlDZKAhn9/ZZGlKBjpLC6GP38jt0pSw?= =?us-ascii?Q?IwDZNznrLUi2TD+wHtmGes9IQm8PqdsbLeVRJeOBvH3hi4+1uEbzguJs+iCZ?= =?us-ascii?Q?LBMkPktkpA0blYQy/FOWgioK93pHRv/FixrKnXcAYSZ9gUXZgfPZDkc5o8Gs?= =?us-ascii?Q?hqYXDq7pbODxhe8DkHKRx6pVX3uT560wZGIUcTIqQN3l6qSBjy3Yxs58DCjj?= =?us-ascii?Q?iqDCKBp2UXpRFNRHI0SGYHBT0P8wqSLIidRaHQXhn4aG5qjr6CzT/LKFWbe4?= =?us-ascii?Q?sMeUfKAQf90BCFTuN5p9npxaZ8Yw/p7P+eAwbNp1DVvzkIoVMMUJ089ahLut?= =?us-ascii?Q?DLWSqQh3ABUjV8k5v+octJ6GY+GJB/zQnrzE8f8Zo28qyMUJmtkwYLMy5ri3?= =?us-ascii?Q?4hEFp3qxcN1pAxcSLn6YrrH02LJ0xjIfwzKmiMG7WEUdcEFkYW1x7oxz91/6?= =?us-ascii?Q?eYW+Jo04vp28wIVzfHP3JrAzF2N6HtCuxgZQdvDgXAyBSsPLPn5R4PZlXxkx?= =?us-ascii?Q?oGE8gk3VqdrH/2qrocFixHS9226s=3D?= X-Microsoft-Antispam-Message-Info: sgaq02jzhWSJYeXEUPU1b0nac6j8tVIA/CrPfPeQrFt+rexm78hS9Q9phRqMPtyjpG4RbIlfMLjmjrfNeEW8iXhlfbakHb1vL46wQ6SYkldjwvfuZsYkGRaKqe3hlw+YgSzQ68UpLc32C19umNyo6bOiMy4XAu+GrhGVfyW0tMz/eoz0AdWVgSg/mkFJEUkd/bz7btIuw3ufz2NCrJLuHla4DygROYUGSaBzFaDliImg9nEt8O64lPcGPCd/4S9GPhO2P1COUWV7uyphycSYTjiTaStHH7ip9aOl1/x1DZrYdAAKWomYurn3NqbUEfnJ2JqwE0fl0GSSsCS0/ZPrQQ2b+HvS8/0dYqAyKFZczf0AafEs4PCUqVHHZhIfbmZg7F+QHlStVJaBOs86dChwL+TCXFslO8FWSp0OajpMhtV3yc94MsAJh8HpCw/y5YcxGAJFKatN4inhBYUSnIYmOpPWDdhk4L0jjDxrlPhJbOO40Cpbx4D49jnNvEYzaUCh2gl2Dw8f2XAooVbaCtqverB9p83VY1oXvlrAUSECzcNIq18KjfwxTIszXb02NZmK48FKgOkaipsUr8HiWLcajA== X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB2042; 6:X4/ALXQ7U8dOrhHLVONUrIHVU0f3YhTAOu83NY6KBl70olWxg59wycJjJrpBXqv7eRunQvLUaLrNJPmmzbMjuvuM8PD660Vx2MNPtP88kZEkeaBMT4la0UYDs0rN2viDZhU7oBEJB0zSfMuU/H5GwsQqqiysbGwEPVkuntQbnSt/hiFNhnU6orGime/VqfYDf1TZXB7TJOayS/axVvD3L6dVCoYt42H4HaP5dGzumiPs22zY/n4YOAGRjS8pUz9mWQtqgJ7CBSXce5MuZxETdsC8Qq4bHOhzuzwb2FCkUaUvKcRv5yVPvfazuJwVTQGQMSC9do84jduX/Tf6mX7ZLGNoQgMOSIHHS6hq2tK7yDRBaC6wlCrCNZJUKZ5IUo60zuPr5PIuRqCiRJMYPY16N90PFNhnM4Bc5LEZk0EBMkbsEH3vkaO0r4P3g6iIlhp17gJcPlYPIINhy0R0pimsZ9CIIg7E+03Pk5x2cIKe6gLVzjs7+z1WiSzZnGKX7qsq; 5:Jo0+yqOatoeUNCzssyoYa5v3q3/VIW+cRZgi791CY6/qs8njjpxX6geOFzFHrKaT9smFiy1fBQkjNjoVVl8dEdA5ARM4YDQZHUqVWFWzWVxqaMLVM7uzdF7KRs1ABpQhrd4zdQT5c2wKVZ4kSUMl4Gk+cVIRYlG9itYaSjQlzFE=; 24:8+RMWFSPTVPLDc6uE+tljeTC6FtDal/+wS2W05CoagXfP0wKJkYGqr/tw334s5z0FSMKdHxmvraWeNW1tay4Zg== SpamDiagnosticOutput: 1:22 X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB2042; 7:p4Fz7WFE8XgkBfR6e6UscXPQkzOQ/IIMeKHBO/Tv0/wkZaQV5YrqAG28oWkpojkEUokS2J7gnMRAwT7+aBhsATufRW59s1eTbKK9nkHUhHvYoj1XiOZfstQQMDq49wsqjg00CAOBx4UB/jIkiVa1HzHAxUbP1RyowXofHdeyocjqMDH/OjEwnA9wAclLWGlNb+sPQI+rka/gmS0KSe5wWnvHzDutCZhjZ68S9ynDEDFXKjDwrhm2DIyuQgLzxVvK X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2018 09:38:47.2079 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afbdde19-3de3-400a-d3b5-08d5e191f122 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2042 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180704_023902_874345_694BF1F8 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, Marc Zyngier , Andre Przywara , Christoffer Dall , Eric Auger Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Now when we have a group configuration on the struct IRQ, use this state when populating the LR and signaling interrupts as either group 0 or group 1 to the VM. Depending on the model of the emulated GIC, and the guest's configuration of the VMCR, interrupts may be signaled as IRQs or FIQs to the VM. Signed-off-by: Christoffer Dall --- include/linux/irqchip/arm-gic.h | 1 + virt/kvm/arm/vgic/vgic-v2.c | 3 +++ virt/kvm/arm/vgic/vgic-v3.c | 6 +----- 3 files changed, 5 insertions(+), 5 deletions(-) -- 2.7.4 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. diff --git a/include/linux/irqchip/arm-gic.h b/include/linux/irqchip/arm-gic.h index 484f5bf..6c4aaf0 100644 --- a/include/linux/irqchip/arm-gic.h +++ b/include/linux/irqchip/arm-gic.h @@ -104,6 +104,7 @@ #define GICH_LR_PENDING_BIT (1 << 28) #define GICH_LR_ACTIVE_BIT (1 << 29) #define GICH_LR_EOI (1 << 19) +#define GICH_LR_GROUP1 (1 << 30) #define GICH_LR_HW (1 << 31) #define GICH_VMCR_ENABLE_GRP0_SHIFT 0 diff --git a/virt/kvm/arm/vgic/vgic-v2.c b/virt/kvm/arm/vgic/vgic-v2.c index a5f2e44..df5e6a6 100644 --- a/virt/kvm/arm/vgic/vgic-v2.c +++ b/virt/kvm/arm/vgic/vgic-v2.c @@ -159,6 +159,9 @@ void vgic_v2_populate_lr(struct kvm_vcpu *vcpu, struct vgic_irq *irq, int lr) } } + if (irq->group) + val |= GICH_LR_GROUP1; + if (irq->hw) { val |= GICH_LR_HW; val |= irq->hwintid << GICH_LR_PHYSID_CPUID_SHIFT; diff --git a/virt/kvm/arm/vgic/vgic-v3.c b/virt/kvm/arm/vgic/vgic-v3.c index cdce653..530b849 100644 --- a/virt/kvm/arm/vgic/vgic-v3.c +++ b/virt/kvm/arm/vgic/vgic-v3.c @@ -197,11 +197,7 @@ void vgic_v3_populate_lr(struct kvm_vcpu *vcpu, struct vgic_irq *irq, int lr) if (vgic_irq_is_mapped_level(irq) && (val & ICH_LR_PENDING_BIT)) irq->line_level = false; - /* - * We currently only support Group1 interrupts, which is a - * known defect. This needs to be addressed at some point. - */ - if (model == KVM_DEV_TYPE_ARM_VGIC_V3) + if (irq->group) val |= ICH_LR_GROUP; val |= (u64)irq->priority << ICH_LR_PRIORITY_SHIFT;