diff mbox series

arm64: dts: allwinner: activate spi flash on pine64 LTS board

Message ID 1532587906-5415-1-git-send-email-Akash_Gajjar@mentor.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: allwinner: activate spi flash on pine64 LTS board | expand

Commit Message

agajjar July 26, 2018, 6:51 a.m. UTC
This board has SPI flash. add spi flash support in device tree.
Tested on pine64 LTS.

Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
---
 .../arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Maxime Ripard July 26, 2018, 7:29 a.m. UTC | #1
1;5202;0c
On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> This board has SPI flash. add spi flash support in device tree.
> Tested on pine64 LTS.
> 
> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>

Queued for 4.20, thanks!

Maxime
Maxime Ripard July 26, 2018, 7:31 a.m. UTC | #2
On Thu, Jul 26, 2018 at 09:29:24AM +0200, Maxime Ripard wrote:
> 1;5202;0c
> On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> > This board has SPI flash. add spi flash support in device tree.
> > Tested on pine64 LTS.
> > 
> > Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
> 
> Queued for 4.20, thanks!

No, sorry, I ended up droping that patch.

You mention that the Pine64 LTS has an SPI flash, yet you change the
sopine baseboard dts. Why is that?

Maxime
Emmanuel Vadot July 26, 2018, 8 a.m. UTC | #3
On Thu, 26 Jul 2018 09:31:38 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:

> On Thu, Jul 26, 2018 at 09:29:24AM +0200, Maxime Ripard wrote:
> > 1;5202;0c
> > On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> > > This board has SPI flash. add spi flash support in device tree.
> > > Tested on pine64 LTS.
> > > 
> > > Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
> > 
> > Queued for 4.20, thanks!
> 
> No, sorry, I ended up droping that patch.
> 
> You mention that the Pine64 LTS has an SPI flash, yet you change the
> sopine baseboard dts. Why is that?

 There is still no dts for Pine64-LTS (Andre latest serie address that).
 Note that the sopine.dtsi already have the SPI node, the patch is
present in sunxi/dt64-for-4.19

> Maxime
> 
> -- 
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
index abe179d..9af07db 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
@@ -134,6 +134,18 @@ 
 	regulator-name = "vcc-wifi";
 };
 
+&spi0  {
+	status = "okay";
+
+	flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "winbond,w25q128", "jedec,spi-nor";
+		reg = <0x0>;
+		spi-max-frequency = <40000000>;
+	};
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pins_a>;