From patchwork Wed Oct 17 09:18:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 10645181 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 267CB17D4 for ; Wed, 17 Oct 2018 09:19:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07C022AC33 for ; Wed, 17 Oct 2018 09:19:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F052E2AC3C; Wed, 17 Oct 2018 09:19:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5E0962AC33 for ; Wed, 17 Oct 2018 09:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=lgWm21Ty6avK32i5hCga9QKsGH7qW6IozAvnhoMhTa0=; b=KON SQSnGoNHckiZ8AcJS58jS5JTffxWKS8HF1TUWhJKiKrSmNsn8/hQv86BIhd3AMUhfm4HGc8G74iXn wR1nAQXmGt65X4LN58GRL7Ktw+5HY6SvNiUz6fTCHbprEnpf4DQWDOq+SaRZ5i1VCIh03pUrQs2yO a1M0vjCrPrbFrZBZRYcW33fxGfFy9nUzAz9MZW6gm8hc+3W6HovPPaF1WrerJXTjLgkKO414pLWSb Q1lz8rexJXsKWIMj2dN5lmKL1Wk/gf1WB4i6Pf03/XZxdO46y93LvSPZBvZ+BcTe1SNjuHchotTB6 IlLX2b+T6ymjsL37BEqRxq4jPxfXvFA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gChyx-0004sX-BZ; Wed, 17 Oct 2018 09:19:11 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gChyt-0004rH-6V for linux-arm-kernel@lists.infradead.org; Wed, 17 Oct 2018 09:19:09 +0000 Received: by mail-wm1-x344.google.com with SMTP id 206-v6so1222818wmb.5 for ; Wed, 17 Oct 2018 02:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=gtO5omnR5DvfsMQEV+qrCgDc9JtgzpU/WP6fSSftpWs=; b=fx3pQzb7C/Y3ml/4o3vKT2ohmdcsHQTEsOzZkA3pKIiJdSaLHWe135bt45leh8Dll1 rwM4JNDQpKwKABPGwWu0IcAE9E8k7/4V5pD0AnoohfZnbjnLvJoNwmLx62HXqezDIK8C U5ZlmPlPc8cj3e7LR9P2nA8mNwyiORXdIx8oo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gtO5omnR5DvfsMQEV+qrCgDc9JtgzpU/WP6fSSftpWs=; b=IBU92PhJGovphpZ0hQtDZA5OMp8CXzK4AFO0cqArNB9WrtCsEVzXJktIun7FLvq+y5 1BYwtm94UgV0PHvhr1Y06C9HxNyJEblyMo4VcIj21b9gvAZ70jJwhB4q21zv9RbGZjOK JCGOXpJgjZCI+8W/a93jSOeBsVkxKH6UR49O9Yu738CNyqh+4XypV6SJqOXIxKbitsMf Dez71WAbWTFBwvc0EDdxYbxRdHO/Gqn7rfABT1fJEqIYKs2SiOS3+U1geMOHZmPJgmzx YnI5YjAy1RMHnymTequ3hiPJ0syPG/uywx3FM7zve8a9Y7xaLadcLgVnhh9qE9j39ejQ /IeQ== X-Gm-Message-State: ABuFfohbsv4wf2zW/bkY+qr/5jjGsqYQWR2Q/CoOFd39864QGZZ+ehMA zTFEh3HZETGI1T39i/VUDNm0BQ== X-Google-Smtp-Source: ACcGV60XgibpgquriQ8CcrhbTlIZZwciaziCcARXhPtWSPJGHNa0oFSUMiksyN9b1N2VOUNstKuvTQ== X-Received: by 2002:a1c:34d2:: with SMTP id b201-v6mr1903808wma.115.1539767934167; Wed, 17 Oct 2018 02:18:54 -0700 (PDT) Received: from localhost.localdomain (212.156.88.92.rev.sfr.net. [92.88.156.212]) by smtp.gmail.com with ESMTPSA id 18-v6sm1094723wmw.26.2018.10.17.02.18.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 17 Oct 2018 02:18:53 -0700 (PDT) From: Daniel Lezcano To: heiko@sntech.de Subject: [PATCH V2] DT: rockchip: Fix stability issues with the 'performance' governor on rock960 Date: Wed, 17 Oct 2018 11:18:30 +0200 Message-Id: <1539767918-26587-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181017_021907_277331_F1CFBEFF X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Shawn Lin , linux-kernel@vger.kernel.org, Vicente Bergas , "open list:ARM/Rockchip SoC support" , Rob Herring , Manivannan Sadhasivam , Enric Balletbo i Serra , Ezequiel Garcia , "moderated list:ARM/Rockchip SoC support" MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When the performance governor is set as default, the rock960 hangs around one minute after booting, whatever the activity is (idle, key pressed, loaded, ...). Based on the commit log found at https://patchwork.kernel.org/patch/10092377/ "vdd_log has no consumer and therefore will not be set to a specific voltage. Still the PWM output pin gets configured and thence the vdd_log output voltage will changed from it's default. Depending on the idle state of the PWM this will slightly over or undervoltage the logic supply of the RK3399 and cause instability with GbE (undervoltage) and PCIe (overvoltage). Since the default value set by a voltage divider is the correct supply voltage and we don't need to change it during runtime we remove the rail from the devicetree completely so the PWM pin will not be configured." After removing the vdd-log from the rock960's specific DT, the board does no longer hang and shows a stable behavior. Apply the same change for the rock960 by removing the vdd-log from the DT. Fixes: 874846f1fccd ("arm64: dts: rockchip: add 96boards RK3399 Ficus board") Tested-by: Manivannan Sadhasivam Signed-off-by: Daniel Lezcano --- Changelog - V2 * Added Tested and Fixes tags --- arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index 6c8c4ab..56abbb0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi @@ -57,18 +57,6 @@ regulator-always-on; vin-supply = <&vcc_sys>; }; - - vdd_log: vdd-log { - compatible = "pwm-regulator"; - pwms = <&pwm2 0 25000 0>; - regulator-name = "vdd_log"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1400000>; - regulator-always-on; - regulator-boot-on; - vin-supply = <&vcc_sys>; - }; - }; &cpu_l0 {