| Message ID | 1543311334-8807-5-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add i.MX system controller RTC driver | expand |
Hi, On Tue, 27 Nov 2018 09:41:46 +0000 Anson Huang wrote: > Add i.MX8QXP system controller RTC support. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > index 9155d45..ef57db6 100644 > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > @@ -433,4 +433,8 @@ > #size-cells = <1>; > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > }; > + > + rtc: rtc { > + compatible = "nxp,imx8qxp-sc-rtc"; > + }; > }; IMO this should be disabled by default. Lothar Waßmann
Hi, Lothar Best Regards! Anson Huang > -----Original Message----- > From: Lothar Waßmann [mailto:LW@KARO-electronics.de] > Sent: 2018年11月28日 17:04 > To: Anson Huang <anson.huang@nxp.com> > Cc: a.zummo@towertech.it; alexandre.belloni@bootlin.com; > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com; > will.deacon@arm.com; Aisheng DONG <aisheng.dong@nxp.com>; Andy Gross > <andy.gross@linaro.org>; arnd@arndb.de; horms+renesas@verge.net.au; > heiko@sntech.de; bjorn.andersson@linaro.org; enric.balletbo@collabora.com; > amit.kucheria@linaro.org; ezequiel@collabora.com; olof@lixom.net; > shawnguo@kernel.org; linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > RTC support > > Hi, > > On Tue, 27 Nov 2018 09:41:46 +0000 Anson Huang wrote: > > Add i.MX8QXP system controller RTC support. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > index 9155d45..ef57db6 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > @@ -433,4 +433,8 @@ > > #size-cells = <1>; > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > > }; > > + > > + rtc: rtc { > > + compatible = "nxp,imx8qxp-sc-rtc"; > > + }; > > }; > IMO this should be disabled by default. This module is NOT depending on any board design, should it be enabled by default in soc dtsi? Like wdog etc.. Anson. > > > Lothar Waßmann
Anson Huang <anson.huang@nxp.com> wrote: > Hi, Lothar > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Lothar Waßmann [mailto:LW@KARO-electronics.de] > > Sent: 2018年11月28日 17:04 > > To: Anson Huang <anson.huang@nxp.com> > > Cc: a.zummo@towertech.it; alexandre.belloni@bootlin.com; > > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com; > > will.deacon@arm.com; Aisheng DONG <aisheng.dong@nxp.com>; Andy Gross > > <andy.gross@linaro.org>; arnd@arndb.de; horms+renesas@verge.net.au; > > heiko@sntech.de; bjorn.andersson@linaro.org; enric.balletbo@collabora.com; > > amit.kucheria@linaro.org; ezequiel@collabora.com; olof@lixom.net; > > shawnguo@kernel.org; linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > dl-linux-imx <linux-imx@nxp.com> > > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > > RTC support > > > > Hi, > > > > On Tue, 27 Nov 2018 09:41:46 +0000 Anson Huang wrote: > > > Add i.MX8QXP system controller RTC support. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > --- > > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > index 9155d45..ef57db6 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > @@ -433,4 +433,8 @@ > > > #size-cells = <1>; > > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > > > }; > > > + > > > + rtc: rtc { > > > + compatible = "nxp,imx8qxp-sc-rtc"; > > > + }; > > > }; > > IMO this should be disabled by default. > > This module is NOT depending on any board design, should it be enabled by default in soc dtsi? > Like wdog etc.. > What about existing users (if there are any), which would have a new device appearing when updating the DTB? Lothar Waßmann
On 28/11/2018 09:06:27+0000, Anson Huang wrote: > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > index 9155d45..ef57db6 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > @@ -433,4 +433,8 @@ > > > #size-cells = <1>; > > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > > > }; > > > + > > > + rtc: rtc { > > > + compatible = "nxp,imx8qxp-sc-rtc"; > > > + }; > > > }; > > IMO this should be disabled by default. > > This module is NOT depending on any board design, should it be enabled by default in soc dtsi? > Like wdog etc.. > I guess the point is that you may not want it enabled, even if it should always be working. enabling it by default would affect the RTC ordering for example.
Hi, Lothar Best Regards! Anson Huang > -----Original Message----- > From: Lothar Waßmann [mailto:LW@KARO-electronics.de] > Sent: 2018年11月28日 17:13 > To: Anson Huang <anson.huang@nxp.com> > Cc: a.zummo@towertech.it; alexandre.belloni@bootlin.com; > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com; > will.deacon@arm.com; Aisheng DONG <aisheng.dong@nxp.com>; Andy Gross > <andy.gross@linaro.org>; arnd@arndb.de; horms+renesas@verge.net.au; > heiko@sntech.de; bjorn.andersson@linaro.org; enric.balletbo@collabora.com; > amit.kucheria@linaro.org; ezequiel@collabora.com; olof@lixom.net; > shawnguo@kernel.org; linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > RTC support > > Anson Huang <anson.huang@nxp.com> wrote: > > > Hi, Lothar > > > > Best Regards! > > Anson Huang > > > > > -----Original Message----- > > > From: Lothar Waßmann [mailto:LW@KARO-electronics.de] > > > Sent: 2018年11月28日 17:04 > > > To: Anson Huang <anson.huang@nxp.com> > > > Cc: a.zummo@towertech.it; alexandre.belloni@bootlin.com; > > > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com; > > > will.deacon@arm.com; Aisheng DONG <aisheng.dong@nxp.com>; Andy > Gross > > > <andy.gross@linaro.org>; arnd@arndb.de; horms+renesas@verge.net.au; > > > heiko@sntech.de; bjorn.andersson@linaro.org; > > > enric.balletbo@collabora.com; amit.kucheria@linaro.org; > > > ezequiel@collabora.com; olof@lixom.net; shawnguo@kernel.org; > > > linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; > > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > dl-linux-imx <linux-imx@nxp.com> > > > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system > > > controller RTC support > > > > > > Hi, > > > > > > On Tue, 27 Nov 2018 09:41:46 +0000 Anson Huang wrote: > > > > Add i.MX8QXP system controller RTC support. > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > --- > > > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > > index 9155d45..ef57db6 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > > @@ -433,4 +433,8 @@ > > > > #size-cells = <1>; > > > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > > > > }; > > > > + > > > > + rtc: rtc { > > > > + compatible = "nxp,imx8qxp-sc-rtc"; > > > > + }; > > > > }; > > > IMO this should be disabled by default. > > > > This module is NOT depending on any board design, should it be enabled by > default in soc dtsi? > > Like wdog etc.. > > > What about existing users (if there are any), which would have a new device > appearing when updating the DTB? This i.MX8QXP is a new SoC on the way to upstream, no old dtb used, so is it OK to keep it enabled by default and aligned with all previous i.MX SoCs' RTC implementation? If we disable it here, we have to enable it in all boards dtb. So if it is NOT very critical, is it OK to keep it enabled by default here? Thanks. Anson > > > Lothar Waßmann > -- > ___________________________________________________________ > > Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen > Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 > Geschäftsführer: Matthias Kaussen > Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 > > https://emea01.safelinks.protection.outlook.com/?url=www.karo-electronics.d > e&data=02%7C01%7Canson.huang%40nxp.com%7C12fb8e546a0e46d03 > 72408d65511a43f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C > 636789931600483807&sdata=SVZjpvYsi9XAM7CGt8sHZ5mt8rPRa%2FPl > 75EQvHTod%2Bg%3D&reserved=0 | info@karo-electronics.de > ___________________________________________________________
Best Regards! Anson Huang > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@bootlin.com] > Sent: 2018年11月28日 17:20 > To: Anson Huang <anson.huang@nxp.com> > Cc: Lothar Waßmann <LW@KARO-electronics.de>; a.zummo@towertech.it; > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com; > will.deacon@arm.com; Aisheng DONG <aisheng.dong@nxp.com>; Andy Gross > <andy.gross@linaro.org>; arnd@arndb.de; horms+renesas@verge.net.au; > heiko@sntech.de; bjorn.andersson@linaro.org; enric.balletbo@collabora.com; > amit.kucheria@linaro.org; ezequiel@collabora.com; olof@lixom.net; > shawnguo@kernel.org; linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > RTC support > > On 28/11/2018 09:06:27+0000, Anson Huang wrote: > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > > index 9155d45..ef57db6 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > > @@ -433,4 +433,8 @@ > > > > #size-cells = <1>; > > > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > > > > }; > > > > + > > > > + rtc: rtc { > > > > + compatible = "nxp,imx8qxp-sc-rtc"; > > > > + }; > > > > }; > > > IMO this should be disabled by default. > > > > This module is NOT depending on any board design, should it be enabled by > default in soc dtsi? > > Like wdog etc.. > > > > I guess the point is that you may not want it enabled, even if it should always > be working. enabling it by default would affect the RTC ordering for example. i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for all i.MX SoCs, so do we have to disable it here and enable it in board dts? Anson. > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootl > in.com&data=02%7C01%7Canson.huang%40nxp.com%7C0586fd10d6ff4 > 5d03f4308d65512a864%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > %7C636789935951215703&sdata=Hs1AXXoZMMKl8inOXFs8xXNXQ9EJG > gtphyTNhFvMiTE%3D&reserved=0
On 28/11/2018 09:21:56+0000, Anson Huang wrote: > > > This module is NOT depending on any board design, should it be enabled by > > default in soc dtsi? > > > Like wdog etc.. > > > > > > > I guess the point is that you may not want it enabled, even if it should always > > be working. enabling it by default would affect the RTC ordering for example. > > i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for all i.MX > SoCs, so do we have to disable it here and enable it in board dts? > I would say that most of the i.MX based boards include another RTC because the SoC one consumes way too much power. Note that I don't care too much whether it is enabled by default, I was simply explaining why you may want to disable it by default.
Best Regards! Anson Huang > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@bootlin.com] > Sent: 2018年11月28日 17:34 > To: Anson Huang <anson.huang@nxp.com> > Cc: Lothar Wa��mann <LW@KARO-electronics.de>; a.zummo@towertech.it; > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com; > will.deacon@arm.com; Aisheng DONG <aisheng.dong@nxp.com>; Andy Gross > <andy.gross@linaro.org>; arnd@arndb.de; horms+renesas@verge.net.au; > heiko@sntech.de; bjorn.andersson@linaro.org; enric.balletbo@collabora.com; > amit.kucheria@linaro.org; ezequiel@collabora.com; olof@lixom.net; > shawnguo@kernel.org; linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > RTC support > > On 28/11/2018 09:21:56+0000, Anson Huang wrote: > > > > This module is NOT depending on any board design, should it be > > > > enabled by > > > default in soc dtsi? > > > > Like wdog etc.. > > > > > > > > > > I guess the point is that you may not want it enabled, even if it > > > should always be working. enabling it by default would affect the RTC > ordering for example. > > > > i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for > > all i.MX SoCs, so do we have to disable it here and enable it in board dts? > > > > I would say that most of the i.MX based boards include another RTC because > the SoC one consumes way too much power. > > Note that I don't care too much whether it is enabled by default, I was simply > explaining why you may want to disable it by default. OK, this system controller RTC is a little different, it is controlled by system controller firmware, and system controller firmware will always select the best one for its user(Linux kernel) if there are other RTCs available, so I think we can keep it enabled by default for now. Thanks. Anson. > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootl > in.com&data=02%7C01%7Canson.huang%40nxp.com%7C5be6d014f2a5 > 4876cc9408d65514eaf3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C > 0%7C636789945664646785&sdata=MW0xy3cUhCLBTrEFkk4vAylxSAwB > mx1Ws6ZeEhAsdME%3D&reserved=0
On 28/11/2018 09:41:22+0000, Anson Huang wrote: > > > i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for > > > all i.MX SoCs, so do we have to disable it here and enable it in board dts? > > > > > > > I would say that most of the i.MX based boards include another RTC because > > the SoC one consumes way too much power. > > > > Note that I don't care too much whether it is enabled by default, I was simply > > explaining why you may want to disable it by default. > > OK, this system controller RTC is a little different, it is controlled by system controller firmware, > and system controller firmware will always select the best one for its user(Linux kernel) if there are other > RTCs available, so I think we can keep it enabled by default for now. Thanks. > Do you mean that the plan is to push support for the external RTCs (e.g. the i2c ones) to the M4 firmware?
Best Regards! Anson Huang > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@bootlin.com] > Sent: 2018年11月28日 17:58 > To: Anson Huang <anson.huang@nxp.com> > Cc: Lothar Wa��mann <LW@KARO-electronics.de>; a.zummo@towertech.it; > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com; > will.deacon@arm.com; Aisheng DONG <aisheng.dong@nxp.com>; Andy Gross > <andy.gross@linaro.org>; arnd@arndb.de; horms+renesas@verge.net.au; > heiko@sntech.de; bjorn.andersson@linaro.org; enric.balletbo@collabora.com; > amit.kucheria@linaro.org; ezequiel@collabora.com; olof@lixom.net; > shawnguo@kernel.org; linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > RTC support > > On 28/11/2018 09:41:22+0000, Anson Huang wrote: > > > > i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default > > > > for all i.MX SoCs, so do we have to disable it here and enable it in board > dts? > > > > > > > > > > I would say that most of the i.MX based boards include another RTC > > > because the SoC one consumes way too much power. > > > > > > Note that I don't care too much whether it is enabled by default, I > > > was simply explaining why you may want to disable it by default. > > > > OK, this system controller RTC is a little different, it is controlled > > by system controller firmware, and system controller firmware will > > always select the best one for its user(Linux kernel) if there are other RTCs > available, so I think we can keep it enabled by default for now. Thanks. > > > > Do you mean that the plan is to push support for the external RTCs (e.g. > the i2c ones) to the M4 firmware? As far as I know, currently there is no such plan/support in system controller (M4) firmware, and if there are external RTCs, like some PMICs have RTC inside, yes, M4 will control it and Linux kernel (AP) does NOT need to care about which RTC is used, same IPC API will be used I think. Anson. > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootl > in.com&data=02%7C01%7Canson.huang%40nxp.com%7C015fe8a15f364 > 066a6a608d655181d03%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C > 0%7C636789959398815495&sdata=wmgVepaMjZyc7dJQ0x8cLSaQUlshs > 6jKCjBdgC4FoYg%3D&reserved=0
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi index 9155d45..ef57db6 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi @@ -433,4 +433,8 @@ #size-cells = <1>; ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; }; + + rtc: rtc { + compatible = "nxp,imx8qxp-sc-rtc"; + }; };
Add i.MX8QXP system controller RTC support. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++ 1 file changed, 4 insertions(+)