| Message ID | 1547041383-16924-1-git-send-email-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | be6a95a55a095686455307d9437a9a25cf0233ef |
| Headers | show |
| Series | ARM: dts: s5pv210: Fix onenand's unit address format warning | expand |
Dnia środa, 9 stycznia 2019 14:43:03 CET Krzysztof Kozlowski pisze: > According to Devicetree specification, the unit-address must match the > first address specified in the reg property of the node. Fix the DTC > warning onenand node: > > arch/arm/boot/dts/s5pv210.dtsi:81.29-93.5: > Warning (simple_bus_reg): /soc/onenand@b0000000: simple-bus unit address format error, expected "b0600000" > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > The remaining warning is wrong clock-controller subnode of fimc camera. > arch/arm/boot/dts/s5pv210.dtsi:578.32-580.6: Warning (simple_bus_reg): /soc/camera/clock-controller: missing or empty reg/ranges property > The subnode in my understanding does not follow bindings and the driver. > The driver with current s5pv210.dtsi will not register a clock provider... but > I do not have a device to confirm this. > --- > arch/arm/boot/dts/s5pv210.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > index cc22c9db80d2..26ea5c66d8ce 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -78,7 +78,7 @@ > }; > }; > > - onenand: onenand@b0000000 { > + onenand: onenand@b0600000 { > compatible = "samsung,s5pv210-onenand"; > reg = <0xb0600000 0x2000>, > <0xb0000000 0x20000>, > Checked on Samsung Galaxy S (with local, not yet submited patches for devicetree support for onenand, which is missing in mainline) and it looks ok (device probed, was able to use ubi tools). Tested-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index cc22c9db80d2..26ea5c66d8ce 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -78,7 +78,7 @@ }; }; - onenand: onenand@b0000000 { + onenand: onenand@b0600000 { compatible = "samsung,s5pv210-onenand"; reg = <0xb0600000 0x2000>, <0xb0000000 0x20000>,
According to Devicetree specification, the unit-address must match the first address specified in the reg property of the node. Fix the DTC warning onenand node: arch/arm/boot/dts/s5pv210.dtsi:81.29-93.5: Warning (simple_bus_reg): /soc/onenand@b0000000: simple-bus unit address format error, expected "b0600000" Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- The remaining warning is wrong clock-controller subnode of fimc camera. arch/arm/boot/dts/s5pv210.dtsi:578.32-580.6: Warning (simple_bus_reg): /soc/camera/clock-controller: missing or empty reg/ranges property The subnode in my understanding does not follow bindings and the driver. The driver with current s5pv210.dtsi will not register a clock provider... but I do not have a device to confirm this. --- arch/arm/boot/dts/s5pv210.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)