| Message ID | 1547617457-60066-1-git-send-email-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 722f761084bd1e1a26ba096b48ba8c09048413a1 |
| Headers | show |
| Series | [-next] soc: bcm: bcm2835-pm: Make local symbol static | expand |
Looks good. On 2019-01-15 9:44 p.m., Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/soc/bcm/bcm2835-power.c:556:32: warning: > symbol 'bcm2835_reset_ops' was not declared. Should it be static? > > Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Acked-by: Scott Branden <scott.branden@broadcom.com> > --- > drivers/soc/bcm/bcm2835-power.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c > index 4841295..9351349 100644 > --- a/drivers/soc/bcm/bcm2835-power.c > +++ b/drivers/soc/bcm/bcm2835-power.c > @@ -553,7 +553,7 @@ static int bcm2835_reset_status(struct reset_controller_dev *rcdev, > } > } > > -const struct reset_control_ops bcm2835_reset_ops = { > +static const struct reset_control_ops bcm2835_reset_ops = { > .reset = bcm2835_reset_reset, > .status = bcm2835_reset_status, > }; > > >
On Wed, 16 Jan 2019 05:44:17 +0000, Wei Yongjun <weiyongjun1@huawei.com> wrote: > Fixes the following sparse warning: > > drivers/soc/bcm/bcm2835-power.c:556:32: warning: > symbol 'bcm2835_reset_ops' was not declared. Should it be static? > > Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- Applied to drivers/next, thanks! -- Florian
diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c index 4841295..9351349 100644 --- a/drivers/soc/bcm/bcm2835-power.c +++ b/drivers/soc/bcm/bcm2835-power.c @@ -553,7 +553,7 @@ static int bcm2835_reset_status(struct reset_controller_dev *rcdev, } } -const struct reset_control_ops bcm2835_reset_ops = { +static const struct reset_control_ops bcm2835_reset_ops = { .reset = bcm2835_reset_reset, .status = bcm2835_reset_status, };
Fixes the following sparse warning: drivers/soc/bcm/bcm2835-power.c:556:32: warning: symbol 'bcm2835_reset_ops' was not declared. Should it be static? Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/soc/bcm/bcm2835-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)