| Message ID | 1548353060-4900-1-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | f494caa480f7089ff9bba16dd865e190cee7e545 |
| Headers | show |
| Series | [V2] soc: bcm: Make PM driver default for BCM2835 | expand |
Stefan Wahren <stefan.wahren@i2se.com> writes: > Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the > PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. > > Otherwise the driver won't probe and HDMI output stays black: > vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Reviewed-by: Eric Anholt <eric@anholt.net>
On 2019-01-24 10:15 a.m., Eric Anholt wrote: > Stefan Wahren <stefan.wahren@i2se.com> writes: > >> Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the >> PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. >> >> Otherwise the driver won't probe and HDMI output stays black: >> vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver >> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > Reviewed-by: Eric Anholt <eric@anholt.net> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> Eric Anholt <eric@anholt.net> hat am 24. Januar 2019 um 19:15 geschrieben: > > > Stefan Wahren <stefan.wahren@i2se.com> writes: > > > Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the > > PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. > > > > Otherwise the driver won't probe and HDMI output stays black: > > vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver > > > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > > Reviewed-by: Eric Anholt <eric@anholt.net> I allowed me to applied this to bcm2835-drivers-next. Please feel to prepare the pull requests for Florian. Thanks Stefan
diff --git a/drivers/soc/bcm/Kconfig b/drivers/soc/bcm/Kconfig index fe1af29..03fa91f 100644 --- a/drivers/soc/bcm/Kconfig +++ b/drivers/soc/bcm/Kconfig @@ -3,6 +3,7 @@ menu "Broadcom SoC drivers" config BCM2835_POWER bool "BCM2835 power domain driver" depends on ARCH_BCM2835 || (COMPILE_TEST && OF) + default y if ARCH_BCM2835 select PM_GENERIC_DOMAINS if PM select RESET_CONTROLLER help
Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. Otherwise the driver won't probe and HDMI output stays black: vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- drivers/soc/bcm/Kconfig | 1 + 1 file changed, 1 insertion(+) Changes in V2: - make driver default for BCM2835 instead of selecting in platform Kconfig as suggested by Scott Branden