| Message ID | 1550005119-25750-2-git-send-email-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V2,1/4] drivers/perf: imx_ddr: Add ddr performance counter support | expand |
On Tue, Feb 12, 2019 at 6:59 PM Frank Li <frank.li@nxp.com> wrote: > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > index 4c3dd95..243d7b3 100644 > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > @@ -79,6 +79,13 @@ > interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>; > }; > > + ddr_pmu0: ddr_pmu@5c020000 { It seems you ignored the commend I made in the previous version. Here it goes again: Underscores should not be used in node names. You could use pmu@5c020000 instead.
On Tue, Feb 12, 2019 at 3:04 PM Fabio Estevam <festevam@gmail.com> wrote: > > On Tue, Feb 12, 2019 at 6:59 PM Frank Li <frank.li@nxp.com> wrote: > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > index 4c3dd95..243d7b3 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > @@ -79,6 +79,13 @@ > > interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>; > > }; > > > > + ddr_pmu0: ddr_pmu@5c020000 { > > It seems you ignored the commend I made in the previous version. > > Here it goes again: > > Underscores should not be used in node names. You could use > pmu@5c020000 instead. Sorry, I missed this. how about ddr-pmu0 pmu is already used by arm pmu best regards Frank Li
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi index 4c3dd95..243d7b3 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi @@ -79,6 +79,13 @@ interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>; }; + ddr_pmu0: ddr_pmu@5c020000 { + compatible = "fsl,imx8-ddr-pmu"; + reg = <0x0 0x5c020000 0x0 0x10000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>; + }; + psci { compatible = "arm,psci-1.0"; method = "smc";
Add ddr performance monitor Signed-off-by: Frank Li <Frank.Li@nxp.com> --- No change from v1 to v2 arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)