From patchwork Wed Feb 13 14:55:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Hao X-Patchwork-Id: 10809175 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6884B6C2 for ; Wed, 13 Feb 2019 06:34:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B9BD2A716 for ; Wed, 13 Feb 2019 06:34:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3ED652A757; Wed, 13 Feb 2019 06:34:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=2.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E11C02A716 for ; Wed, 13 Feb 2019 06:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=CKYn1XoapsuXTJUhr3bxxcYMB+Z5EFSj2kSNxjHGyBo=; b=bOl NbECrKtZSEvBE6Lh4EaESyVjEUMk4EKw5rPvnaKHui/4+hGDxhyG5SziA5YO3E94ySftg8+7bS/Je C+xBO/VzW+qwYqhsDfRTEYhDbl7ocEcSi0p7AhVrlPzZjdpPVU5+5aF873cQtvRsybVIzV+0P/jpD Ia52IrqFADcbfY/OjEZ1Gl+y7MMp/T77zfu/yl5fgy8b3GBz2OzG+w3Jk0iCZhwJlog9xqimjfQjO FPI6MYqjP/jq3Z9L49V1IZke0qO6kT0XjPCf4Vg2TzYBg8MBWmtPu6ZoVo2hwRvMERFh0hHtawpzn hWMcxmzhp56/v3sV56PEiGqvHuIfvbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gto7l-00074d-M7; Wed, 13 Feb 2019 06:34:25 +0000 Received: from out1.zte.com.cn ([202.103.147.172] helo=mxct.zte.com.cn) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gto7i-00073g-Be for linux-arm-kernel@lists.infradead.org; Wed, 13 Feb 2019 06:34:24 +0000 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id DD67150848972F7E1E0C; Wed, 13 Feb 2019 14:34:10 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id x1D6Y5mP041722; Wed, 13 Feb 2019 14:34:05 +0800 (GMT-8) (envelope-from peng.hao2@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.74.120.59]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019021314342732-25844473 ; Wed, 13 Feb 2019 14:34:27 +0800 From: Peng Hao To: nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com Subject: [PATCH] arm/mach-at91/pm : fix possible object reference leak Date: Wed, 13 Feb 2019 22:55:46 +0800 Message-Id: <1550069746-85671-1-git-send-email-peng.hao2@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-02-13 14:34:27, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-02-13 14:33:58, Serialize complete at 2019-02-13 14:33:58 X-MAIL: mse01.zte.com.cn x1D6Y5mP041722 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190212_223422_561032_426240FF X-CRM114-Status: GOOD ( 11.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Hao , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP of_find_device_by_node() takes a reference to the struct device when it finds a match via get_device. When returning error we should call put_device. Signed-off-by: Peng Hao --- arch/arm/mach-at91/pm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 51e808a..70fadb7 100644 --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c @@ -621,6 +621,7 @@ static int __init at91_pm_backup_init(void) securam_fail: iounmap(pm_data.sfrbu); + put_device(&pdev->dev); pm_data.sfrbu = NULL; return ret; }