| Message ID | 1550073243-11242-2-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V3,1/2] arm64: dts: freescale: imx8qxp: add cpu opp table | expand |
Quoting Anson Huang (2019-02-13 07:59:32) > @@ -145,6 +161,39 @@ static long clk_scu_round_rate(struct clk_hw *hw, unsigned long rate, > return rate; > } > > +static bool clk_scu_atf_set_cpu_rate(struct clk_hw *hw, unsigned long rate) > +{ > + struct clk_scu *clk = to_clk_scu(hw); > + struct arm_smccc_res res; > + unsigned int cluster_id; > + int i; > + > + /* CPU frequency scaling can ONLY be done by ARM-Trusted-Firmware */ > + if (clk->clk_type == IMX_SC_PM_CLK_CPU) { > + for (i = 0; i < ARRAY_SIZE(imx_sc_cpufreq_data); i++) { > + if (!strcmp(clk_hw_get_name(hw), > + imx_sc_cpufreq_data[i].clk_name)) { > + cluster_id = imx_sc_cpufreq_data[i].cluster_id; > + break; > + } > + } Is there some reason why these clks can't be determined once at boot time? It would be a good idea to avoid doing any sort of string comparison here, instead just calling the right arm_smccc_smc with the right arguments based on code that registers those types of clks.
Best Regards! Anson Huang > -----Original Message----- > From: Stephen Boyd [mailto:sboyd@kernel.org] > Sent: 2019年2月14日 1:43 > To: devicetree@vger.kernel.org; festevam@gmail.com; > kernel@pengutronix.de; linux-arm-kernel@lists.infradead.org; linux- > clk@vger.kernel.org; linux-kernel@vger.kernel.org; mark.rutland@arm.com; > mturquette@baylibre.com; robh+dt@kernel.org; s.hauer@pengutronix.de; > shawnguo@kernel.org; viresh.kumar@linaro.org; Aisheng Dong > <aisheng.dong@nxp.com>; Anson Huang <anson.huang@nxp.com>; Daniel > Baluta <daniel.baluta@nxp.com> > Cc: dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V3 2/2] clk: imx: scu: add cpu frequency scaling support > > Quoting Anson Huang (2019-02-13 07:59:32) > > @@ -145,6 +161,39 @@ static long clk_scu_round_rate(struct clk_hw *hw, > unsigned long rate, > > return rate; > > } > > > > +static bool clk_scu_atf_set_cpu_rate(struct clk_hw *hw, unsigned long > > +rate) { > > + struct clk_scu *clk = to_clk_scu(hw); > > + struct arm_smccc_res res; > > + unsigned int cluster_id; > > + int i; > > + > > + /* CPU frequency scaling can ONLY be done by ARM-Trusted-Firmware > */ > > + if (clk->clk_type == IMX_SC_PM_CLK_CPU) { > > + for (i = 0; i < ARRAY_SIZE(imx_sc_cpufreq_data); i++) { > > + if (!strcmp(clk_hw_get_name(hw), > > + imx_sc_cpufreq_data[i].clk_name)) { > > + cluster_id = imx_sc_cpufreq_data[i].cluster_id; > > + break; > > + } > > + } > > Is there some reason why these clks can't be determined once at boot time? > It would be a good idea to avoid doing any sort of string comparison here, > instead just calling the right arm_smccc_smc with the right arguments based > on code that registers those types of clks. Agree, I can avoid string comparison in runtime, in V4 patch I just sent, I add another clk ops for CPU clock, and use resource ID to determine the CPU clk ops and cluster id, thus we can save the runtime check and string comparison. Thanks, Anson.
diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index 7ccf7ed..885bf33 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -4,14 +4,30 @@ * Dong Aisheng <aisheng.dong@nxp.com> */ +#include <linux/arm-smccc.h> #include <linux/clk-provider.h> #include <linux/err.h> #include <linux/slab.h> #include "clk-scu.h" +#define IMX_SIP_CPUFREQ 0xC2000001 +#define IMX_SIP_SET_CPUFREQ 0x00 + static struct imx_sc_ipc *ccm_ipc_handle; +struct imx_sc_cpufreq { + const char *clk_name; + u32 cluster_id; +}; + +static const struct imx_sc_cpufreq imx_sc_cpufreq_data[] = { + { + .clk_name = "a35_clk", + .cluster_id = 0, + }, +}; + /* * struct clk_scu - Description of one SCU clock * @hw: the common clk_hw @@ -145,6 +161,39 @@ static long clk_scu_round_rate(struct clk_hw *hw, unsigned long rate, return rate; } +static bool clk_scu_atf_set_cpu_rate(struct clk_hw *hw, unsigned long rate) +{ + struct clk_scu *clk = to_clk_scu(hw); + struct arm_smccc_res res; + unsigned int cluster_id; + int i; + + /* CPU frequency scaling can ONLY be done by ARM-Trusted-Firmware */ + if (clk->clk_type == IMX_SC_PM_CLK_CPU) { + for (i = 0; i < ARRAY_SIZE(imx_sc_cpufreq_data); i++) { + if (!strcmp(clk_hw_get_name(hw), + imx_sc_cpufreq_data[i].clk_name)) { + cluster_id = imx_sc_cpufreq_data[i].cluster_id; + break; + } + } + + /* + * As some other clock types have same value as + * IMX_SC_PM_CLK_CPU, so we need to double check + * the clock being scaled is indeed CPU clock which + * matches the table we define. + */ + if (i < ARRAY_SIZE(imx_sc_cpufreq_data)) { + arm_smccc_smc(IMX_SIP_CPUFREQ, IMX_SIP_SET_CPUFREQ, + cluster_id, rate, 0, 0, 0, 0, &res); + return true; + } + } + + return false; +} + /* * clk_scu_set_rate - Set rate for a SCU clock * @hw: clock to change rate for @@ -161,6 +210,10 @@ static int clk_scu_set_rate(struct clk_hw *hw, unsigned long rate, struct imx_sc_msg_req_set_clock_rate msg; struct imx_sc_rpc_msg *hdr = &msg.hdr; + /* check if it is CPU frequency scaling */ + if (clk_scu_atf_set_cpu_rate(hw, rate)) + return 0; + hdr->ver = IMX_SC_RPC_VERSION; hdr->svc = IMX_SC_RPC_SVC_PM; hdr->func = IMX_SC_PM_FUNC_SET_CLOCK_RATE;
On NXP's i.MX SoCs with system controller inside, CPU frequency scaling can ONLY be done by system controller firmware, and it can ONLY be requested from secure mode, so Linux kernel has to call ARM SMC to trap to ARM-Trusted-Firmware to request system controller firmware to do CPU frequency scaling. This patch adds i.MX system controller CPU frequency scaling support, it reuses cpufreq-dt driver and implement the CPU frequency scaling inside SCU clock driver. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V2: - remove ifdef CONFIG_CPUFREQ_DT as it is NOT that critical and has mistake in V2; - put the CPU clock check and SMC call in a separate function. -- drivers/clk/imx/clk-scu.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+)