| Message ID | 1554099427-5240-1-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 358b9d248a026d7d0f5ea21b04480b715da0d425 |
| Headers | show |
| Series | irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code | expand |
On 4/1/2019 11:51 AM, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > --- > drivers/irqchip/irq-imx-irqsteer.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c > index 88df3d00..290531e 100644 > --- a/drivers/irqchip/irq-imx-irqsteer.c > +++ b/drivers/irqchip/irq-imx-irqsteer.c > @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct platform_device *pdev) > { > struct device_node *np = pdev->dev.of_node; > struct irqsteer_data *data; > - struct resource *res; > u32 irqs_num; > int i, ret; > > @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct platform_device *pdev) > if (!data) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - data->regs = devm_ioremap_resource(&pdev->dev, res); > + data->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(data->regs)) { > dev_err(&pdev->dev, "failed to initialize reg\n"); > return PTR_ERR(data->regs);
Ping... > -----Original Message----- > From: Mukesh Ojha [mailto:mojha@codeaurora.org] > Sent: Monday, April 1, 2019 3:47 PM > To: Anson Huang <anson.huang@nxp.com>; tglx@linutronix.de; > jason@lakedaemon.net; marc.zyngier@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Cc: dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH] irqchip/imx-irqsteer: use > devm_platform_ioremap_resource() to simplify code > > > On 4/1/2019 11:51 AM, Anson Huang wrote: > > Use the new helper devm_platform_ioremap_resource() which wraps the > > platform_get_resource() and devm_ioremap_resource() together, to > > simplify the code. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> > > Cheers, > -Mukesh > > --- > > drivers/irqchip/irq-imx-irqsteer.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/irqchip/irq-imx-irqsteer.c > > b/drivers/irqchip/irq-imx-irqsteer.c > > index 88df3d00..290531e 100644 > > --- a/drivers/irqchip/irq-imx-irqsteer.c > > +++ b/drivers/irqchip/irq-imx-irqsteer.c > > @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct > platform_device *pdev) > > { > > struct device_node *np = pdev->dev.of_node; > > struct irqsteer_data *data; > > - struct resource *res; > > u32 irqs_num; > > int i, ret; > > > > @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct > platform_device *pdev) > > if (!data) > > return -ENOMEM; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - data->regs = devm_ioremap_resource(&pdev->dev, res); > > + data->regs = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(data->regs)) { > > dev_err(&pdev->dev, "failed to initialize reg\n"); > > return PTR_ERR(data->regs);
On Sun, 28 Apr 2019 07:28:20 +0100, Anson Huang <anson.huang@nxp.com> wrote: > > Ping... I'm still building the 5.2 branch, no need to panic just yet. Thanks, M. > > > -----Original Message----- > > From: Mukesh Ojha [mailto:mojha@codeaurora.org] > > Sent: Monday, April 1, 2019 3:47 PM > > To: Anson Huang <anson.huang@nxp.com>; tglx@linutronix.de; > > jason@lakedaemon.net; marc.zyngier@arm.com; shawnguo@kernel.org; > > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > > Cc: dl-linux-imx <linux-imx@nxp.com> > > Subject: Re: [PATCH] irqchip/imx-irqsteer: use > > devm_platform_ioremap_resource() to simplify code > > > > > > On 4/1/2019 11:51 AM, Anson Huang wrote: > > > Use the new helper devm_platform_ioremap_resource() which wraps the > > > platform_get_resource() and devm_ioremap_resource() together, to > > > simplify the code. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> > > > > Cheers, > > -Mukesh > > > --- > > > drivers/irqchip/irq-imx-irqsteer.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/drivers/irqchip/irq-imx-irqsteer.c > > > b/drivers/irqchip/irq-imx-irqsteer.c > > > index 88df3d00..290531e 100644 > > > --- a/drivers/irqchip/irq-imx-irqsteer.c > > > +++ b/drivers/irqchip/irq-imx-irqsteer.c > > > @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct > > platform_device *pdev) > > > { > > > struct device_node *np = pdev->dev.of_node; > > > struct irqsteer_data *data; > > > - struct resource *res; > > > u32 irqs_num; > > > int i, ret; > > > > > > @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct > > platform_device *pdev) > > > if (!data) > > > return -ENOMEM; > > > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > - data->regs = devm_ioremap_resource(&pdev->dev, res); > > > + data->regs = devm_platform_ioremap_resource(pdev, 0); > > > if (IS_ERR(data->regs)) { > > > dev_err(&pdev->dev, "failed to initialize reg\n"); > > > return PTR_ERR(data->regs);
diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c index 88df3d00..290531e 100644 --- a/drivers/irqchip/irq-imx-irqsteer.c +++ b/drivers/irqchip/irq-imx-irqsteer.c @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; struct irqsteer_data *data; - struct resource *res; u32 irqs_num; int i, ret; @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct platform_device *pdev) if (!data) return -ENOMEM; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - data->regs = devm_ioremap_resource(&pdev->dev, res); + data->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(data->regs)) { dev_err(&pdev->dev, "failed to initialize reg\n"); return PTR_ERR(data->regs);
Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- drivers/irqchip/irq-imx-irqsteer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)