| Message ID | 1555217391-3552-3-git-send-email-hofrat@osadl.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3,RFC] ARM: mvebu: at least warn on kzalloc failure | expand |
On Sun, Apr 14, 2019 at 06:49:51AM +0200, Nicholas Mc Guire wrote: > The license is clearly identified as GPL V2 - so just add in the > appropriate SPDX license identifier. > > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Hi Nicholas Adding a SPDX line makes the license text redundant, so you should remove it in the same patch as adding the SPDX line. Andrew
On Sun, Apr 14, 2019 at 06:22:10PM +0200, Andrew Lunn wrote: > On Sun, Apr 14, 2019 at 06:49:51AM +0200, Nicholas Mc Guire wrote: > > The license is clearly identified as GPL V2 - so just add in the > > appropriate SPDX license identifier. > > > > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> > > Hi Nicholas > > Adding a SPDX line makes the license text redundant, so you should > remove it in the same patch as adding the SPDX line. > So remove that first line from this paragraph * This file is licensed under the terms of the GNU General Public * License version 2. This program is licensed "as is" without any * warranty of any kind, whether express or implied. reducing it to: * This program is licensed "as is" without any warranty of any kind, * whether express or implied. Is that what you are proposing ? The GPL does state that there is no warranty but using a different wording that may not be legally equivalent. thx! hofrat
diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c index 28fd256..0e021c9 100644 --- a/arch/arm/mach-mvebu/board-v7.c +++ b/arch/arm/mach-mvebu/board-v7.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Device Tree support for Armada 370 and XP platforms. *
The license is clearly identified as GPL V2 - so just add in the appropriate SPDX license identifier. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> --- Problem reported by checkpatch WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #1: FILE: arch/arm/mach-mvebu/board-v7.c:1: +/* Patch is against 5.1-rc4 (localversion-next is 20190412) arch/arm/mach-mvebu/board-v7.c | 1 + 1 file changed, 1 insertion(+)