| Message ID | 1555492863-88860-2-git-send-email-pgreco@centosproject.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: sun8i: v40 Rewrite BPi M2 Berry DTS based on BPi M2 Ultra | expand |
Hi, On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote: > When the GMAC support was added to the bananapi-m2-ultra, regulators > weren't tied to the pinctrl. Fix that. > > Signed-off-by: Pablo Greco <pgreco@centosproject.org> > --- > arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > index c488aaa..3da3598 100644 > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > @@ -201,6 +201,8 @@ > &pio { > pinctrl-names = "default"; > pinctrl-0 = <&clk_out_a_pin>; > + vcc-pa-supply = <®_aldo2>; You should list all the regulators that are needed for all the pin banks to operate properly, not just PA > + vcc-gmac-phy-supply = <®_dc1sw>; I'm not sure what that is supposed to do? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
El 17/4/19 a las 07:17, Maxime Ripard escribió: > Hi, > > On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote: >> When the GMAC support was added to the bananapi-m2-ultra, regulators >> weren't tied to the pinctrl. Fix that. >> >> Signed-off-by: Pablo Greco <pgreco@centosproject.org> >> --- >> arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts >> index c488aaa..3da3598 100644 >> --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts >> +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts >> @@ -201,6 +201,8 @@ >> &pio { >> pinctrl-names = "default"; >> pinctrl-0 = <&clk_out_a_pin>; >> + vcc-pa-supply = <®_aldo2>; > You should list all the regulators that are needed for all the pin > banks to operate properly, not just PA Ok, I "think" I finally understand what you mean, so according to schematics in https://drive.google.com/file/d/0B4PAo2nW2KfndFpmZG1OOWJ5NEU/view, it should look like this diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts index c488aaa..699579d 100644 --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts @@ -201,6 +201,12 @@ &pio { pinctrl-names = "default"; pinctrl-0 = <&clk_out_a_pin>; + vcc-pa-supply = <®_aldo2>; + vcc-pc-supply = <®_dcdc1>; + vcc-pd-supply = <®_dcdc1>; + vcc-pe-supply = <®_eldo1>; + vcc-pf-supply = <®_dcdc1>; + vcc-pg-supply = <®_dldo1>; }; ®_aldo2 {
Hi, On Thu, Apr 18, 2019 at 09:25:19AM -0300, Pablo Sebastián Greco wrote: > El 17/4/19 a las 07:17, Maxime Ripard escribió: > > On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote: > > > When the GMAC support was added to the bananapi-m2-ultra, regulators > > > weren't tied to the pinctrl. Fix that. > > > > > > Signed-off-by: Pablo Greco <pgreco@centosproject.org> > > > --- > > > arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > > > index c488aaa..3da3598 100644 > > > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > > > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > > > @@ -201,6 +201,8 @@ > > > &pio { > > > pinctrl-names = "default"; > > > pinctrl-0 = <&clk_out_a_pin>; > > > + vcc-pa-supply = <®_aldo2>; > > You should list all the regulators that are needed for all the pin > > banks to operate properly, not just PA > Ok, I "think" I finally understand what you mean, so according to schematics > in https://drive.google.com/file/d/0B4PAo2nW2KfndFpmZG1OOWJ5NEU/view, it > should look like this > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > index c488aaa..699579d 100644 > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > @@ -201,6 +201,12 @@ > &pio { > pinctrl-names = "default"; > pinctrl-0 = <&clk_out_a_pin>; > + vcc-pa-supply = <®_aldo2>; > + vcc-pc-supply = <®_dcdc1>; > + vcc-pd-supply = <®_dcdc1>; > + vcc-pe-supply = <®_eldo1>; > + vcc-pf-supply = <®_dcdc1>; > + vcc-pg-supply = <®_dldo1>; > }; That makes sense yep > ®_aldo2 { > -- > > I couldn't find vcc-pb, vcc-ph or vcc-pi. The R40 doesn't have them, so there's no suprise there :) (if you ever want to find that info again in the future, the various vcc-p* that you need to find are in the datasheet) > If this is ok, I'll generate a v4 based on v2, and throw v3 in the trash > where it belongs Sounds good, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts index c488aaa..3da3598 100644 --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts @@ -201,6 +201,8 @@ &pio { pinctrl-names = "default"; pinctrl-0 = <&clk_out_a_pin>; + vcc-pa-supply = <®_aldo2>; + vcc-gmac-phy-supply = <®_dc1sw>; }; ®_aldo2 {
When the GMAC support was added to the bananapi-m2-ultra, regulators weren't tied to the pinctrl. Fix that. Signed-off-by: Pablo Greco <pgreco@centosproject.org> --- arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++ 1 file changed, 2 insertions(+)