| Message ID | 1556117346-5608-1-git-send-email-fabien.dessenne@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mtd: rawnand: stm32_fmc2: manage the get_irq error case | expand |
On 4/24/19 4:49 PM, Fabien Dessenne wrote: > During probe, check the "get_irq" error value. > > Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com> Acked-by: Christophe Kerello <christophe.kerello@st.com> > --- > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > index 999ca6a..4aabea2 100644 > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > @@ -1909,6 +1909,12 @@ static int stm32_fmc2_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > + if (irq < 0) { > + if (irq != -EPROBE_DEFER) > + dev_err(dev, "IRQ error missing or invalid\n"); > + return irq; > + } > + > ret = devm_request_irq(dev, irq, stm32_fmc2_irq, 0, > dev_name(dev), fmc2); > if (ret) { >
Hi Fabien, Fabien Dessenne <fabien.dessenne@st.com> wrote on Wed, 24 Apr 2019 16:49:06 +0200: > During probe, check the "get_irq" error value. > > Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com> > --- > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > index 999ca6a..4aabea2 100644 > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > @@ -1909,6 +1909,12 @@ static int stm32_fmc2_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > + if (irq < 0) { > + if (irq != -EPROBE_DEFER) > + dev_err(dev, "IRQ error missing or invalid\n"); > + return irq; > + } > + > ret = devm_request_irq(dev, irq, stm32_fmc2_irq, 0, > dev_name(dev), fmc2); > if (ret) { Applied to nand/next. Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index 999ca6a..4aabea2 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -1909,6 +1909,12 @@ static int stm32_fmc2_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); + if (irq < 0) { + if (irq != -EPROBE_DEFER) + dev_err(dev, "IRQ error missing or invalid\n"); + return irq; + } + ret = devm_request_irq(dev, irq, stm32_fmc2_irq, 0, dev_name(dev), fmc2); if (ret) {
During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com> --- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 ++++++ 1 file changed, 6 insertions(+)