From patchwork Wed Apr 24 15:19:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabien DESSENNE X-Patchwork-Id: 10915047 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F38E161F for ; Wed, 24 Apr 2019 15:19:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5BE07285B8 for ; Wed, 24 Apr 2019 15:19:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4F69C28816; Wed, 24 Apr 2019 15:19:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E1BD1285B8 for ; Wed, 24 Apr 2019 15:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WjtVa5GR5w5TKF/n2agW+dF7P9PkaGVyK/AyG12rh9E=; b=L3igTyF6jDkaij vCXdGwdwwg8rrGuaZIX+5z5x5DPu7iVX43igLoPH+qpj0DipvodMGB0i8TnOfdfekU12AyiYCJxSm hUYPGRYOKhgbXQQXbU5ti7Hi0uGBte8CjTX9OwVYhOVJjF5symIa+f3+AS365I0AbJ0Z7Qtc38WH0 DG1mo85eIyVH+NoTBShrl61g+UJfp1Uhfz+Er46Dn0WfpNI0tNvr0Xb2STSLUiXRzwo8Z3tLd4qRu 03B/YZw9z7Em88RyyLHFqFGB6+/CEOo2uh4VQKcZ6xiJzIFFihiWNDivIpCRJCwtzu1Z+cNw+NJF/ h8kbdZ1wgQh4T5wc9CaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJJg3-0004EM-Id; Wed, 24 Apr 2019 15:19:15 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJJg0-0004E1-1n for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2019 15:19:13 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3OFG4bg017755; Wed, 24 Apr 2019 17:19:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=STMicroelectronics; bh=KmHj9BJNTsMjihCbz69dy7mwpmwsOJzd/iH+JvmR26E=; b=eHQCBwjpnyB+zKEZzHlzscC6ukPdjAR3OEoorh10R5dSFdvoNT8Gk+6t6iul559F6eli gpBxmT60bezD+vBAqc6ZamQwvygil3zluOCwWnnvn6OJ8aCkv+cADI4sLUAzoPdFHQvN 4B3gqgUsyj91R2eLMuf14de+Bm0w5g7GOSCqVXzTqYMPkNwSukmEpaDl1SCIPa3v0fA7 i6GFzNuLgx8ixU6AlmNa5aQ1K0hI+Etqq/lwcL2ufsdYfk3yp8vGiFQaZWuyzksCulZN aRGr6D/2aT//8xSCAaKtWC6uFFvxBLjrYotomP2Duub/CMzFDSFooladjQRDyAEIwpcj dA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2ryrvxea79-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Apr 2019 17:19:06 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2941831; Wed, 24 Apr 2019 15:19:06 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas21.st.com [10.75.90.44]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0A3F128FC; Wed, 24 Apr 2019 15:19:06 +0000 (GMT) Received: from SAFEX1HUBCAS23.st.com (10.75.90.47) by SAFEX1HUBCAS21.st.com (10.75.90.44) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 24 Apr 2019 17:19:05 +0200 Received: from localhost (10.201.23.25) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Apr 2019 17:19:05 +0200 From: Fabien Dessenne To: Mark Brown , Maxime Coquelin , Alexandre Torgue , Ludovic Barre , Christophe KERELLO , , , , Subject: [PATCH] spi: stm32-qspi: manage the get_irq error case Date: Wed, 24 Apr 2019 17:19:00 +0200 Message-ID: <1556119140-3319-1-git-send-email-fabien.dessenne@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.201.23.25] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-24_09:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190424_081912_429324_57E5BE6E X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabien Dessenne Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne Acked-by: Ludovic Barre --- drivers/spi/spi-stm32-qspi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 11a89aa..42f8e3c 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); + if (irq < 0) { + if (irq != -EPROBE_DEFER) + dev_err(dev, "IRQ error missing or invalid\n"); + return irq; + } + ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0, dev_name(dev), qspi); if (ret) {