| Message ID | 1557912988-26758-4-git-send-email-stanley.chu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | scsi: ufs: Add error handling of Auto-Hibernate | expand |
> >Use re-factored ufshcd_is_auto_hibern8_supported() function in ufshcd_init() >instead to make code more cleaner. > >Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> Reviewed-by: Bean Huo <beanhuo@micron.com>
On 5/15/19 3:06 PM, Stanley Chu wrote: > Use re-factored ufshcd_is_auto_hibern8_supported() function > in ufshcd_init() instead to make code more cleaner. > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > drivers/scsi/ufs/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index e6a86223a0d4..17af157c2cc1 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -8340,7 +8340,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq) > UIC_LINK_HIBERN8_STATE); > > /* Set the default auto-hiberate idle timer value to 150 ms */ > - if (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT & !hba->ahit) { > + if (ufshcd_is_auto_hibern8_supported(hba) & !hba->ahit) { After fixing the typo in above line (as pointed by Avri in patch 1), feel free to add Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > hba->ahit = FIELD_PREP(UFSHCI_AHIBERN8_TIMER_MASK, 150) | > FIELD_PREP(UFSHCI_AHIBERN8_SCALE_MASK, 3); > } >
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index e6a86223a0d4..17af157c2cc1 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -8340,7 +8340,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq) UIC_LINK_HIBERN8_STATE); /* Set the default auto-hiberate idle timer value to 150 ms */ - if (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT & !hba->ahit) { + if (ufshcd_is_auto_hibern8_supported(hba) & !hba->ahit) { hba->ahit = FIELD_PREP(UFSHCI_AHIBERN8_TIMER_MASK, 150) | FIELD_PREP(UFSHCI_AHIBERN8_SCALE_MASK, 3); }
Use re-factored ufshcd_is_auto_hibern8_supported() function in ufshcd_init() instead to make code more cleaner. Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)