| Message ID | 1559229194-3036-2-git-send-email-Dave.Martin@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: Pointer Authentication and SVE support | expand |
On Thu, 30 May 2019 16:13:06 +0100 Dave Martin <Dave.Martin@arm.com> wrote: > update_headers.sh can break if the current working directory has a > funny name or if something odd is passed for LINUX_ROOT. Do you actually have spaces in your Linux path? ;-) > In the interest of cleanliness, quote where appropriate. > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> Looks alright to me: Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre. > --- > util/update_headers.sh | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/util/update_headers.sh b/util/update_headers.sh > index 2d93646..4ba1b9f 100755 > --- a/util/update_headers.sh > +++ b/util/update_headers.sh > @@ -11,17 +11,17 @@ if [ "$#" -ge 1 ] > then > LINUX_ROOT="$1" > else > - LINUX_ROOT=/lib/modules/$(uname -r)/source > + LINUX_ROOT="/lib/modules/$(uname -r)/source" > fi > > -if [ ! -d $LINUX_ROOT/include/uapi/linux ] > +if [ ! -d "$LINUX_ROOT/include/uapi/linux" ] > then > echo "$LINUX_ROOT does not seem to be valid Linux source tree." > echo "usage: $0 [path-to-Linux-source-tree]" > exit 1 > fi > > -cp $LINUX_ROOT/include/uapi/linux/kvm.h include/linux > +cp -- "$LINUX_ROOT/include/uapi/linux/kvm.h" include/linux > > for arch in arm arm64 mips powerpc x86 > do > @@ -30,6 +30,6 @@ do > arm64) KVMTOOL_PATH=arm/aarch64 ;; > *) KVMTOOL_PATH=$arch ;; > esac > - cp $LINUX_ROOT/arch/$arch/include/uapi/asm/kvm.h \ > - $KVMTOOL_PATH/include/asm > + cp -- "$LINUX_ROOT/arch/$arch/include/uapi/asm/kvm.h" \ > + "$KVMTOOL_PATH/include/asm" > done
On Fri, May 31, 2019 at 06:02:53PM +0100, Andre Przywara wrote: > On Thu, 30 May 2019 16:13:06 +0100 > Dave Martin <Dave.Martin@arm.com> wrote: > > > update_headers.sh can break if the current working directory has a > > funny name or if something odd is passed for LINUX_ROOT. > > Do you actually have spaces in your Linux path? ;-) No. I'm assuming that people using a fancy desktop need to call it "My Linux Kernel" in order to comprehend what it is though. (Only joking!) > > In the interest of cleanliness, quote where appropriate. > > > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> > > Looks alright to me: > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> [...] Thanks ---Dave
diff --git a/util/update_headers.sh b/util/update_headers.sh index 2d93646..4ba1b9f 100755 --- a/util/update_headers.sh +++ b/util/update_headers.sh @@ -11,17 +11,17 @@ if [ "$#" -ge 1 ] then LINUX_ROOT="$1" else - LINUX_ROOT=/lib/modules/$(uname -r)/source + LINUX_ROOT="/lib/modules/$(uname -r)/source" fi -if [ ! -d $LINUX_ROOT/include/uapi/linux ] +if [ ! -d "$LINUX_ROOT/include/uapi/linux" ] then echo "$LINUX_ROOT does not seem to be valid Linux source tree." echo "usage: $0 [path-to-Linux-source-tree]" exit 1 fi -cp $LINUX_ROOT/include/uapi/linux/kvm.h include/linux +cp -- "$LINUX_ROOT/include/uapi/linux/kvm.h" include/linux for arch in arm arm64 mips powerpc x86 do @@ -30,6 +30,6 @@ do arm64) KVMTOOL_PATH=arm/aarch64 ;; *) KVMTOOL_PATH=$arch ;; esac - cp $LINUX_ROOT/arch/$arch/include/uapi/asm/kvm.h \ - $KVMTOOL_PATH/include/asm + cp -- "$LINUX_ROOT/arch/$arch/include/uapi/asm/kvm.h" \ + "$KVMTOOL_PATH/include/asm" done
update_headers.sh can break if the current working directory has a funny name or if something odd is passed for LINUX_ROOT. In the interest of cleanliness, quote where appropriate. Signed-off-by: Dave Martin <Dave.Martin@arm.com> --- util/update_headers.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)