| Message ID | 1563290089-11085-3-git-send-email-aisheng.dong@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8: architecture improvement and adding imx8qm support | expand |
On Tue, Jul 16, 2019 at 12:37 PM Dong Aisheng <aisheng.dong@nxp.com> wrote: > > SCU clock depends on SCU Power domain. So let's move scu pd node > before scu clock to make it probe earlier. This looks like a fragile solution. Shouldn't this be handled via probe deferring?
On Wed, Jul 17, 2019 at 3:26 AM Fabio Estevam <festevam@gmail.com> wrote: > > On Tue, Jul 16, 2019 at 12:37 PM Dong Aisheng <aisheng.dong@nxp.com> wrote: > > > > SCU clock depends on SCU Power domain. So let's move scu pd node > > before scu clock to make it probe earlier. > > This looks like a fragile solution. Shouldn't this be handled via > probe deferring? Not like a normal case that there may be only a few devices may get deferred, for qm/qxp, almost all the devices (~100) may get deferred without this patch. e.g. scu clk, lpcg clk and all other devices which depend on clk. So i think it's really unnecessary to do that. Regards Aisheng
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi index af6d720..6177fad 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi @@ -138,6 +138,11 @@ &lsio_mu1 1 3 &lsio_mu1 3 3>; + pd: imx8qx-pd { + compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd"; + #power-domain-cells = <1>; + }; + clk: clock-controller { compatible = "fsl,imx8qxp-clk"; #clock-cells = <1>; @@ -155,11 +160,6 @@ #size-cells = <1>; }; - pd: imx8qx-pd { - compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd"; - #power-domain-cells = <1>; - }; - rtc: rtc { compatible = "fsl,imx8qxp-sc-rtc"; };
SCU clock depends on SCU Power domain. So let's move scu pd node before scu clock to make it probe earlier. Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: devicetree@vger.kernel.org Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- ChangeLog: v2: new patch --- arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)