Message ID | 1573459282-26989-2-git-send-email-bhsharma@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=vFb8=ZD=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F8DB1599 for <patchwork-linux-arm@patchwork.kernel.org>; Mon, 11 Nov 2019 08:04:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4385420818 for <patchwork-linux-arm@patchwork.kernel.org>; Mon, 11 Nov 2019 08:04:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MISbR7bt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ae2bnJsv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4385420818 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=XzYiSrSj95drSkyIVn/2gc7bePp28Ua00H9oYNFQH/I=; b=MISbR7btzK7/tBkpWn9hkEAqW5 nu61H0KGDwwqOgEKRcFzNkQPRAbPLuMHauf5Zi2AMrSO97QCfO/tP9Z5JWkB0iHRy5f3oqbfaOlKb uFy7LCh41zUKHIQ29Q6mDmgVXK5mwN1ksD2228OLQo6QGq9QZrpFP9aeiaRwPCpyWRc25dnCLFUx8 A1lGauKg12/JsClgG2TxDNiqLSFIQIQekBG5kzNIs/LH8aXZ/gNtTy5OrRn79IlP+qZRgPZbNDBF8 F8X5ArzT13Ae0nWf8K+ZBLHUvot16B8bK1IhtUTOFxsH+RGXfkXxQVILQcaoJ71zKMsgCwstgbkMi Iy9Bxjtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU4gF-0003eN-7P; Mon, 11 Nov 2019 08:04:11 +0000 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU4g7-0003bT-46 for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 08:04:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573459441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/y8p7TWJ4+9dx0qZYntYI0vqqca78jHSFlqFEn+6Y9I=; b=Ae2bnJsvuVP6avUPrVQ0dOl6YqAitaPPcAWAwEWRr3EfehY0J/D3Fz4OBVCEZ9BskGWArl wAE3ycLB0Z2vKndVaDrRRjUIer7HhfzRdueUueZNyRlM2fvyFWvcjhlp8G0zx6nNH752ky YOJBqZk7766T31j2divPgzXncdujEB8= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-GmCfQmb7OOOwKfl-hSwzFQ-1; Mon, 11 Nov 2019 03:01:45 -0500 Received: by mail-pl1-f198.google.com with SMTP id a5so10120879pln.13 for <linux-arm-kernel@lists.infradead.org>; Mon, 11 Nov 2019 00:01:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=D7Q1sNAJK7KGCeC1/osi4u/yd8LMbojW2DcAg7eyhwk=; b=JALCuT18H2jk6zohDzktYQDeI85h1nsXRq3sTkHnmo0cYIlVHxlVVxFxycSlpE6NkL CxyH7iWdIO591Twoj/MfwYXVu9LmehQ+RBALOJdvuA4kDxBVOrWM7cIpeGDOeh5I9tY7 EpECnOaCviIRmP0ptBHw9+7kL9YgXd4CrdHms7fULBWdxcIoHJyzTuVt/YMFCoLa3LOL YZC70RKfw21QyW505JUJKm5GkgQQLytjgxbOsXV2um1KRMTsfEz0H/wa/ATl3emJIj2p p4NX1nAmO+d7+GPo9ni8pwW/UWE6nC0Uf/5+cCAFJbap/kzPJYW9/yprM5QdlTvz/nn5 gnpA== X-Gm-Message-State: APjAAAXgmFL+J9WFjRlGgRHA1VVNx+muIj/xJSGY6X1u5CdHNePRvDZ3 nnb8KIAafUO/nol+4Dqa/od4qlHrsqO82fKvMMnJ4BvMzULU0XceWbVBUiTRoyj98pJ6UADcjfe 0sS8MBydv2UXpLEoF5voB6EHT++jX2ysw++M= X-Received: by 2002:a62:fcd2:: with SMTP id e201mr404507pfh.52.1573459301444; Mon, 11 Nov 2019 00:01:41 -0800 (PST) X-Google-Smtp-Source: APXvYqw/PM/uE1YEEDp1OQcYhDW64ur/c96jF9ficCBtta087Mx43bjXxmhjovhzV8sTDdZdS3kXpw== X-Received: by 2002:a62:fcd2:: with SMTP id e201mr404459pfh.52.1573459301055; Mon, 11 Nov 2019 00:01:41 -0800 (PST) Received: from localhost ([122.177.0.15]) by smtp.gmail.com with ESMTPSA id r33sm12736180pjb.5.2019.11.11.00.01.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Nov 2019 00:01:39 -0800 (PST) From: Bhupesh Sharma <bhsharma@redhat.com> To: linux-kernel@vger.kernel.org Subject: [PATCH v4 1/3] crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo Date: Mon, 11 Nov 2019 13:31:20 +0530 Message-Id: <1573459282-26989-2-git-send-email-bhsharma@redhat.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1573459282-26989-1-git-send-email-bhsharma@redhat.com> References: <1573459282-26989-1-git-send-email-bhsharma@redhat.com> X-MC-Unique: GmCfQmb7OOOwKfl-hSwzFQ-1 X-Mimecast-Spam-Score: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_000403_235929_49AFB086 X-CRM114-Status: GOOD ( 16.96 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [205.139.110.120 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Mark Rutland <mark.rutland@arm.com>, Kazuhito Hagio <k-hagio@ab.jp.nec.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Steve Capper <steve.capper@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, bhsharma@redhat.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>, kexec@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, James Morse <james.morse@arm.com>, linux-arm-kernel@lists.infradead.org, Michael Ellerman <mpe@ellerman.id.au>, Boris Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>, bhupesh.linux@gmail.com, Will Deacon <will@kernel.org>, Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>, Dave Anderson <anderson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org |
Series |
Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)
|
expand
|
diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 9f1557b98468..18175687133a 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -413,6 +413,7 @@ static int __init crash_save_vmcoreinfo_init(void) VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); VMCOREINFO_STRUCT_SIZE(mem_section); VMCOREINFO_OFFSET(mem_section, section_mem_map); + VMCOREINFO_NUMBER(MAX_PHYSMEM_BITS); #endif VMCOREINFO_STRUCT_SIZE(page); VMCOREINFO_STRUCT_SIZE(pglist_data);
Right now user-space tools like 'makedumpfile' and 'crash' need to rely on a best-guess method of determining value of 'MAX_PHYSMEM_BITS' supported by underlying kernel. This value is used in user-space code to calculate the bit-space required to store a section for SPARESMEM (similar to the existing calculation method used in the kernel implementation): #define SECTIONS_SHIFT (MAX_PHYSMEM_BITS - SECTION_SIZE_BITS) Now, regressions have been reported in user-space utilities like 'makedumpfile' and 'crash' on arm64, with the recently added kernel support for 52-bit physical address space, as there is no clear method of determining this value in user-space (other than reading kernel CONFIG flags). As per suggestion from makedumpfile maintainer (Kazu), it makes more sense to append 'MAX_PHYSMEM_BITS' to vmcoreinfo in the core code itself rather than in arch-specific code, so that the user-space code for other archs can also benefit from this addition to the vmcoreinfo and use it as a standard way of determining 'SECTIONS_SHIFT' value in user-land. A reference 'makedumpfile' implementation which reads the 'MAX_PHYSMEM_BITS' value from vmcoreinfo in a arch-independent fashion is available here: [0]. https://github.com/bhupesh-sharma/makedumpfile/blob/remove-max-phys-mem-bit-v1/arch/ppc64.c#L471 Cc: Boris Petkov <bp@alien8.de> Cc: Ingo Molnar <mingo@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: James Morse <james.morse@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Steve Capper <steve.capper@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Paul Mackerras <paulus@samba.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Dave Anderson <anderson@redhat.com> Cc: Kazuhito Hagio <k-hagio@ab.jp.nec.com> Cc: x86@kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com> --- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+)