clk: imx: clk-composite-7ulp: add lock

Commit Message

Peng Fan Nov. 21, 2019, 10:30 a.m. UTC

From: Peng Fan <[e-mail]>

Add lock to mux/gate/divider to protect the access to the register

Signed-off-by: Peng Fan <[e-mail]>
---
 drivers/clk/imx/clk-composite-7ulp.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Fabio Estevam Nov. 21, 2019, 4:46 p.m. UTC | #1

Hi Peng,

On Thu, Nov 21, 2019 at 7:30 AM Peng Fan <[e-mail]> wrote:
>
> From: Peng Fan <[e-mail]>
>
> Add lock to mux/gate/divider to protect the access to the register

The "access to the register" is too vague.

Could you please be more specific in the commit log and send a v2?

Thanks

Patch

diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
index 060f8600ea0d..d8c6e48207c5 100644
--- a/drivers/clk/imx/clk-composite-7ulp.c
+++ b/drivers/clk/imx/clk-composite-7ulp.c
@@ -41,6 +41,7 @@  struct clk_hw *imx7ulp_clk_composite(const char *name,
 		mux->reg = reg;
 		mux->shift = PCG_PCS_SHIFT;
 		mux->mask = PCG_PCS_MASK;
+		mux->lock = &imx_ccm_lock;
 	}
 
 	if (rate_present) {
@@ -58,6 +59,7 @@  struct clk_hw *imx7ulp_clk_composite(const char *name,
 		fd->nwidth = PCG_PCD_WIDTH;
 		fd->nmask = PCG_PCD_MASK;
 		fd->flags = CLK_FRAC_DIVIDER_ZERO_BASED;
+		fd->lock = &imx_ccm_lock;
 	}
 
 	if (gate_present) {
@@ -70,6 +72,7 @@  struct clk_hw *imx7ulp_clk_composite(const char *name,
 		gate_hw = &gate->hw;
 		gate->reg = reg;
 		gate->bit_idx = PCG_CGC_SHIFT;
+		gate->lock = &imx_ccm_lock;
 	}
 
 	hw = clk_hw_register_composite(NULL, name, parent_names, num_parents,