From patchwork Thu Nov 28 20:23:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh Sharma X-Patchwork-Id: 11266559 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 82CF615AB for ; Thu, 28 Nov 2019 20:24:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34AC321775 for ; Thu, 28 Nov 2019 20:24:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EgobIsNt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QC8uPqRs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34AC321775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=XzYiSrSj95drSkyIVn/2gc7bePp28Ua00H9oYNFQH/I=; b=EgobIsNtctXOa/YPnzr1ZOU6U6 VB8pGK/Le2Sb97VyJDwyltXsql4uGybXJy0fRh44RLanY+j8x5uze8253vSwj4y+EA53QVpPYiCVG lP4vt8tNcQ19drFl4ZEzfGAQptFiECPb4cAngSWkudEwvE8nsu+LDTZ5vz4MCm9OblG/7o9B0038B 1NJvXP1TEgLKjd3cbV7XsnkoYe/pVgCtgfrt6gPcA9v0ncH2s1099pSf/8dZ7pBXZkt+Ls3uOZOa5 EF1uurR1BNgPBeKIHZUfE3TKgTFSKbgdzkQUomC3ZZLWKKVJ7dkoduemY1hrLGz59tQ8jGYG7I4Kh a9BWa/jQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaQKt-0005d7-Qj; Thu, 28 Nov 2019 20:24:23 +0000 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaQKb-0005Mw-W8 for linux-arm-kernel@lists.infradead.org; Thu, 28 Nov 2019 20:24:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574972644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/y8p7TWJ4+9dx0qZYntYI0vqqca78jHSFlqFEn+6Y9I=; b=QC8uPqRsRsCLmvsV2ERymIaYn776KE0D3PuY4KJFlXnx7Z11zdromKo7V2MXHiy4hlKERd NT2doOhuMoQk24dEZ9vafmxub1cVGmPIckS/ZW3uCBVn77POwA+L/MKtXOkM32n6PrCbmZ fmuvfYYmBcoKq9w+6q3VqA/mvkCfEhw= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-110-HkJThyEANdG0jVnfYlRdSw-1; Thu, 28 Nov 2019 15:24:03 -0500 Received: by mail-pl1-f199.google.com with SMTP id d24so1474173pll.14 for ; Thu, 28 Nov 2019 12:24:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=D7Q1sNAJK7KGCeC1/osi4u/yd8LMbojW2DcAg7eyhwk=; b=f7DKbIIuo4CO9CNa+YL4Bf2PvjKG/GbqgiLe+pQGMR/YeGFaobrfVpR9xv3FqrfHA5 oRL8+/sfLpr4Y2zspuerjjnB7+75LGEHNxeDH+tv6YXvHY1xduSkMZxj3hDJucWdhkOn fA3zzjwsDF9o57ZFcYWwnhrG1+eqZM45x1uc5nlYxUdaIrPOPURkJwLF2lwUPKZiSPY1 kQzodp8AooRaQgc4RFqzOT3LxMS0NOMBwlrQlUI7EYfcjSF/YZ7ndLnkXio/HK5XS8ld OD23kRgFUsTSO9JsBohkP/yRumR/T5XWHgaRY3lFruHDW/+cjJNJDqdlfgwLU+2DymmU AErg== X-Gm-Message-State: APjAAAVfx7DGhDgB0/0L1v3ryGsQEL7LeUruK5a+WqUI1PKjC8yozE61 /jkdTlA1KV1vj86WTk4ptY4h2BECfLL53PqMn3L3RhBeydttU6Gi2lG+VptKapFse6+wrX+0QzM 0TAkrAFjJD1RHMuIDs1/dGMkSftEu/jmhb80= X-Received: by 2002:a17:90a:3663:: with SMTP id s90mr14556234pjb.1.1574972639196; Thu, 28 Nov 2019 12:23:59 -0800 (PST) X-Google-Smtp-Source: APXvYqwEBnny8bOGZ2sOhQL9nLkTVF0UqIXllrctdH9WVSgwdhpBSy3J7AMOGgxRJJki+CNRMtBZ+Q== X-Received: by 2002:a17:90a:3663:: with SMTP id s90mr14556206pjb.1.1574972638976; Thu, 28 Nov 2019 12:23:58 -0800 (PST) Received: from localhost ([122.177.85.74]) by smtp.gmail.com with ESMTPSA id s66sm22322578pfb.38.2019.11.28.12.23.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Nov 2019 12:23:58 -0800 (PST) From: Bhupesh Sharma To: linux-kernel@vger.kernel.org Subject: [PATCH v5 1/5] crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo Date: Fri, 29 Nov 2019 01:53:37 +0530 Message-Id: <1574972621-25750-2-git-send-email-bhsharma@redhat.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1574972621-25750-1-git-send-email-bhsharma@redhat.com> References: <1574972621-25750-1-git-send-email-bhsharma@redhat.com> X-MC-Unique: HkJThyEANdG0jVnfYlRdSw-1 X-Mimecast-Spam-Score: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191128_122406_164015_2AEBBF11 X-CRM114-Status: GOOD ( 17.42 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [205.139.110.120 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ard Biesheuvel , Benjamin Herrenschmidt , linux-doc@vger.kernel.org, Will Deacon , bhsharma@redhat.com, x86@kernel.org, kexec@lists.infradead.org, Dave Anderson , Paul Mackerras , Kazuhito Hagio , Boris Petkov , Michael Ellerman , Catalin Marinas , James Morse , Thomas Gleixner , bhupesh.linux@gmail.com, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , linux-arm-kernel@lists.infradead.org, Steve Capper MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Right now user-space tools like 'makedumpfile' and 'crash' need to rely on a best-guess method of determining value of 'MAX_PHYSMEM_BITS' supported by underlying kernel. This value is used in user-space code to calculate the bit-space required to store a section for SPARESMEM (similar to the existing calculation method used in the kernel implementation): #define SECTIONS_SHIFT (MAX_PHYSMEM_BITS - SECTION_SIZE_BITS) Now, regressions have been reported in user-space utilities like 'makedumpfile' and 'crash' on arm64, with the recently added kernel support for 52-bit physical address space, as there is no clear method of determining this value in user-space (other than reading kernel CONFIG flags). As per suggestion from makedumpfile maintainer (Kazu), it makes more sense to append 'MAX_PHYSMEM_BITS' to vmcoreinfo in the core code itself rather than in arch-specific code, so that the user-space code for other archs can also benefit from this addition to the vmcoreinfo and use it as a standard way of determining 'SECTIONS_SHIFT' value in user-land. A reference 'makedumpfile' implementation which reads the 'MAX_PHYSMEM_BITS' value from vmcoreinfo in a arch-independent fashion is available here: [0]. https://github.com/bhupesh-sharma/makedumpfile/blob/remove-max-phys-mem-bit-v1/arch/ppc64.c#L471 Cc: Boris Petkov Cc: Ingo Molnar Cc: Thomas Gleixner Cc: James Morse Cc: Mark Rutland Cc: Will Deacon Cc: Steve Capper Cc: Catalin Marinas Cc: Ard Biesheuvel Cc: Michael Ellerman Cc: Paul Mackerras Cc: Benjamin Herrenschmidt Cc: Dave Anderson Cc: Kazuhito Hagio Cc: x86@kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org Signed-off-by: Bhupesh Sharma --- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 9f1557b98468..18175687133a 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -413,6 +413,7 @@ static int __init crash_save_vmcoreinfo_init(void) VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); VMCOREINFO_STRUCT_SIZE(mem_section); VMCOREINFO_OFFSET(mem_section, section_mem_map); + VMCOREINFO_NUMBER(MAX_PHYSMEM_BITS); #endif VMCOREINFO_STRUCT_SIZE(page); VMCOREINFO_STRUCT_SIZE(pglist_data);