From patchwork Tue Dec 3 02:02:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 11270149 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 18AA7138C for ; Tue, 3 Dec 2019 02:02:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA8DE20684 for ; Tue, 3 Dec 2019 02:02:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m6uI0Szb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="acJMh89W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA8DE20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=abBku6x6HKVlaRSBGqXBOy3LnvKO6d02As9GSQX6Xes=; b=m6uI0Szb5+2TET 0AV8TyvM62EZgHnG3VC0KWRWmV4P5Mq2QEMOjSxar5/wdSPxYWPyuEIXxgEkArPSZ8NgjhPSMUJgF igcOCHs2KlvIBGGYE2+0odqf/6DNmYqA7n+TQSAi93eRvVzsQuPTDcxd9vHw/kFg7wr/PiYq+CKY4 0OzD7oGwCOM3obKSVaRGDo+zgmuUDB5EvxYgrjdmjZZI0Ip9rlw0GjPHCn51R7Z9omAXBoHqr3znk GmHPSv3aC0Anri4Q0G8IFG6rszj29DmGqDQ87sOdNioXuGofYp7B5+LuWeqyN5FOssvsjBcycLh60 zeZqJbda8JV2QZ0kOThw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibxWW-0007kT-G8; Tue, 03 Dec 2019 02:02:44 +0000 Received: from mail-eopbgr80053.outbound.protection.outlook.com ([40.107.8.53] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibxWT-0007ju-LB for linux-arm-kernel@lists.infradead.org; Tue, 03 Dec 2019 02:02:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Az94Avch12g2jQ26pTo/XJLWhscL2TpAnfdhTmwDHOHBukHPRO5mVmPZYX5qQXzNIqLjKQu6du1/LwhripZvEDFYK7Z3G4mdTm52unALO8jjpKsYlFWRMciPySE/gpqyj22xHLxPmHP3SVWUrwQKTMuTeS3Ww1N7mbhWa9FpYylEONNixEVSN8IFN07RoV2kUs4GWskHKhpLAFst5qCUq190Aj3KQlDWVp350Pl1shXkC0+K6KXQlml4Wn9+OaadObKfPkpWe8Yqbz7j945WwE1FehkwMhpJIZX09nty7qCqa7pstD0QK07RokhPZZwmB9SZ+Tod4k5WAkUHx6CDKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GGbcCCHNhSmL7RPRjMe2FpX229Cd7Hzol2ich7aW29o=; b=n1ysxc7vYCvigt/wah48VfntYyg7xEGGh0R/2jLN1/areH05klVYyOSUCaZRs8qii2U7pJ3J9mSYmoAD4VRPTnGsP1KWO5nbybfs4owBl3iFoi6PXw5+RiA9k+i95cf0VJtxidw7KsPvRcRiGNNwloL2Gf0C2mtaHnIDDjETunRTkHCAeleGc9bdIU5Mt8+3r5dNdjWwaO2k0sXYOgconihtvIYQcner6BXoCZg19JzHXh9fDJWEqvl0tLcauVg+K/L8sAtLn8wHgccRRht6ZIbyKOdxCrSXEeWVxLc0Ov2QXOh7xv6copfNF6jwKvy1UDZ9wdPPGFma6NRknFJlrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GGbcCCHNhSmL7RPRjMe2FpX229Cd7Hzol2ich7aW29o=; b=acJMh89WmARz+e6AbEC4W44aA7BxL4eqOStJDbpE4tH5pYBTFdCPTIsGLqYgKa0ZwX44oar3yGXD8OcTTh6RVX0ao/pofaEZMcR9SU4AWUNyNP3lXSfnf6VfYWjToNiU2MJU851B1MmSKjP5i14NNq+i2DMp1U9e/i8yl18u7i0= Received: from AM0PR04MB4481.eurprd04.prod.outlook.com (52.135.147.15) by AM0PR04MB6865.eurprd04.prod.outlook.com (52.132.213.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.17; Tue, 3 Dec 2019 02:02:37 +0000 Received: from AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::f16d:a26a:840:f97c]) by AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::f16d:a26a:840:f97c%4]) with mapi id 15.20.2495.014; Tue, 3 Dec 2019 02:02:37 +0000 From: Peng Fan To: "sboyd@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , Abel Vesa Subject: [PATCH V2] clk: imx: clk-composite-8m: add lock to gate/mux Thread-Topic: [PATCH V2] clk: imx: clk-composite-8m: add lock to gate/mux Thread-Index: AQHVqX28P68N2YUtS06IIycp0VIKnw== Date: Tue, 3 Dec 2019 02:02:37 +0000 Message-ID: <1575338427-22347-1-git-send-email-peng.fan@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK2PR02CA0203.apcprd02.prod.outlook.com (2603:1096:201:20::15) To AM0PR04MB4481.eurprd04.prod.outlook.com (2603:10a6:208:70::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e8e2c52f-6a08-47e1-791a-08d77794deca x-ms-traffictypediagnostic: AM0PR04MB6865:|AM0PR04MB6865: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 02408926C4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(136003)(346002)(39860400002)(396003)(199004)(189003)(25786009)(81166006)(6512007)(3846002)(81156014)(2906002)(305945005)(6116002)(6636002)(478600001)(71200400001)(71190400001)(26005)(66066001)(99286004)(66946007)(102836004)(36756003)(8676002)(52116002)(386003)(6506007)(66556008)(64756008)(66476007)(66446008)(54906003)(2201001)(44832011)(86362001)(8936002)(2501003)(2616005)(14444005)(5660300002)(256004)(186003)(4326008)(6486002)(14454004)(7736002)(6436002)(110136005)(50226002)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB6865; H:AM0PR04MB4481.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iCLXU12D60at2/dhHoQsHEYQE4h3cv2XCeP4tek8LOqL3T9rnUZfuS0nnaKeo4HAld+p55dLrel6IRbTRO9i8yN4E2zHM8Z9knIllTZmZjA6IyJHl2K6N3IUnt3rSJ9I79R0F83DecoG4EraUQnL5dUV93T6nCpUs+2uyWjOGoPEU25swhL8s3LqDjfw6PyurdfaA3anYEcGXLGs0wHe+xZiGD799bWuKzxgXtH5ahh5M0fKwlRUauESdhCuRIKhvAVz5vBJxKSIEJWXdPxHOhYmxKpYfyjewlWxPjepnCGDcaYZL9vXuVZLTKDhGiBskjiwBPIP9px5qlq6UlGgDc0/x26gwck+GaPNhGanadFL+cULvEPInnurXrv/522ZRSXjxdZ1c+Srd1u7OKNjnpNPGm1fA+OlExmFZUJ7Do9To7PimTGXJvPQ/QHAZxdE MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8e2c52f-6a08-47e1-791a-08d77794deca X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2019 02:02:37.6978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XsPmB/9gKuGEw8Nh0VYfBdOxoFh1aFsJxQfq2C1a20dVLvkZ/HQgh7zIgpbsd4q2245COecVCYOMs8DmNotiYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6865 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_180241_695621_B32EA72F X-CRM114-Status: UNSURE ( 9.71 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.8.53 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Fan , Jacky Bai , Anson Huang , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Leonard Crestez , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Peng Fan There is a lock to divider in the composite driver, but that's not enough. lock to gate/mux are also needed to provide exclusive access to the register. Fixes: d3ff9728134e ("clk: imx: Add imx composite clock") Reviewed-by: Abel Vesa Acked-by: Shawn Guo Signed-off-by: Peng Fan --- V2: Add Shawn's tag and typo fix. drivers/clk/imx/clk-composite-8m.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-composite-8m.c index e0f25983e80f..20f7c91c03d2 100644 --- a/drivers/clk/imx/clk-composite-8m.c +++ b/drivers/clk/imx/clk-composite-8m.c @@ -142,6 +142,7 @@ struct clk_hw *imx8m_clk_hw_composite_flags(const char *name, mux->reg = reg; mux->shift = PCG_PCS_SHIFT; mux->mask = PCG_PCS_MASK; + mux->lock = &imx_ccm_lock; div = kzalloc(sizeof(*div), GFP_KERNEL); if (!div) @@ -161,6 +162,7 @@ struct clk_hw *imx8m_clk_hw_composite_flags(const char *name, gate_hw = &gate->hw; gate->reg = reg; gate->bit_idx = PCG_CGC_SHIFT; + gate->lock = &imx_ccm_lock; hw = clk_hw_register_composite(NULL, name, parent_names, num_parents, mux_hw, &clk_mux_ops, div_hw,