| Message ID | 1577192466-20762-3-git-send-email-stanley.chu@mediatek.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7c486d91f3d1913a9a6487301ad0ce290bbed9dd |
| Headers | show |
| Series | scsi: ufs: use existed well-defined functions | expand |
On 2019-12-24 05:01, Stanley Chu wrote: > We already have ufshcd_vops_dbg_register_dump() thus all > "hba->vops->dbg_register_dump" references can be replaced by it. > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > drivers/scsi/ufs/ufshcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index b6b9665..1ac9272 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -428,8 +428,7 @@ static void ufshcd_print_host_regs(struct ufs_hba *hba) > > ufshcd_print_clk_freqs(hba); > > - if (hba->vops && hba->vops->dbg_register_dump) > - hba->vops->dbg_register_dump(hba); > + ufshcd_vops_dbg_register_dump(hba); > } Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On 2019-12-24 21:01, Stanley Chu wrote: > We already have ufshcd_vops_dbg_register_dump() thus all > "hba->vops->dbg_register_dump" references can be replaced by it. > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > drivers/scsi/ufs/ufshcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index b6b9665..1ac9272 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -428,8 +428,7 @@ static void ufshcd_print_host_regs(struct ufs_hba > *hba) > > ufshcd_print_clk_freqs(hba); > > - if (hba->vops && hba->vops->dbg_register_dump) > - hba->vops->dbg_register_dump(hba); > + ufshcd_vops_dbg_register_dump(hba); > } > > static Reviewed-by: Can Guo <cang@codeaurora.org>
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index b6b9665..1ac9272 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -428,8 +428,7 @@ static void ufshcd_print_host_regs(struct ufs_hba *hba) ufshcd_print_clk_freqs(hba); - if (hba->vops && hba->vops->dbg_register_dump) - hba->vops->dbg_register_dump(hba); + ufshcd_vops_dbg_register_dump(hba); } static
We already have ufshcd_vops_dbg_register_dump() thus all "hba->vops->dbg_register_dump" references can be replaced by it. Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> --- drivers/scsi/ufs/ufshcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)