| Message ID | 1583233125-7827-6-git-send-email-dennis-yc.hsieh@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | support gce on mt6779 platform | expand |
Hi, Dennis: On Tue, 2020-03-03 at 18:58 +0800, Dennis YC Hsieh wrote: > Return error code to client if send message fail, > so that client has chance to error handling. > Reviewed-by: CK Hu <ck.hu@mediatek.com> > Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com> > Fixes: 576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper") > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 2e1bc513569b..98f23ba3ba47 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -351,7 +351,9 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > spin_unlock_irqrestore(&client->lock, flags); > } > > - mbox_send_message(client->chan, pkt); > + err = mbox_send_message(client->chan, pkt); > + if (err < 0) > + return err; > /* We can send next packet immediately, so just call txdone. */ > mbox_client_txdone(client->chan, 0); >
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c index 2e1bc513569b..98f23ba3ba47 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -351,7 +351,9 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, spin_unlock_irqrestore(&client->lock, flags); } - mbox_send_message(client->chan, pkt); + err = mbox_send_message(client->chan, pkt); + if (err < 0) + return err; /* We can send next packet immediately, so just call txdone. */ mbox_client_txdone(client->chan, 0);
Return error code to client if send message fail, so that client has chance to error handling. Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com> Fixes: 576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper") --- drivers/soc/mediatek/mtk-cmdq-helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)