| Message ID | 1584090304-18043-16-git-send-email-amit.kachhap@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: return address signing | expand |
Hi Amit, On Fri, Mar 13, 2020 at 6:06 PM Amit Daniel Kachhap <amit.kachhap@arm.com> wrote: > > From: Vincenzo Frascino <vincenzo.frascino@arm.com> > > Currently kconfig does not have a feature that allows to detect if the > used assembler supports a specific compilation option. > > Introduce 'as-option' to serve this purpose in the context of Kconfig: > > config X > def_bool $(as-option,...) > > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: linux-kbuild@vger.kernel.org If you have a chance for v8, could you please drop these Cc lines? I had already given Ack, and am satisfied. I have no more comment. Thanks. > Acked-by: Masahiro Yamada <masahiroy@kernel.org> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> > --- > scripts/Kconfig.include | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include > index 85334dc..a1c1925 100644 > --- a/scripts/Kconfig.include > +++ b/scripts/Kconfig.include > @@ -31,6 +31,12 @@ cc-option = $(success,$(CC) -Werror $(CLANG_FLAGS) $(1) -S -x c /dev/null -o /de > # Return y if the linker supports <flag>, n otherwise > ld-option = $(success,$(LD) -v $(1)) > > +# $(as-option,<flag>) > +# /dev/zero is used as output instead of /dev/null as some assembler cribs when > +# both input and output are same. Also both of them have same write behaviour so > +# can be easily substituted. > +as-option = $(success, $(CC) $(CLANG_FLAGS) $(1) -c -x assembler /dev/null -o /dev/zero) > + > # $(as-instr,<instr>) > # Return y if the assembler supports <instr>, n otherwise > as-instr = $(success,printf "%b\n" "$(1)" | $(CC) $(CLANG_FLAGS) -c -x assembler -o /dev/null -) > -- > 2.7.4 >
Hi, On 3/13/20 2:40 PM, Masahiro Yamada wrote: > Hi Amit, > > On Fri, Mar 13, 2020 at 6:06 PM Amit Daniel Kachhap > <amit.kachhap@arm.com> wrote: >> >> From: Vincenzo Frascino <vincenzo.frascino@arm.com> >> >> Currently kconfig does not have a feature that allows to detect if the >> used assembler supports a specific compilation option. >> >> Introduce 'as-option' to serve this purpose in the context of Kconfig: >> >> config X >> def_bool $(as-option,...) >> >> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >> Cc: linux-kbuild@vger.kernel.org > > > If you have a chance for v8, > could you please drop these Cc lines? Ok sure I will remember. Cheers, Amit > > I had already given Ack, and am satisfied. > I have no more comment. > > Thanks. > > > >> Acked-by: Masahiro Yamada <masahiroy@kernel.org> >> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> >> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> >> --- >> scripts/Kconfig.include | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include >> index 85334dc..a1c1925 100644 >> --- a/scripts/Kconfig.include >> +++ b/scripts/Kconfig.include >> @@ -31,6 +31,12 @@ cc-option = $(success,$(CC) -Werror $(CLANG_FLAGS) $(1) -S -x c /dev/null -o /de >> # Return y if the linker supports <flag>, n otherwise >> ld-option = $(success,$(LD) -v $(1)) >> >> +# $(as-option,<flag>) >> +# /dev/zero is used as output instead of /dev/null as some assembler cribs when >> +# both input and output are same. Also both of them have same write behaviour so >> +# can be easily substituted. >> +as-option = $(success, $(CC) $(CLANG_FLAGS) $(1) -c -x assembler /dev/null -o /dev/zero) >> + >> # $(as-instr,<instr>) >> # Return y if the assembler supports <instr>, n otherwise >> as-instr = $(success,printf "%b\n" "$(1)" | $(CC) $(CLANG_FLAGS) -c -x assembler -o /dev/null -) >> -- >> 2.7.4 >> > >
diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include index 85334dc..a1c1925 100644 --- a/scripts/Kconfig.include +++ b/scripts/Kconfig.include @@ -31,6 +31,12 @@ cc-option = $(success,$(CC) -Werror $(CLANG_FLAGS) $(1) -S -x c /dev/null -o /de # Return y if the linker supports <flag>, n otherwise ld-option = $(success,$(LD) -v $(1)) +# $(as-option,<flag>) +# /dev/zero is used as output instead of /dev/null as some assembler cribs when +# both input and output are same. Also both of them have same write behaviour so +# can be easily substituted. +as-option = $(success, $(CC) $(CLANG_FLAGS) $(1) -c -x assembler /dev/null -o /dev/zero) + # $(as-instr,<instr>) # Return y if the assembler supports <instr>, n otherwise as-instr = $(success,printf "%b\n" "$(1)" | $(CC) $(CLANG_FLAGS) -c -x assembler -o /dev/null -)