| Message ID | 1585818532-23051-1-git-send-email-clabbe@baylibre.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 39eb3cc8ab8a5cb7b0a2b728cb653e58319449e9 |
| Headers | show |
| Series | pinctrl: sunxi: handle probe defferal | expand |
On Thu, Apr 02, 2020 at 09:08:52AM +0000, Corentin Labbe wrote: > When checking the logs on my sun8i-a33-olinuxino I saw: > sun8i-a23-r-pinctrl 1f02c00.pinctrl: Reset controller missing > but this driver was working after. > This message is just here because the reset controller was still not probed. > So don't say anything if the return code say to wait. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> Acked-by: Maxime Ripard <mripard@kernel.org> Maxime
On Thu, Apr 2, 2020 at 11:09 AM Corentin Labbe <clabbe@baylibre.com> wrote: > When checking the logs on my sun8i-a33-olinuxino I saw: > sun8i-a23-r-pinctrl 1f02c00.pinctrl: Reset controller missing > but this driver was working after. > This message is just here because the reset controller was still not probed. > So don't say anything if the return code say to wait. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> Patch applied with Maxime's ACK! Thanks, Linus Walleij
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c index 8a08c4afc6a8..9e5b61449999 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c @@ -103,8 +103,11 @@ static int sun8i_a23_r_pinctrl_probe(struct platform_device *pdev) rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); if (IS_ERR(rstc)) { - dev_err(&pdev->dev, "Reset controller missing\n"); - return PTR_ERR(rstc); + ret = PTR_ERR(rstc); + if (ret == -EPROBE_DEFER) + return ret; + dev_err(&pdev->dev, "Reset controller missing err=%d\n", ret); + return ret; } ret = reset_control_deassert(rstc);
When checking the logs on my sun8i-a33-olinuxino I saw: sun8i-a23-r-pinctrl 1f02c00.pinctrl: Reset controller missing but this driver was working after. This message is just here because the reset controller was still not probed. So don't say anything if the return code say to wait. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)